SubdomainsInstallShell::_modifyArray() - Code Metrics - Inspection of "Bug Fix" - multidimension-al/cakephp-subdomains - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bec271...2dcce3 )

by AJ

created 2017-01-02 20:55 UTC

SubdomainsInstallShell::_modifyArray() A

↳ Parent: SubdomainsInstallShell

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	2
nc	1
nop	1

<?php
/**
 * CakePHP Plugin : CakePHP Subdomain Routing
 * Copyright (c) Multidimension.al (http://multidimension.al)
 * Github : https://github.com/multidimension-al/cakephp-subdomains
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE file
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright     (c) Multidimension.al (http://multidimension.al)
 * @link          https://github.com/multidimension-al/cakephp-subdomains Github
 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
 */
    
namespace Multidimensional\Subdomains\Shell;

use Cake\Core\Configure;
use Cake\Console\Shell;

class SubdomainsInstallShell extends Shell {
    
    public function main () {
    
        $subdomains = array();    
    
        $this->clear();
        
        $this->helper('Multidimensional/Subdomains.Header')->output();

    
        $first_run = Configure::check('Multidimensional/Subdomains.subdomains') ? false : true;
        
        if ($first_run === false) {
            
            $subdomains = Configure::consume('Multidimensional/Subdomains.subdomains');
            
            if (count($subdomains) == 0) {
                $first_run = true;
            }
            
        }
       
        if ((($first_run) ? (strtolower($this->in('Install Subdomains Plugin?', ['y', 'n'])) == 'y') : (strtolower($this->in('Update Configuration?', ['y', 'n'])) == 'y'))) {
            
            do {
                
                $addMore = true;
                
                if ($first_run === false && $this->_countSubdomains($subdomains)) {
                
                    $subdomains = array_values(array_unique($subdomains));
                    
                    $subdomains = $this->_modifyArray($subdomains);
                    
                    $this->_currentSubdomains($subdomains);
                    
                    $addMore = $this->_askAddSubdomain();
                                    
                }
                
                if ($addMore) {
                        
                    if (!$this->_countSubdomains($subdomains)) {
                        $this->out();
                        $this->out('Add Your First Subdomain.');
                    }
                        
                    do {
                        
                        $this->out();
                        
                        $subdomain = $this->in('Subdomain:');
                        $valid = $this->_validateSubdomain($subdomain);

                        $this->out();
                        
                        if ($valid) {
                            $subdomains[] = $subdomain;
                        } else {
                            $this->err('Invalid Subdomain.');
                        }
                        
                    } while (!$valid || $this->_askAddSubdomain());
                    
                }
                
                $subdomains = array_values(array_unique($subdomains));
                
                $subdomains = $this->_modifyArray($subdomains);
                
                $this->_currentSubdomains($subdomains);
                            
                while ($this->_countSubdomains($subdomains) && $this->_askDeleteSubdomain()) {
                    
                    $this->out();
                    $deleteKey = (int) $this->in('Enter Number to Delete:', array_keys($subdomains));
                    
                    $this->_deleteSubdomain($subdomains, $deleteKey);
                    
                }
                
                Configure::write('Multidimensional/Subdomains.subdomains', array_values($subdomains));
                Configure::dump('subdomains', 'default', ['Multidimensional/Subdomains']);
                
                if (!$this->_countSubdomains($subdomains)) {
                    $this->out();
                    $this->err('No Subdomains Configured.', 2);                    
                }
                
            } while (count($subdomains) == 0 && $this->_askStartOver());
            
            $this->out();
            if ($this->_countSubdomains($subdomains)) {
                $this->out('Configuration Saved!', 2);
            } else {
                $this->err('Plugin Not Currently Active.', 2);    
            }
        }
    
    }
    
    private function _modifyArray (array $array) {

        return array_combine(range(1, count($array)), array_values($array)); ;    
        
    }
    
    
    private function _currentSubdomains (array $subdomains) {
        
        if ($this->_countSubdomains($subdomains)) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            
            $this->out();
            $this->out('Current Subdomains:', 2);
                
            foreach ($subdomains AS $key => $value) {
                $this->out(' ' . ($key) . '. ' . $value);    
            }                
            
            $this->out();
        
        }
        
    }
    
    private function _askAddSubdomain () {
    
        return (strtolower($this->in('Add Subdomain?', ['y', 'n'])) === 'y');
        
    }
    
    private function _askDeleteSubdomain () {
    
        return (strtolower($this->in('Delete Subdomain?', ['y', 'n'])) === 'y');
        
    }
    
    /**
    * @param integer $key
    */
    private function _deleteSubdomain (&$subdomains, $key) {
        
        if (isset($subdomains[$key])) {
            
            $this->out();
            $this->out('Deleted: ' . $subdomains[$key], 2);
            unset($subdomains[$key]);
        
            return true; 
        
        }
        
        return false;
        
    }
    
    /**
    * @param string|null $subdomain
    */    
    private function _validateSubdomain ($subdomain) {
    
        if (is_null($subdomain) || empty($subdomain)) {
            return false;
        }
    
        return preg_match('/^[A-Za-z0-9]{1}(?:[A-Za-z0-9\-]{0,61}[A-Za-z0-9]{1})?$/', $subdomain);
        
    }
    
    private function _askStartOver () {
        
        return (strtolower($this->in('Start Over?', ['y', 'n'])) === 'y');
        
    }
    
    private function _countSubdomains ($subdomains) {
        
        if (!is_array($subdomains) || is_null($subdomains)) {
            return false;                                
        }
        
        return (int) count($subdomains);        
        
    }
      
}

1			<?php
2			/**
3			* CakePHP Plugin : CakePHP Subdomain Routing
4			* Copyright (c) Multidimension.al (http://multidimension.al)
5			* Github : https://github.com/multidimension-al/cakephp-subdomains
6			*
7			* Licensed under The MIT License
8			* For full copyright and license information, please see the LICENSE file
9			* Redistributions of files must retain the above copyright notice.
10			*
11			* @copyright (c) Multidimension.al (http://multidimension.al)
12			* @link https://github.com/multidimension-al/cakephp-subdomains Github
13			* @license http://www.opensource.org/licenses/mit-license.php MIT License
14			*/
15
16			namespace Multidimensional\Subdomains\Shell;
17
18			use Cake\Core\Configure;
19			use Cake\Console\Shell;
20
21			class SubdomainsInstallShell extends Shell {
22
23			public function main () {
24
25			$subdomains = array();
26
27			$this->clear();
28
29			$this->helper('Multidimensional/Subdomains.Header')->output();
			1 ignored issue – show Bug introduced 2017-01-01 20:29 UTC by Report Bug Copy Issue Report The call to `output()` misses a required argument `$args`. This check looks for function calls that miss required arguments. Loading history...
30
31			$first_run = Configure::check('Multidimensional/Subdomains.subdomains') ? false : true;
32
33			if ($first_run === false) {
34
35			$subdomains = Configure::consume('Multidimensional/Subdomains.subdomains');
36
37			if (count($subdomains) == 0) {
38			$first_run = true;
39			}
40
41			}
42
43			if ((($first_run) ? (strtolower($this->in('Install Subdomains Plugin?', ['y', 'n'])) == 'y') : (strtolower($this->in('Update Configuration?', ['y', 'n'])) == 'y'))) {
44
45			do {
46
47			$addMore = true;
48
49			if ($first_run === false && $this->_countSubdomains($subdomains)) {
50
51			$subdomains = array_values(array_unique($subdomains));
52
53			$subdomains = $this->_modifyArray($subdomains);
54
55			$this->_currentSubdomains($subdomains);
56
57			$addMore = $this->_askAddSubdomain();
58
59			}
60
61			if ($addMore) {
62
63			if (!$this->_countSubdomains($subdomains)) {
64			$this->out();
65			$this->out('Add Your First Subdomain.');
66			}
67
68			do {
69
70			$this->out();
71
72			$subdomain = $this->in('Subdomain:');
73			$valid = $this->_validateSubdomain($subdomain);
74
75			$this->out();
76
77			if ($valid) {
78			$subdomains[] = $subdomain;
79			} else {
80			$this->err('Invalid Subdomain.');
81			}
82
83			} while (!$valid \|\| $this->_askAddSubdomain());
84
85			}
86
87			$subdomains = array_values(array_unique($subdomains));
88
89			$subdomains = $this->_modifyArray($subdomains);
90
91			$this->_currentSubdomains($subdomains);
92
93			while ($this->_countSubdomains($subdomains) && $this->_askDeleteSubdomain()) {
94
95			$this->out();
96			$deleteKey = (int) $this->in('Enter Number to Delete:', array_keys($subdomains));
97
98			$this->_deleteSubdomain($subdomains, $deleteKey);
99
100			}
101
102			Configure::write('Multidimensional/Subdomains.subdomains', array_values($subdomains));
103			Configure::dump('subdomains', 'default', ['Multidimensional/Subdomains']);
104
105			if (!$this->_countSubdomains($subdomains)) {
106			$this->out();
107			$this->err('No Subdomains Configured.', 2);
108			}
109
110			} while (count($subdomains) == 0 && $this->_askStartOver());
111
112			$this->out();
113			if ($this->_countSubdomains($subdomains)) {
114			$this->out('Configuration Saved!', 2);
115			} else {
116			$this->err('Plugin Not Currently Active.', 2);
117			}
118			}
119
120			}
121
122			private function _modifyArray (array $array) {
123
124			return array_combine(range(1, count($array)), array_values($array)); ;
125
126			}
127
128
129			private function _currentSubdomains (array $subdomains) {
130
131			if ($this->_countSubdomains($subdomains)) {
			1 ignored issue – show Bug Best Practice introduced 2017-01-02 20:38 UTC by Report Bug Copy Issue Report The expression `$this->_countSubdomains($subdomains)` of type `false\|integer` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
132
133			$this->out();
134			$this->out('Current Subdomains:', 2);
135
136			foreach ($subdomains AS $key => $value) {
137			$this->out(' ' . ($key) . '. ' . $value);
138			}
139
140			$this->out();
141
142			}
143
144			}
145
146			private function _askAddSubdomain () {
147
148			return (strtolower($this->in('Add Subdomain?', ['y', 'n'])) === 'y');
149
150			}
151
152			private function _askDeleteSubdomain () {
153
154			return (strtolower($this->in('Delete Subdomain?', ['y', 'n'])) === 'y');
155
156			}
157
158			/**
159			* @param integer $key
160			*/
161			private function _deleteSubdomain (&$subdomains, $key) {
162
163			if (isset($subdomains[$key])) {
164
165			$this->out();
166			$this->out('Deleted: ' . $subdomains[$key], 2);
167			unset($subdomains[$key]);
168
169			return true;
170
171			}
172
173			return false;
174
175			}
176
177			/**
178			* @param string\|null $subdomain
179			*/
180			private function _validateSubdomain ($subdomain) {
181
182			if (is_null($subdomain) \|\| empty($subdomain)) {
183			return false;
184			}
185
186			return preg_match('/^[A-Za-z0-9]{1}(?:[A-Za-z0-9\-]{0,61}[A-Za-z0-9]{1})?$/', $subdomain);
187
188			}
189
190			private function _askStartOver () {
191
192			return (strtolower($this->in('Start Over?', ['y', 'n'])) === 'y');
193
194			}
195
196			private function _countSubdomains ($subdomains) {
197
198			if (!is_array($subdomains) \|\| is_null($subdomains)) {
199			return false;
200			}
201
202			return (int) count($subdomains);
203
204			}
205
206			}

multidimension-al / cakephp-subdomains

Push — master ( bec271...2dcce3 )

SubdomainsInstallShell::_modifyArray() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like