MuCTS\Laravel\Pinyin\Pinyin

Complexity

Total Complexity

4

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes	4
Bugs	4	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
A	setLoader()	0	4	2

<?php
/**
 * This file is part of the mucts/laravel-pinyin.
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 *
 * @version 1.0
 * @author herry<yuandeng@aliyun.com>
 * @copyright © 2020 MuCTS.com All Rights Reserved.
 */

namespace MuCTS\Laravel\Pinyin;

use Illuminate\Support\Arr;
use MuCTS\Pinyin\Pinyin as Accessor;

/**
 * Class Pinyin
 * @package MuCTS\Laravel\Pinyin
 */
class Pinyin extends Accessor
{
    private array $config;

    public function __construct(?array $config = null)
    {
        $this->config = $config ?? Arr::wrap(config('pinyin'));
        $path = $loader = null;
        if (is_array($this->config)) {

The condition is_array($this->config) is always true.

            $path = Arr::get($this->config, 'data');
            $loader = Arr::get($this->config, 'default');
        }
        parent::__construct($loader, $path);
    }

    /**
     * Loader setter
     *
     * @param null $loader

Are you sure the doc-type for parameter $loader is correct as it would always require null to be passed?

     * @return $this
     */
    public function setLoader($loader = null): self
    {
        $loader = is_string($loader) ? Arr::get($this->config, 'loaders.' . $loader, $loader) : $loader;

The condition is_string($loader) is always false.

        return parent::setLoader($loader);

The expression return parent::setLoader($loader) returns the type MuCTS\Pinyin\Pinyin which includes types incompatible with the type-hinted return MuCTS\Laravel\Pinyin\Pinyin.

    }
}