Bmatovu\Ussd\Traits\ParserUtils

Complexity

Total Complexity

16

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Test Coverage

Coverage

93.18%

Importance

Changes	5
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__get()	0	3	1
A	sessionExists()	0	5	1
A	resolveTagName()	0	11	2
A	resolveTagClass()	0	18	3
A	getAnswer()	0	21	5
A	clean()	0	3	1
A	instantiateTag()	0	5	1
A	xpathFromStr()	0	7	1
A	__set()	0	3	1

<?php

namespace Bmatovu\Ussd\Traits;

use Bmatovu\Ussd\Contracts\RenderableTag;
use Illuminate\Container\Container;
use Illuminate\Contracts\Config\Repository as ConfigRepository;
use Illuminate\Support\Str;

trait ParserUtils
{
    public function __get(string $key)
    {
        return $this->{$key};
    }

    public function __set(string $key, $value)
    {
        $this->{$key} = $value;
    }

    protected function xpathFromStr(string $file): \DOMXPath
    {
        $doc = new \DOMDocument();

        $doc->load($file);

        return new \DOMXPath($doc);
    }

    protected function sessionExists(string $sessionId): bool
    {
        $preSessionId = $this->store->get('_session_id', '');

The property store does not exist on Bmatovu\Ussd\Traits\ParserUtils. Since you implemented __get, consider adding a @property annotation.

        return $preSessionId === $sessionId;
    }

    protected function clean(string $code = ''): string
    {
        return trim(trim($code, '*'), '#');
    }

    protected function getAnswer(?string $userInput): ?string
    {
        if ('' === (string) $userInput) {
            return '';
        }

        $preAnswer = $this->store->get('_answer', '');

The property store does not exist on Bmatovu\Ussd\Traits\ParserUtils. Since you implemented __get, consider adding a @property annotation.

        $answer = $this->clean(str_replace($preAnswer, '', $userInput));

        if ('' === (string) $answer) {
            return '';
        }

        if (! $preAnswer || Str::endsWith($preAnswer, '*')) {
            $this->store->append('_answer', "{$answer}*");
        } else {
            $this->store->append('_answer', "*{$answer}*");
        }

        return $answer;
    }

    protected function resolveTagName(\DOMNode $node): string
    {
        $tagName = $node->tagName;

        if ('action' !== strtolower($tagName)) {
            return Str::studly("{$tagName}Tag");
        }

        $tagName = $node->attributes->getNamedItem('name')->nodeValue;

The method getNamedItem() does not exist on null.

        return Str::studly("{$tagName}Action");
    }

    protected function resolveTagClass(string $tagName): string
    {
        $config = Container::getInstance()->make(ConfigRepository::class);
        $tagNs = $config->get('ussd.tag-ns', []);
        $actionNs = $config->get('ussd.action-ns', []);

        $namespaces = array_merge($tagNs, $actionNs);

        $fqcn = $tagName;

The assignment to $fqcn is dead and can be removed.

        foreach ($namespaces as $ns) {
            $fqcn = "{$ns}\\{$tagName}";
            if (class_exists($fqcn)) {
                return $fqcn;
            }
        }

        throw new \Exception("Missing tag {$tagName}.");
    }

    protected function instantiateTag(string $tagName, array $args = []): RenderableTag
    {
        $fqcn = $this->resolveTagClass($tagName);

        return \call_user_func_array([new \ReflectionClass($fqcn), 'newInstance'], $args);
    }
}