Bmatovu\Ussd\Traits\Variables::getVar()

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function getVar(string $name, string $default = '', string $nodeName = 'variable'): string
    {
        $children = Dom::getElements($this->node->childNodes, $nodeName);

        foreach ($children as $child) {
            if ($name === $this->readAttrText('name', '', $child)) {

It seems like readAttrText() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                return $this->readAttrText('value', $default, $child);
            }
        }

        return $default;
    }