Bmatovu\RouteList\Http\RouteListController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	92
Duplicated Lines	32.61 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

90.32%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	__invoke()	16	26	3
A	getRouteMiddleware()	0	8	2
A	matches()	14	14	3

<?php

namespace Bmatovu\RouteList\Http;

use Illuminate\Routing\Controller;
use Illuminate\Routing\Router;

/**
 * @see \Illuminate\Foundation\Console\RouteListCommand
 */
class RouteListController extends Controller
{
    /**
     * Router.
     *
     * @var \Illuminate\Routing\Router
     */
    protected $router;

    /**
     * Create a controller instance.
     *
     * @param \Illuminate\Routing\Router $router
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(Router $router)
    {
        $this->router = $router;
    }

    /**
     * Render routes.
     *
     * @return \Illuminate\View\View
     */
    public function __invoke()
    {
        $routes = collect($this->router->getRoutes())
            ->filter(function ($route) {
                return ! $this->matches(config('route-list.excluded'), $route->uri);
            })->map(function ($route) {

This code seems to be duplicated across your project.

                $name = $route->action['as'] ?? '';

                if ($name && $this->matches(['/^generated::/'], $name)) {
                    $name = '';
                }

                return [
                    // 'host' => $route->action['where'],
                    'uri' => $route->uri,
                    'name' => $name,
                    'methods' => $route->methods,
                    'action' => $route->action['controller'] ?? 'Closure',
                    'middleware' => $this->getRouteMiddleware($route),
                ];
            });

        return view('route-list::index', [

The expression view('route-list::index', array('routes' => $routes)); of type Illuminate\Contracts\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 59 which is incompatible with the return type documented by Bmatovu\RouteList\Http\RouteListController::__invoke of type Illuminate\View\View.

            'routes' => $routes,
        ]);
    }

    /**
     * Get route middleware.
     *
     * @param \Illuminate\Routing\Route $route
     *
     * @return string
     */
    protected function getRouteMiddleware($route)
    {
        $middlewares = collect($route->gatherMiddleware())->map(function ($middleware) {
            return $middleware instanceof \Closure ? 'Closure' : $middleware;
        });

        return $middlewares->implode(', ');
    }

    /**
     * Perform a regular expression match.
     *
     * @param array  $patterns
     * @param string $subject
     *
     * @return bool
     */
    protected function matches($patterns, $subject)

This method seems to be duplicated in your project.

    {
        $isMatched = false;

        foreach ($patterns as $pattern) {
            if (preg_match($pattern, $subject)) {
                $isMatched = true;

                break;
            }
        }

        return $isMatched;
    }
}