Cerberus\Cerberus

Complexity

Total Complexity

11

Size/Duplication

Total Lines	135
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	6
Bugs	3	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	isAvailable()	0	4	1
A	__construct()	0	7	1
B	getStatus()	0	38	5
A	reportFailure()	0	5	1
A	reportSuccess()	0	5	1
A	setNamespace()	0	8	2

<?php

/**
 * The Cerberus class.
 *
 * @author  Leandro Silva <leandro@leandrosilva.info>
 * @license https://github.com/mt-olympus/cerberus/blob/master/LICENSE MIT Licence
 */
namespace Cerberus;

use Zend\Cache\Storage\StorageInterface;

/**
 * The Cerberus Class.
 *
 * @author  Leandro Silva <leandro@leandrosilva.info>
 * @license https://github.com/mt-olympus/cerberus/blob/master/LICENSE MIT Licence
 */
class Cerberus implements CerberusInterface
{
    /**
     * The storage object.
     *
     * @var \Zend\Cache\Storage\StorageInterface
     */
    private $storage;

    /**
     * Maximum number of failures to open the circuit.
     *
     * @var int
     */
    private $maxFailures;

    /**
     * Number of seconds to change from OPEN to HALF OPEN and try the connection again.
     *
     * @var int
     */
    private $timeout;

    /**
     * The default namespace used by the zend-cache storage.
     *
     * @var string
     */
    private $defaultNamespace;

    /**
     * Constructor.
     *
     * @param StorageInterface $storage     The storage object
     * @param int              $maxFailures Maximum number of failures to open the circuit
     * @param int              $timeout     Number of seconds to change from OPEN to HALF OPEN
     */
    public function __construct(StorageInterface $storage, $maxFailures = 5, $timeout = 30)
    {
        $this->maxFailures = (int) $maxFailures;
        $this->timeout = (int) $timeout;
        $this->storage = $storage;
        $this->defaultNamespace = $this->storage->getOptions()->getNamespace();
    }

    /**
     * {@inheritdoc}
     *
     * @see \Cerberus\CerberusInterface::isAvailable()
     */
    public function isAvailable($serviceName = null)
    {
        return $this->getStatus($serviceName) !== CerberusInterface::OPEN;
    }

    /**
     * {@inheritdoc}
     *
     * @see \Cerberus\CerberusInterface::getStatus()
     */
    public function getStatus($serviceName = null)
    {
        $this->setNamespace($serviceName);

        $success = false;
        $failures = (int) $this->storage->getItem('failures', $success);
        if (!$success) {

The expression $success of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            $failures = 0;
            $this->storage->setItem('failures', $failures);
        }

        // Still has failures left
        if ($failures < $this->maxFailures) {
            return CerberusInterface::CLOSED;
        }

        $success = false;
        $lastAttempt = $this->storage->getItem('last_attempt', $success);

        // This is the first attempt after a failure, open the circuit
        if (!$success) {

The expression $success of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            $lastAttempt = time();
            $this->storage->setItem('last_attempt', $lastAttempt);

            return CerberusInterface::OPEN;
        }

        // Reached maxFailues but has passed the timeout limit, so we can try again
        // We update the lastAttempt so only one call passes through
        if (time() - $lastAttempt >= $this->timeout) {
            $lastAttempt = time();
            $this->storage->setItem('last_attempt', $lastAttempt);

            return CerberusInterface::HALF_OPEN;
        }

        return CerberusInterface::OPEN;
    }

    /**
     * {@inheritdoc}
     *
     * @see \Cerberus\CerberusInterface::reportFailure()
     */
    public function reportFailure($serviceName = null)
    {
        $this->setNamespace($serviceName);
        $this->storage->incrementItem('failures', 1);
    }

    /**
     * {@inheritdoc}
     *
     * @see \Cerberus\CerberusInterface::reportSuccess()
     */
    public function reportSuccess($serviceName = null)
    {
        $this->setNamespace($serviceName);
        $this->storage->setItem('failures', 0);
    }

    /**
     * Sets the zend-cache storage namespace.
     *
     * @param string $serviceName
     */
    private function setNamespace($serviceName = null)
    {
        if ($serviceName === null) {
            $this->storage->getOptions()->setNamespace($this->defaultNamespace);
        } else {
            $this->storage->getOptions()->setNamespace($serviceName);
        }
    }
}