Issues in WebSocketMessagesManager.php (master) - Issues in master - mshamaseen/laravel-ratchet - Measure and Improve Code Quality continuously with Scrutinizer

Issues (80)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Traits/WebSocketMessagesManager.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Created by PhpStorm.
 * User: shanmaseen
 * Date: 23/03/19
 * Time: 10:15 م
 */

namespace Shamaseen\Laravel\Ratchet\Traits;


use Shamaseen\Laravel\Ratchet\Exceptions\WebSocketException;
use Ratchet\ConnectionInterface;

/**
 * Trait WebSocketMessagesManager
 * @package App\WebSockets
 */
trait WebSocketMessagesManager
{
    /**
     * @param $request
     * @param ConnectionInterface $from
     * @param $error
     * @throws WebSocketException
     */
    function error($request,ConnectionInterface $from, $error)

    {
        if(env('APP_DEBUG'))
        {
            echo 'User error: ';
            echo $error."\n";
            print_r($request);
            echo " ============================================================== \n \n \n";
        }

        $data = [
            'event'=>'error',
            'message'=>$error
        ];
        $this->sendToWebSocketUser($from,$data);
        throw new WebSocketException();
    }

    /**
     * @param ConnectionInterface $conn
     * @param $data
     */
    function sendToWebSocketUser(ConnectionInterface $conn,$data)

    {
        if(!is_array($data))
            $data = ['msg'=>$data,'event'=>'default'];

        if(!isset($data['event']))
        {
            $data['event'] = 'default';
        }

        if(isset($this->route) && !array_key_exists('sender',$data))
            $data['sender'] = $this->getSenderData();

        $conn->send(json_encode($data));
    }

    /**
     * @param int $user_id
     * @param array $data
     * @return bool
     */
    function sendToUser($user_id,$data)

    {
        if(!$this->isOnline($user_id))
        {
            return false;
        }

        $resourceId = $this->userAuthSocketMapper[$user_id];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        /** @var ConnectionInterface $conn */
        $conn = $this->clients[$resourceId]->conn;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->sendToWebSocketUser($conn,$data);
        return true;
    }

    /**
     * @param $data
     */
    function sendBack($data)

    {
       $this->sendToWebSocketUser($this->conn,$data);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     *
     * @return array
     */
    function getSenderData()

    {
        return [
            'id' => \Auth::id(),
            'name'=> \Auth::user()->name
        ];
    }

    function isOnline($user_id)

    {
        if(array_key_exists($user_id,$this->userAuthSocketMapper))
        {
            return true;
        }

        return false;
    }

}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: shanmaseen
5			* Date: 23/03/19
6			* Time: 10:15 م
7			*/
8
9			namespace Shamaseen\Laravel\Ratchet\Traits;
10
11
12			use Shamaseen\Laravel\Ratchet\Exceptions\WebSocketException;
13			use Ratchet\ConnectionInterface;
14
15			/**
16			* Trait WebSocketMessagesManager
17			* @package App\WebSockets
18			*/
19			trait WebSocketMessagesManager
20			{
21			/**
22			* @param $request
23			* @param ConnectionInterface $from
24			* @param $error
25			* @throws WebSocketException
26			*/
27			function error($request,ConnectionInterface $from, $error)
			0 ignored issues – show Best Practice introduced 2019-03-26 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
28			{
29			if(env('APP_DEBUG'))
30			{
31			echo 'User error: ';
32			echo $error."\n";
33			print_r($request);
34			echo " ============================================================== \n \n \n";
35			}
36
37			$data = [
38			'event'=>'error',
39			'message'=>$error
40			];
41			$this->sendToWebSocketUser($from,$data);
42			throw new WebSocketException();
43			}
44
45			/**
46			* @param ConnectionInterface $conn
47			* @param $data
48			*/
49			function sendToWebSocketUser(ConnectionInterface $conn,$data)
			0 ignored issues – show Best Practice introduced 2019-03-26 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
50			{
51			if(!is_array($data))
52			$data = ['msg'=>$data,'event'=>'default'];
53
54			if(!isset($data['event']))
55			{
56			$data['event'] = 'default';
57			}
58
59			if(isset($this->route) && !array_key_exists('sender',$data))
60			$data['sender'] = $this->getSenderData();
61
62			$conn->send(json_encode($data));
63			}
64
65			/**
66			* @param int $user_id
67			* @param array $data
68			* @return bool
69			*/
70			function sendToUser($user_id,$data)
			0 ignored issues – show Best Practice introduced 2019-03-26 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
71			{
72			if(!$this->isOnline($user_id))
73			{
74			return false;
75			}
76
77			$resourceId = $this->userAuthSocketMapper[$user_id];
			0 ignored issues – show Bug introduced 2019-03-26 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `userAuthSocketMapper` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
78			/** @var ConnectionInterface $conn */
79			$conn = $this->clients[$resourceId]->conn;
			0 ignored issues – show Bug introduced 2019-03-26 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `clients` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
80			$this->sendToWebSocketUser($conn,$data);
81			return true;
82			}
83
84			/**
85			* @param $data
86			*/
87			function sendBack($data)
			0 ignored issues – show Best Practice introduced 2019-03-26 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
88			{
89			$this->sendToWebSocketUser($this->conn,$data);
			0 ignored issues – show Bug introduced 2019-03-26 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `conn` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
90			}
91
92			/**
93			*
94			* @return array
95			*/
96			function getSenderData()
			0 ignored issues – show Best Practice introduced 2019-03-26 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
97			{
98			return [
99			'id' => \Auth::id(),
100			'name'=> \Auth::user()->name
101			];
102			}
103
104			function isOnline($user_id)
			0 ignored issues – show Best Practice introduced 2019-04-28 09:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
105			{
106			if(array_key_exists($user_id,$this->userAuthSocketMapper))
107			{
108			return true;
109			}
110
111			return false;
112			}
113
114			}

mshamaseen / laravel-ratchet

Issues (80)

Security Analysis no request data

src/Traits/WebSocketMessagesManager.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like