Shamaseen\Laravel\Ratchet\Traits\Validation

Complexity

Total Complexity

7

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	validateRequired()	0	10	3
A	requireErrorMessage()	0	4	1
A	validate()	0	10	2
A	getValidationFactory()	0	4	1

<?php
/**
 * Created by PhpStorm.
 * User: shanmaseen
 * Date: 26/03/19
 * Time: 01:39 م
 */

namespace Shamaseen\Laravel\Ratchet\Traits;

use Illuminate\Contracts\Validation\Factory;
use Illuminate\Support\Collection;

trait Validation
{
    /**
     * @param array $required
     */
    function validateRequired($required)

It is generally recommended to explicitly declare the visibility for methods.

    {
        foreach ($required as $input)
        {
            if(!in_array($input,(array)$this->request))
            {
                $this->error($this->request,$this->conn,$this->requireErrorMessage($input));

The property request does not exist. Did you maybe forget to declare it?

The property conn does not exist. Did you maybe forget to declare it?

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        }
    }

    /**
     * @param $input
     * @return string
     */
    function requireErrorMessage($input)

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $input.' input is required.';
    }

    /**
     * Validate the given request with the given rules.
     *
     * @param  object  $request
     * @param  array  $rules
     * @param  array  $messages
     * @param  array  $customAttributes
     * @return array
     *
     * @throws \Illuminate\Validation\ValidationException
     */
    public function validate($request, array $rules,
                             array $messages = [], array $customAttributes = [])
    {
        if($request instanceof Collection)
            $request = $request->toArray();

        return $this->getValidationFactory()->make(
            (array) $request, $rules, $messages, $customAttributes
        )->validate();
    }

    /**
     * Get a validation factory instance.
     *
     * @return \Illuminate\Contracts\Validation\Factory
     */
    protected function getValidationFactory()
    {
        return app(Factory::class);
    }
}