Shamaseen\Laravel\Ratchet\Controllers\RoomController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	enterRoom()	0	11	1
A	exitRoom()	0	12	1

<?php
/**
 * Created by PhpStorm.
 * User: shanmaseen
 * Date: 26/03/19
 * Time: 10:57 ص
 */

namespace Shamaseen\Laravel\Ratchet\Controllers;


use Shamaseen\Laravel\Ratchet\Traits\RoomUtility;

class RoomController extends WebSocketController
{
    use RoomUtility;

    /**
     * @throws \Illuminate\Validation\ValidationException
     */
    function enterRoom()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->validate($this->request,[
            'room_id'=>'required'
        ]);
        $room_id =$this->request->room_id;

The property room_id does not seem to exist in Illuminate\Support\Collection.

        $this->validateRoom($room_id,true);

        $this->addMember($room_id);
    }

    /**
     * @throws \Illuminate\Validation\ValidationException
     */
    function exitRoom()

It is generally recommended to explicitly declare the visibility for methods.

    {

        $this->validate($this->request,[
            'room_id'=>'required'
        ]);
        $room_id =$this->request->room_id;

The property room_id does not seem to exist in Illuminate\Support\Collection.

        $this->validateRoom($room_id);

        $this->removeMember($room_id);
    }
}