Shamaseen\Laravel\Ratchet\Controllers\ChatController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	sendMessageToUser()	0	12	1
A	sendMessageToRoom()	0	10	1

<?php
/**
 * Created by PhpStorm.
 * User: shanmaseen
 * Date: 26/03/19
 * Time: 12:17 م
 */

namespace Shamaseen\Laravel\Ratchet\Controllers;


use Shamaseen\Laravel\Ratchet\Traits\RoomUtility;

class ChatController extends WebSocketController
{

    use RoomUtility;

    /**
     * @throws \Illuminate\Validation\ValidationException
     */
    function sendMessageToUser()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->validate($this->request,[
            'user_id'=>'required',
            'message' => 'required'
        ]);

        $user_id = $this->request->user_id;

The property user_id does not seem to exist in Illuminate\Support\Collection.

        $data = ['message'=>$this->request->message,'event'=>'receivedMessage'];

        $this->sendToUser($user_id,$data);
    }

    /**
     * @throws \Illuminate\Validation\ValidationException
     */
    function sendMessageToRoom()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->validate($this->request,[
            'room_id'=>'required',
            'message' => 'required'
        ]);
        $room_id = $this->request->room_id;

The property room_id does not seem to exist in Illuminate\Support\Collection.

        $data = ['message'=>$this->request->message,'event'=>'RoomMessage'];
        $this->sendToRoom($room_id,$data);
    }
}