PatchFind\Graph\Generate::loadFromFile()

Complexity

Conditions	17
Paths	2

Size

Total Lines	57
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

<?php
        public function loadFromFile($file){
            
            $res = @imagecreatefromjpeg($file);
           
            if(!$res){

$res is of type false|resource, thus it always evaluated to false.

                $width = imagesx($res);

It seems like $res can also be of type false; however, parameter $image of imagesx() does only seem to accept resource, maybe add an additional type check?

                $height = imagesy($res);

It seems like $res can also be of type false; however, parameter $image of imagesy() does only seem to accept resource, maybe add an additional type check?

                $new_tab = array();
                for($y = 0; $y <= $height; $y++){
                    for($x = 0; $x <= $width; $x++){
                        if($y==$height || $x==$width){
                            $color = 10;
                        }else{
                            $color = imagecolorat($res, $x, $y);

It seems like $res can also be of type false; however, parameter $image of imagecolorat() does only seem to accept resource, maybe add an additional type check?

                            if(!$color) $color = 255;
                        }
                        $new_tab[$x][$y] = $color;
                    }
                } 

                $this->x_w = $width;
                $this->y_h = $height;

                $modX = ceil($width/2);
                $modY = ceil($height/2);

                $relations = array();
                for($y = 0; $y <= $height; $y++){
                    for($x = 0; $x <= $width; $x++){

                        if($new_tab[$x][$y]<=100){
                           $k3 = 9999; 
                        }else{
                            $k = $x; $k2 = $y;
                            if($x<$modX) $k = $width-$x;
                            if($y<$modY) $k2 = $height-$y;
                            $k3 = $k;
                            if($k2>$k) $k3 = $k2;
                        }
                        $tmpX = $x-1; $tmpY = $y;
                        if($this->checkParams($tmpX, $tmpY)) $relations["($tmpX,$tmpY)"]["($x,$y)"] = $k3;

                        $tmpX2 = $x+1; $tmpY2 = $y;
                        if($this->checkParams($tmpX2, $tmpY2)) $relations["($tmpX2,$tmpY2)"]["($x,$y)"] = $k3;

                        $tmpX3 = $x; $tmpY3 = $y-1;
                        if($this->checkParams($tmpX3, $tmpY3)) $relations["($tmpX3,$tmpY3)"]["($x,$y)"] = $k3;

                        $tmpX4 = $x; $tmpY4 = $y+1;
                        if($this->checkParams($tmpX4, $tmpY4)) $relations["($tmpX4,$tmpY4)"]["($x,$y)"] = $k3;
                    }
                }
                $relations = $res;
            }
            
            return $relations;

The expression return $relations returns the type false|resource which is incompatible with the documented return type array.

The variable $relations does not seem to be defined for all execution paths leading up to this point.

        }