Fhp\Response\GetAccounts

Complexity

Total Complexity

5

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getAccountsArray()	0	14	3
A	createModelFromArray()	0	18	2

<?php

namespace Fhp\Response;

use Fhp\Model\Account;

/**
 * Class GetAccounts
 * @package Fhp\Response
 */
class GetAccounts extends Response
{
    const SEG_ACCOUNT_INFORMATION = 'HIUPD';

    /** @var array */
    protected $accounts = array();

    /**
     * @return array
     */
    public function getAccountsArray()
    {
        $accounts = $this->findSegments(static::SEG_ACCOUNT_INFORMATION);

        foreach ($accounts as $account) {

The expression $accounts of type array|null|string is not guaranteed to be traversable. How about adding an additional type check?

            $accountParts = $this->splitSegment($account);
            $account = $this->createModelFromArray($accountParts);
            if ($account !== null) {
                $this->accounts[] = $account;
            }
        }

        return $this->accounts;
    }

    /**
     * Creates a Account model from array.
     *
     * @param array $array
     * @return Account
     */
    protected function createModelFromArray(array $array)
    {
        if (!$array[1]) {
            return null;
        }
        $account = new Account();
        list($accountNumber, $x, $countryCode, $bankCode) = explode(':', $array[1]);

The assignment to $x is unused. Consider omitting it like so list($first,,$third).

The assignment to $countryCode is unused. Consider omitting it like so list($first,,$third).

        $account->setId($array[1]);
        $account->setAccountNumber($accountNumber);
        $account->setBankCode($bankCode);
        $account->setIban($array[2]);
        $account->setCustomerId($array[3]);
        $account->setCurrency($array[5]);
        $account->setAccountOwnerName($array[6]);
        $account->setAccountDescription($array[8]);

        return $account;
    }
}