Address::__construct() - Code Metrics - Inspection of "feat(constructors): Add constructors to set defaul..." - mrprompt/ShipmentCommon - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Thiago

created 2018-12-01 23:56 UTC

Address::__construct() A

↳ Parent: Address

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	9
cts	9
cp	1
rs	9.7
c	0
b	0
f	0
cc	1
nc	1
nop	7
crap	1

<?php
namespace MrPrompt\ShipmentCommon\Base;

/**
 * Address
 *
 * @author Thiago Paes <[email protected]>
 */
class Address
{
    /**
     * City
     *
     * @var string
     */
    private $city;

    /**
     * State
     *
     * @var string
     */
    private $state;

    /**
     * Postal Code - CEP
     *
     * @var string
     */
    private $postalCode;

    /**
     * Address
     *
     * @var string
     */
    private $address;

    /**
     * Address Number
     *
     * @var int
     */
    private $number;

    /**
     * District
     *
     * @var string
     */
    private $district;

    /**
     * Complement
     *
     * @var string
     */
    private $complement;

    /**
     * Constructor
     * 
     * @param string $city
     * @param string $state
     * @param string $postalCode
     * @param string $address
     * @param string $number
     * @param string $district
     * @param string $complement
     */
    public function __construct(
        string $city = '',
        string $state = '',
        string $postalCode = '',
        string $address = '',
        string $number = '',
        string $district = '',
        string $complement = ''
    ) {
        $this->city = $city;
        $this->state = $state;
        $this->postalCode = $postalCode;
        $this->address = $address;
        $this->number = $number;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->district = $district;
        $this->complement = $complement;
    }

    /**
     * Return the city
     * 
     * @return string
     */
    public function getCity(): string
    {
        return $this->city;
    }

    /**
     * Set the city
     * 
     * @param string $city
     */
    public function setCity(string $city)
    {
        $this->city = $city;
    }

    /**
     * Get the state
     * 
     * @return string
     */
    public function getState(): string
    {
        return $this->state;
    }

    /**
     * Set the state
     * 
     * @param string $state
     */
    public function setState(string $state)
    {
        $this->state = $state;
    }

    /**
     * Get the postal code
     * 
     * @return string
     */
    public function getPostalCode(): string
    {
        return $this->postalCode;
    }

    /**
     * Set the postal code
     * 
     * @param string $postalCode
     */
    public function setPostalCode(string $postalCode)
    {
        $this->postalCode = $postalCode;
    }

    /**
     * @return the $address
     */
    public function getAddress()
    {
        return $this->address;
    }

    /**
     * @param string $address
     */
    public function setAddress(string $address)
    {
        $this->address = $address;
    }

    /**
     * @return the $number
     */
    public function getNumber(): string
    {
        return $this->number;
    }

    /**
     * @param string $number
     */
    public function setNumber(string $number)
    {
        $this->number = $number;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * @return the $district
     */
    public function getDistrict(): string
    {
        return $this->district;
    }

    /**
     * @param string $district
     */
    public function setDistrict(string $district)
    {
        $this->district = $district;
    }

    /**
     * @return the $complement
     */
    public function getComplement(): string
    {
        return $this->complement;
    }

    /**
     * @param string $complement
     */
    public function setComplement(string $complement)
    {
        $this->complement = $complement;
    }
}


1		<?php
2		namespace MrPrompt\ShipmentCommon\Base;
3
4		/**
5		* Address
6		*
7		* @author Thiago Paes <[email protected]>
8		*/
9		class Address
10		{
11		/**
12		* City
13		*
14		* @var string
15		*/
16		private $city;
17
18		/**
19		* State
20		*
21		* @var string
22		*/
23		private $state;
24
25		/**
26		* Postal Code - CEP
27		*
28		* @var string
29		*/
30		private $postalCode;
31
32		/**
33		* Address
34		*
35		* @var string
36		*/
37		private $address;
38
39		/**
40		* Address Number
41		*
42		* @var int
43		*/
44		private $number;
45
46		/**
47		* District
48		*
49		* @var string
50		*/
51		private $district;
52
53		/**
54		* Complement
55		*
56		* @var string
57		*/
58		private $complement;
59
60		/**
61		* Constructor
62		*
63		* @param string $city
64		* @param string $state
65		* @param string $postalCode
66		* @param string $address
67		* @param string $number
68		* @param string $district
69		* @param string $complement
70		*/
71	17	public function __construct(
72		string $city = '',
73		string $state = '',
74		string $postalCode = '',
75		string $address = '',
76		string $number = '',
77		string $district = '',
78		string $complement = ''
79		) {
80	17	$this->city = $city;
81	17	$this->state = $state;
82	17	$this->postalCode = $postalCode;
83	17	$this->address = $address;
84	17	$this->number = $number;
		0 ignored issues – show Documentation Bug introduced 2018-12-01 23:57 UTC by Report Bug Copy Issue Report The property `$number` was declared of type `integer`, but `$number` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
85	17	$this->district = $district;
86	17	$this->complement = $complement;
87	17	}
88
89		/**
90		* Return the city
91		*
92		* @return string
93		*/
94	1	public function getCity(): string
95		{
96	1	return $this->city;
97		}
98
99		/**
100		* Set the city
101		*
102		* @param string $city
103		*/
104	2	public function setCity(string $city)
105		{
106	2	$this->city = $city;
107	2	}
108
109		/**
110		* Get the state
111		*
112		* @return string
113		*/
114	1	public function getState(): string
115		{
116	1	return $this->state;
117		}
118
119		/**
120		* Set the state
121		*
122		* @param string $state
123		*/
124	2	public function setState(string $state)
125		{
126	2	$this->state = $state;
127	2	}
128
129		/**
130		* Get the postal code
131		*
132		* @return string
133		*/
134	1	public function getPostalCode(): string
135		{
136	1	return $this->postalCode;
137		}
138
139		/**
140		* Set the postal code
141		*
142		* @param string $postalCode
143		*/
144	1	public function setPostalCode(string $postalCode)
145		{
146	1	$this->postalCode = $postalCode;
147	1	}
148
149		/**
150		* @return the $address
151		*/
152	1	public function getAddress()
153		{
154	1	return $this->address;
155		}
156
157		/**
158		* @param string $address
159		*/
160	2	public function setAddress(string $address)
161		{
162	2	$this->address = $address;
163	2	}
164
165		/**
166		* @return the $number
167		*/
168	1	public function getNumber(): string
169		{
170	1	return $this->number;
171		}
172
173		/**
174		* @param string $number
175		*/
176	1	public function setNumber(string $number)
177		{
178	1	$this->number = $number;
		0 ignored issues – show Documentation Bug introduced 2018-12-01 20:44 UTC by Report Bug Copy Issue Report The property `$number` was declared of type `integer`, but `$number` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
179	1	}
180
181		/**
182		* @return the $district
183		*/
184	1	public function getDistrict(): string
185		{
186	1	return $this->district;
187		}
188
189		/**
190		* @param string $district
191		*/
192	1	public function setDistrict(string $district)
193		{
194	1	$this->district = $district;
195	1	}
196
197		/**
198		* @return the $complement
199		*/
200	1	public function getComplement(): string
201		{
202	1	return $this->complement;
203		}
204
205		/**
206		* @param string $complement
207		*/
208	1	public function setComplement(string $complement)
209		{
210	1	$this->complement = $complement;
211	1	}
212		}
213

mrprompt / ShipmentCommon

Pull Request — master (#2)

Address::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like