Issues in File.php (master) - Issues in master - mrprompt/Centercob - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Received/File.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace MrPrompt\Centercob\Received;

use DateTime;
use MrPrompt\ShipmentCommon\Base\Cart;
use MrPrompt\ShipmentCommon\Base\Customer;
use MrPrompt\ShipmentCommon\Util\Number;
use MrPrompt\Centercob\Received\Partial\Detail;
use MrPrompt\Centercob\Received\Partial\Footer;
use MrPrompt\Centercob\Received\Partial\Header;

/**
 * Received file class
 *
 * @author Thiago Paes <[email protected]>
 */
class File
{
    /**
     * File name template
     *
     * @var string
     */
    const TEMPLATE_GENERATED = 'RET{CLIENT}-{DD.MM.YYYY-HH.MM.SS}.TXT';

    /**
     * File name template
     *
     * @var string
     */
    const TEMPLATE_PROCESSED = 'RET{CLIENT}-{DD.MM.YYYY-HH.MM.SS}.TXT';

    /**
     * @var Header
     */
    private $header;

    /**
     * @var ArrayObject
     */
    private $cart;

    /**
     * @var Footer
     */
    private $footer;

    /**
     * @var array
     */
    private $rows = [];

    /**
     * @var Customer
     */
    private $customer;

    /**
     * @var DateTime
     */
    private $now;

    /**
     * @param Customer $customer
     * @param DateTime $date
     * @param string $storageDir
     */
    public function __construct(Customer $customer, DateTime $date, $storageDir = null)
    {
        $this->customer = $customer;
        $this->now      = $date;

        $file           = $storageDir . DIRECTORY_SEPARATOR . $this->createFilename();
        $content        =  file_get_contents($file);

        $this->rows     = explode(PHP_EOL, $content);

        $this->getHeader();
        $this->getFooter();
        $this->getCart();
    }

    /**
     * Create the file name
     *
     * @return string
     */
    private function createFilename($type = self::TEMPLATE_GENERATED)
    {
        $search = [
            '{CLIENT}',
            '{DD.MM.YYYY-HH.MM.SS}',
        ];

        $replace = [
            Number::zeroFill($this->customer->getCode(), 7, Number::FILL_LEFT),
            $this->now->format('d.m.Y-H.i.s'),
        ];

        return str_replace($search, $replace, $type);
    }

    /**
     * @return Header
     */
    public function getHeader()
    {
        $headerLine     = array_shift($this->rows);
        $this->header   = new Header($headerLine);

        return $this->header;
    }

    /**
     * @return Footer
     */
    public function getFooter()
    {
        $footerLine     = array_pop($this->rows);

        if (null === $footerLine || "" === $footerLine) {
            $footerLine = array_pop($this->rows);
        }

        $this->footer   = new Footer($footerLine);

        return $this->footer;
    }

    /**
     * @return \ArrayObject
     */
    public function getCart()
    {
        $this->cart     = new Cart();


        /* @var $detail \Centercob\Gateway\Received\Partial\Detail */
        foreach ($this->rows as $row) {
            $detail = new Detail($row);

            $this->cart->addItem($detail);
        }

        return $this->cart;
    }

    /**
     * @return mixed
     */
    public function getAll()
    {
        return [
            $this->header,
            $this->cart,
            $this->footer
        ];
    }
}


1		<?php
2		namespace MrPrompt\Centercob\Received;
3
4		use DateTime;
5		use MrPrompt\ShipmentCommon\Base\Cart;
6		use MrPrompt\ShipmentCommon\Base\Customer;
7		use MrPrompt\ShipmentCommon\Util\Number;
8		use MrPrompt\Centercob\Received\Partial\Detail;
9		use MrPrompt\Centercob\Received\Partial\Footer;
10		use MrPrompt\Centercob\Received\Partial\Header;
11
12		/**
13		* Received file class
14		*
15		* @author Thiago Paes <[email protected]>
16		*/
17		class File
18		{
19		/**
20		* File name template
21		*
22		* @var string
23		*/
24		const TEMPLATE_GENERATED = 'RET{CLIENT}-{DD.MM.YYYY-HH.MM.SS}.TXT';
25
26		/**
27		* File name template
28		*
29		* @var string
30		*/
31		const TEMPLATE_PROCESSED = 'RET{CLIENT}-{DD.MM.YYYY-HH.MM.SS}.TXT';
32
33		/**
34		* @var Header
35		*/
36		private $header;
37
38		/**
39		* @var ArrayObject
40		*/
41		private $cart;
42
43		/**
44		* @var Footer
45		*/
46		private $footer;
47
48		/**
49		* @var array
50		*/
51		private $rows = [];
52
53		/**
54		* @var Customer
55		*/
56		private $customer;
57
58		/**
59		* @var DateTime
60		*/
61		private $now;
62
63		/**
64		* @param Customer $customer
65		* @param DateTime $date
66		* @param string $storageDir
67		*/
68	1	public function __construct(Customer $customer, DateTime $date, $storageDir = null)
69		{
70	1	$this->customer = $customer;
71	1	$this->now = $date;
72
73	1	$file = $storageDir . DIRECTORY_SEPARATOR . $this->createFilename();
74	1	$content = file_get_contents($file);
75
76	1	$this->rows = explode(PHP_EOL, $content);
77
78	1	$this->getHeader();
79	1	$this->getFooter();
80	1	$this->getCart();
81	1	}
82
83		/**
84		* Create the file name
85		*
86		* @return string
87		*/
88	1	private function createFilename($type = self::TEMPLATE_GENERATED)
89		{
90		$search = [
91	1	'{CLIENT}',
92		'{DD.MM.YYYY-HH.MM.SS}',
93		];
94
95		$replace = [
96	1	Number::zeroFill($this->customer->getCode(), 7, Number::FILL_LEFT),
97	1	$this->now->format('d.m.Y-H.i.s'),
98		];
99
100	1	return str_replace($search, $replace, $type);
101		}
102
103		/**
104		* @return Header
105		*/
106	1	public function getHeader()
107		{
108	1	$headerLine = array_shift($this->rows);
109	1	$this->header = new Header($headerLine);
110
111	1	return $this->header;
112		}
113
114		/**
115		* @return Footer
116		*/
117	1	public function getFooter()
118		{
119	1	$footerLine = array_pop($this->rows);
120
121	1	if (null === $footerLine \|\| "" === $footerLine) {
122	1	$footerLine = array_pop($this->rows);
123		}
124
125	1	$this->footer = new Footer($footerLine);
126
127	1	return $this->footer;
128		}
129
130		/**
131		* @return \ArrayObject
132		*/
133	1	public function getCart()
134		{
135	1	$this->cart = new Cart();
		0 ignored issues – show Documentation Bug introduced 2018-12-02 01:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new \MrPrompt\ShipmentCommon\Base\Cart()` of type `object<MrPrompt\ShipmentCommon\Base\Cart>` is incompatible with the declared type `object<MrPrompt\Centercob\Received\ArrayObject>` of property `$cart`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
136
137		/* @var $detail \Centercob\Gateway\Received\Partial\Detail */
138	1	foreach ($this->rows as $row) {
139	1	$detail = new Detail($row);
140
141	1	$this->cart->addItem($detail);
142		}
143
144	1	return $this->cart;
145		}
146
147		/**
148		* @return mixed
149		*/
150	1	public function getAll()
151		{
152		return [
153	1	$this->header,
154	1	$this->cart,
155	1	$this->footer
156		];
157		}
158		}
159

mrprompt / Centercob

Issues (21)

Security Analysis no request data

src/Received/File.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like