AnyOfTrait::anyOf() - Code Metrics - Inspection of "Fixed inconsistency in boolean behavior" - mrferos/comfort - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ce18a8...486e29 )

by Andres

created 2016-06-29 00:08 UTC

AnyOfTrait::anyOf() A

↳ Parent: AnyOfTrait

Complexity

Conditions	2
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	2
eloc	5
c	1
b	0
f	1
nc	1
nop	1
dl	0
loc	10
rs	9.4285

<?php
namespace Comfort\Validator\Helper;

trait AnyOfTrait {
    /**
     * Validate given value matches any of the provided strings
     *
     * @param array $vals
     * @return $this
     */
    public function anyOf(array $vals)
    {
        $this->add(function($value, $nameKey) use ($vals) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            if (!in_array($value, $vals)) {
                return $this->createError('anyof', $value, $nameKey);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        });

        return $this;
    }
}

1			<?php
2			namespace Comfort\Validator\Helper;
3
4			trait AnyOfTrait {
5			/**
6			* Validate given value matches any of the provided strings
7			*
8			* @param array $vals
9			* @return $this
10			*/
11			public function anyOf(array $vals)
12			{
13			$this->add(function($value, $nameKey) use ($vals) {
			0 ignored issues – show Bug introduced 2016-06-29 00:12 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			if (!in_array($value, $vals)) {
15			return $this->createError('anyof', $value, $nameKey);
			0 ignored issues – show Bug introduced 2016-06-29 00:12 UTC by Report Bug Copy Issue Report It seems like `createError()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16			}
17			});
18
19			return $this;
20			}
21			}

mrferos / comfort

Push — master ( ce18a8...486e29 )

AnyOfTrait::anyOf() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like