ExecutorTrait - Code Metrics - Inspection of "Returning values on items" - mrferos/comfort - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 872ac5...951b37 )

by Andres

created 2016-08-19 00:54 UTC

ExecutorTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	43
rs	10
wmc	9
lcom	1
cbo	1

1 Method

Rating	Name	Duplication	Size	Complexity
D	validate()	0	33	9

<?php
namespace Comfort\Validator\Helper;

use Comfort\Exception\ValidationException;
use Comfort\ValidationError;

trait ExecutorTrait
{
    /**
     * Execute the validation stack and fail on first
     *
     * @param $value
     * @param null $key
     * @return bool|ValidationError|null
     */
    protected function validate($value, $key = null)
    {
        if (is_null($value) && $this->optional) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            if (is_null($this->defaultValue)) {
                return null;
            } else {
                $value = $this->defaultValue;
class MyClass { }

$x = new MyClass();
$x->foo = true;
            }
        }

        try {
            reset($this->validationStack);
class MyClass { }

$x = new MyClass();
$x->foo = true;

            do {
                /** @var callable $validator */
                $validator = current($this->validationStack);
                $retVal = $validator($value, $key);
                $value = $retVal === null ? $value : $retVal;
            } while (next($this->validationStack));

            if ($this->toBool) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                return true;
            }

            return $value;
        } catch (ValidationException $validationException) {
            if ($this->toBool) {
                return false;
            }

            return ValidationError::fromException($validationException);
        }
    }
}

1			<?php
2			namespace Comfort\Validator\Helper;
3
4			use Comfort\Exception\ValidationException;
5			use Comfort\ValidationError;
6
7			trait ExecutorTrait
8			{
9			/**
10			* Execute the validation stack and fail on first
11			*
12			* @param $value
13			* @param null $key
14			* @return bool\|ValidationError\|null
15			*/
16			protected function validate($value, $key = null)
17			{
18			if (is_null($value) && $this->optional) {
			0 ignored issues – show Bug introduced 2016-08-19 00:57 UTC by Report Bug Copy Issue Report The property `optional` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			if (is_null($this->defaultValue)) {
20			return null;
21			} else {
22			$value = $this->defaultValue;
			0 ignored issues – show Bug introduced 2016-08-19 00:57 UTC by Report Bug Copy Issue Report The property `defaultValue` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			}
24			}
25
26			try {
27			reset($this->validationStack);
			0 ignored issues – show Bug introduced 2016-08-19 00:57 UTC by Report Bug Copy Issue Report The property `validationStack` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28
29			do {
30			/** @var callable $validator */
31			$validator = current($this->validationStack);
32			$retVal = $validator($value, $key);
33			$value = $retVal === null ? $value : $retVal;
34			} while (next($this->validationStack));
35
36			if ($this->toBool) {
			0 ignored issues – show Bug introduced 2016-08-19 00:57 UTC by Report Bug Copy Issue Report The property `toBool` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
37			return true;
38			}
39
40			return $value;
41			} catch (ValidationException $validationException) {
42			if ($this->toBool) {
43			return false;
44			}
45
46			return ValidationError::fromException($validationException);
47			}
48			}
49			}

mrferos / comfort

Push — master ( 872ac5...951b37 )

ExecutorTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like