AnyOfTrait - Code Metrics - mrferos/comfort - Measure and Improve Code Quality continuously with Scrutinizer

AnyOfTrait A
last analyzed 2016-10-16 02:22 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	19
Duplicated Lines	52.63 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	10
loc	19
rs	10
c	0
b	0
f	0
wmc	2
lcom	0
cbo	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	anyOf()	10	10	2

How to fix Duplicated Code

<?php
namespace Comfort\Validator\Helper;

trait AnyOfTrait
{
    /**
     * Validate given value matches any of the provided strings
     *
     * @param array $vals
     * @return $this
     */
    public function anyOf(array $vals)

    {
        $this->add(function ($value, $nameKey) use ($vals) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            if (!in_array($value, $vals)) {
                return $this->createError('anyof', $value, $nameKey);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        });

        return $this;
    }
}


1		<?php
2		namespace Comfort\Validator\Helper;
3
4		trait AnyOfTrait
5		{
6		/**
7		* Validate given value matches any of the provided strings
8		*
9		* @param array $vals
10		* @return $this
11		*/
12	View Code Duplication	public function anyOf(array $vals)
		0 ignored issues – show Duplication introduced 2016-06-29 00:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		$this->add(function ($value, $nameKey) use ($vals) {
		0 ignored issues – show Bug introduced 2016-06-29 00:12 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
15		if (!in_array($value, $vals)) {
16		return $this->createError('anyof', $value, $nameKey);
		0 ignored issues – show Bug introduced 2016-06-29 00:12 UTC by Report Bug Copy Issue Report It seems like `createError()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17		}
18		});
19
20		return $this;
21		}
22		}
23

mrferos / comfort

AnyOfTrait A last analyzed 2016-10-16 02:22 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

AnyOfTrait A
last analyzed 2016-10-16 02:22 UTC