ChatMessageTest - Code Metrics - mremi/Flowdock - Measure and Improve Code Quality continuously with Scrutinizer

ChatMessageTest A
last analyzed 2019-10-17 16:36 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	4
dl	0
loc	57
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	setUp()	4	1
A	testGetData()	19	1
A	testToArray()	20	1

<?php

/*
 * This file is part of the Mremi\Flowdock library.
 *
 * (c) Rémi Marseille <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Mremi\Flowdock\Tests\Api\Push;

use GuzzleHttp\Psr7\Response;

use Mremi\Flowdock\Api\Push\ChatMessage;

/**
 * Tests the ChatMessage class
 *
 * @author Rémi Marseille <[email protected]>
 */
class ChatMessageTest extends BaseMessageTest
{
    /**
     * {@inheritdoc}
     */
    protected function setUp()
    {
        $this->message = new ChatMessage;
    }

    /**
     * {@inheritdoc}
     */
    public function testGetData()
    {
        $this->message
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->setContent('Hello world!')
            ->setExternalUserName('mremi')
            ->addTag('tag1')
            ->addTag('tag2')
            ->setMessageId(1)
            ->setResponse(new Response(200));

        $expected = array(
            'content'            => $this->message->getContent(),
            'external_user_name' => $this->message->getExternalUserName(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'tags'               => $this->message->getTags(),
            'message_id'         => $this->message->getMessageId(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );

        $this->assertEquals($expected, $this->message->getData());
    }

    /**
     * {@inheritdoc}
     */
    public function testToArray()
    {
        $this->message
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->setContent('Hello world!')
            ->setExternalUserName('mremi')
            ->addTag('tag1')
            ->addTag('tag2')
            ->setMessageId(1)
            ->setResponse(new Response(200));

        $expected = array(
            'content'            => $this->message->getContent(),
            'external_user_name' => $this->message->getExternalUserName(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'tags'               => $this->message->getTags(),
            'message_id'         => $this->message->getMessageId(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'response'           => $this->message->getResponse(),
        );

        $this->assertEquals($expected, $this->message->toArray());
    }
}


1			<?php
2
3			/*
4			* This file is part of the Mremi\Flowdock library.
5			*
6			* (c) Rémi Marseille <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Mremi\Flowdock\Tests\Api\Push;
13
14			use GuzzleHttp\Psr7\Response;
15
16			use Mremi\Flowdock\Api\Push\ChatMessage;
17
18			/**
19			* Tests the ChatMessage class
20			*
21			* @author Rémi Marseille <[email protected]>
22			*/
23			class ChatMessageTest extends BaseMessageTest
24			{
25			/**
26			* {@inheritdoc}
27			*/
28			protected function setUp()
29			{
30			$this->message = new ChatMessage;
31			}
32
33			/**
34			* {@inheritdoc}
35			*/
36			public function testGetData()
37			{
38			$this->message
			0 ignored issues – show Bug introduced 2016-02-18 16:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Mremi\Flowdock\Api\Push\BaseMessageInterface` as the method `setExternalUserName()` does only exist in the following implementations of said interface: `Mremi\Flowdock\Api\Push\ChatMessage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
39			->setContent('Hello world!')
40			->setExternalUserName('mremi')
41			->addTag('tag1')
42			->addTag('tag2')
43			->setMessageId(1)
44			->setResponse(new Response(200));
45
46			$expected = array(
47			'content' => $this->message->getContent(),
48			'external_user_name' => $this->message->getExternalUserName(),
			0 ignored issues – show Bug introduced 2016-02-18 16:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Mremi\Flowdock\Api\Push\BaseMessageInterface` as the method `getExternalUserName()` does only exist in the following implementations of said interface: `Mremi\Flowdock\Api\Push\ChatMessage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
49			'tags' => $this->message->getTags(),
50			'message_id' => $this->message->getMessageId(),
			0 ignored issues – show Bug introduced 2016-02-18 16:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Mremi\Flowdock\Api\Push\BaseMessageInterface` as the method `getMessageId()` does only exist in the following implementations of said interface: `Mremi\Flowdock\Api\Push\ChatMessage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
51			);
52
53			$this->assertEquals($expected, $this->message->getData());
54			}
55
56			/**
57			* {@inheritdoc}
58			*/
59			public function testToArray()
60			{
61			$this->message
			0 ignored issues – show Bug introduced 2016-02-18 16:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Mremi\Flowdock\Api\Push\BaseMessageInterface` as the method `setExternalUserName()` does only exist in the following implementations of said interface: `Mremi\Flowdock\Api\Push\ChatMessage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
62			->setContent('Hello world!')
63			->setExternalUserName('mremi')
64			->addTag('tag1')
65			->addTag('tag2')
66			->setMessageId(1)
67			->setResponse(new Response(200));
68
69			$expected = array(
70			'content' => $this->message->getContent(),
71			'external_user_name' => $this->message->getExternalUserName(),
			0 ignored issues – show Bug introduced 2016-02-18 16:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Mremi\Flowdock\Api\Push\BaseMessageInterface` as the method `getExternalUserName()` does only exist in the following implementations of said interface: `Mremi\Flowdock\Api\Push\ChatMessage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
72			'tags' => $this->message->getTags(),
73			'message_id' => $this->message->getMessageId(),
			0 ignored issues – show Bug introduced 2016-02-18 16:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Mremi\Flowdock\Api\Push\BaseMessageInterface` as the method `getMessageId()` does only exist in the following implementations of said interface: `Mremi\Flowdock\Api\Push\ChatMessage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
74			'response' => $this->message->getResponse(),
75			);
76
77			$this->assertEquals($expected, $this->message->toArray());
78			}
79			}
80

mremi / Flowdock

ChatMessageTest A last analyzed 2019-10-17 16:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ChatMessageTest A
last analyzed 2019-10-17 16:36 UTC