Tests\Mrcnpdlk\Api\Unoconv\ApiTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testConstruct_1()	0	5	1
A	testConstruct_invalid_1()	0	12	1
A	testConstruct_invalid_2()	0	9	1

<?php
/**
 * Created by Marcin.
 * Date: 03.03.2019
 * Time: 17:07
 */

namespace Tests\Mrcnpdlk\Api\Unoconv;

use Mrcnpdlk\Api\Unoconv\Api;
use Mrcnpdlk\Api\Unoconv\Config;
use Mrcnpdlk\Api\Unoconv\Enum\FormatType;
use Mrcnpdlk\Api\Unoconv\Exception\InvalidFileArgumentException;
use Mrcnpdlk\Api\Unoconv\Exception\UnoconvException;
use PHPUnit\Framework\TestCase;

class ApiTest extends TestCase
{
    /**
     * @throws \Mrcnpdlk\Api\Unoconv\Exception
     */
    public function testConstruct_1(): void
    {
        $oApi = new Api();

$oApi is not used, you could remove the assignment.

        $this->assertTrue(true);
    }

    /**
     * @throws \Mrcnpdlk\Api\Unoconv\Exception
     * @throws \Mrcnpdlk\Api\Unoconv\Exception\ConfigurationException
     * @throws \Mrcnpdlk\Api\Unoconv\Exception\InvalidFileArgumentException
     * @throws \Mrcnpdlk\Api\Unoconv\Exception\UnoconvException
     */
    public function testConstruct_invalid_1(): void
    {
        $this->expectException(UnoconvException::class);
        $config   = new Config([

$config is not used, you could remove the assignment.

            'binary' => '/some/binary/file',
        ]);
        $oApi     = new Api();
        $testFile = sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'test.docx';
        file_put_contents($testFile, null);
        $oApi->transcode($testFile, FormatType::PDF());
        @unlink($testFile);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

    }

    /**
     * @throws \Mrcnpdlk\Api\Unoconv\Exception
     * @throws \Mrcnpdlk\Api\Unoconv\Exception\ConfigurationException
     * @throws \Mrcnpdlk\Api\Unoconv\Exception\InvalidFileArgumentException
     * @throws \Mrcnpdlk\Api\Unoconv\Exception\UnoconvException
     */
    public function testConstruct_invalid_2(): void
    {
        $this->expectException(InvalidFileArgumentException::class);
        $config   = new Config([

$config is not used, you could remove the assignment.

            'binary' => '/some/binary/file',
        ]);
        $oApi     = new Api();
        $oApi->transcode('foo_bar.test', FormatType::PDF());
    }
}