mrcnpdlk\Teryt\Model\Commune

Complexity

Total Complexity

9

Size/Duplication

Total Lines	99
Duplicated Lines	12.12 %

Test Coverage

Coverage

59.46%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
C	find()	12	50	9

<?php
/**
 * TERYT-API
 *
 * Copyright (c) 2017 pudelek.org.pl
 *
 * @license MIT License (MIT)
 *
 * For the full copyright and license information, please view source file
 * that is bundled with this package in the file LICENSE
 *
 * @author  Marcin Pudełek <marcin@pudelek.org.pl>
 *
 */

/**
 * Created by Marcin Pudełek <marcin@pudelek.org.pl>
 * Date: 07.09.2017
 */

namespace mrcnpdlk\Teryt\Model;


use mrcnpdlk\Teryt\Exception\InvalidArgument;
use mrcnpdlk\Teryt\Exception\NotFound;
use mrcnpdlk\Teryt\NativeApi;

/**
 * Class Commune
 *
 * @package mrcnpdlk\Teryt\Model
 */
class Commune extends EntityAbstract
{
    /**
     * 6 (lub 7) znakowy symbol powiatu lub tercId
     * sklada sie z 2 cyfr województwa , 2 powiatu, 2 gminy i 1 rodzaj gminy (opcjonalny)
     *
     * @var string
     */
    public $id;
    /**
     * Pełen identyfikator gminy
     *
     * @var string
     */
    public $tercId;
    /**
     * Nazwa powiatu
     *
     * @var static
     */
    public $name;
    /**
     * ID typu gminy
     *
     * @var string
     */
    public $typeId;
    /**
     * Nazwa typu gminy
     *
     * @var string
     */
    public $typeName;
    /**
     * Obiekt z danymi o powiecie w którym znajduje się gmina
     *
     * @var \mrcnpdlk\Teryt\Model\District
     */
    public $district;

    /**
     * Commune constructor.
     *
     * @param string $id 6 lub 7-znakowy symbol gminy
     *
     * @return $this
     * @throws InvalidArgument
     * @throws NotFound
     */
    public function find(string $id)
    {
        switch (strlen($id)) {
            case 6;

This code seems to be duplicated across your project.

                $provinceId = substr($id, 0, 2);
                $districtId = substr($id, 2, 2);
                $communeId  = substr($id, 2, 2);
                $tercId     = null;
                break;
            case 7:

This code seems to be duplicated across your project.

                $provinceId = substr($id, 0, 2);
                $districtId = substr($id, 2, 2);
                $communeId  = substr($id, 2, 2);
                $tercId     = $id;
                break;
            default:
                throw new InvalidArgument(sprintf('CommuneSymbol malformed, it has %s chars', strlen($id)));
                break;
        }
        if (!$tercId) {

The expression $tercId of type null|string is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            foreach (NativeApi::getInstance()->PobierzListeGmin($provinceId, $districtId) as $i) {
                if ($i->districtId === $districtId) {
                    $this->id       = $id;
                    $this->name     = $i->name;

It seems like $i->name of type string is incompatible with the declared type mrcnpdlk\Teryt\Model\Commune of property $name.

                    $this->typeName = $i->typeName;
                    $this->typeId   = $i->communeTypeId;
                    $tercId         = sprintf('%s%s%s%s', $provinceId, $districtId, $communeId, $i->communeTypeId);
                }
            }

        } else {
            $res = NativeApi::getInstance()->WyszukajJednostkeWRejestrze(null, NativeApi::CATEGORY_GMI_ALL, [], [$tercId]);
            if (!empty($res) && count($res) === 1) {
                $oCommune       = $res[0];
                $this->id       = $id;
                $this->name     = $oCommune->communeName;
                $this->typeName = $oCommune->communeTypeName;
                $this->typeId   = $oCommune->communeTypeId;
            }
        }
        if (!$this->id) {
            throw new NotFound(sprintf('Commune [id:%s] not exists', $id));
        }


        $this->id       = sprintf('%s%s%s', $provinceId, $districtId, $communeId);
        $this->tercId   = $tercId;
        $this->district = (new District())->find(sprintf('%s%s', $provinceId, $districtId));

        return $this;
    }
}