Complex classes like CURLPool often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CURLPool, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 9 | class CURLPool |
||
| 10 | { |
||
| 11 | /** |
||
| 12 | * Options. |
||
| 13 | * @var CoOption |
||
| 14 | */ |
||
| 15 | private $options; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * cURL multi handle. |
||
| 19 | * @var resource |
||
| 20 | */ |
||
| 21 | private $mh; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * cURL handles those have not been dispatched. |
||
| 25 | * @var array |
||
| 26 | */ |
||
| 27 | private $queue = []; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * cURL handles those have been already dispatched. |
||
| 31 | * @var array |
||
| 32 | */ |
||
| 33 | private $added = []; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * The number of whole running TCP connections. |
||
| 37 | * @var array |
||
| 38 | */ |
||
| 39 | private $connectionCount = 0; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Counts per destination. |
||
| 43 | * key => identifier |
||
| 44 | * value => count |
||
| 45 | * @var array |
||
| 46 | */ |
||
| 47 | private $destinations = []; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Delays to be ended at. |
||
| 51 | * @var array |
||
| 52 | */ |
||
| 53 | private $untils = []; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * React Deferreds. |
||
| 57 | * @var Deferred |
||
| 58 | */ |
||
| 59 | private $deferreds = []; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Used for halting loop. |
||
| 63 | * @var \RuntimeException |
||
| 64 | */ |
||
| 65 | private $haltException; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * Constructor. |
||
| 69 | * Initialize cURL multi handle. |
||
| 70 | * @param CoOption $options |
||
| 71 | */ |
||
| 72 | 26 | public function __construct(CoOption $options) |
|
| 79 | |||
| 80 | /** |
||
| 81 | * Call curl_multi_add_handle() or push into queue. |
||
| 82 | * @param resource $ch |
||
| 83 | * @param Deferred $deferred |
||
| 84 | */ |
||
| 85 | 13 | public function addOrEnqueue($ch, Deferred $deferred = null) |
|
| 95 | |||
| 96 | /** |
||
| 97 | * Call curl_multi_add_handle(). |
||
| 98 | * @param resource $ch |
||
| 99 | * @param Deferred $deferred |
||
| 100 | */ |
||
| 101 | 13 | private function addCurl($ch, Deferred $deferred = null) |
|
| 115 | |||
| 116 | /** |
||
| 117 | * Add destination info. |
||
| 118 | * @param resource $ch |
||
| 119 | */ |
||
| 120 | 13 | private function addDestination($ch) |
|
| 134 | |||
| 135 | /** |
||
| 136 | * Check if internal cURL pool is filled. |
||
| 137 | * @param string $id |
||
| 138 | * @return bool |
||
| 139 | */ |
||
| 140 | 13 | private function isPoolFilled($id) |
|
| 148 | |||
| 149 | /** |
||
| 150 | * Remove destination info. |
||
| 151 | * @param resource $ch |
||
| 152 | */ |
||
| 153 | 10 | private function removeDestination($ch) |
|
| 167 | |||
| 168 | /** |
||
| 169 | * Push into queue. |
||
| 170 | * @param resource $ch |
||
| 171 | * @param Deferred $deferred |
||
| 172 | */ |
||
| 173 | 3 | private function enqueueCurl($ch, Deferred $deferred = null) |
|
| 178 | |||
| 179 | /** |
||
| 180 | * Add delay. |
||
| 181 | * @param int $time |
||
| 182 | * @param Deferred $deferred |
||
| 183 | */ |
||
| 184 | 6 | public function addDelay($time, Deferred $deferred) |
|
| 199 | |||
| 200 | /** |
||
| 201 | * Run curl_multi_exec() loop. |
||
| 202 | */ |
||
| 203 | 18 | public function wait() |
|
| 220 | |||
| 221 | /** |
||
| 222 | * Used for halting loop. |
||
| 223 | */ |
||
| 224 | 4 | public function reserveHaltException($e) |
|
| 228 | |||
| 229 | /** |
||
| 230 | * Sleep at least required. |
||
| 231 | */ |
||
| 232 | 9 | private function sleepUntilNearestTime() |
|
| 250 | |||
| 251 | /** |
||
| 252 | * Consume completed cURL handles and delays. |
||
| 253 | */ |
||
| 254 | 18 | private function consumeCurlsAndUntils() |
|
| 260 | |||
| 261 | /** |
||
| 262 | * Poll completed cURL entries and consume cURL queue. |
||
| 263 | * @return array |
||
| 264 | */ |
||
| 265 | 18 | private function consumeCurls() |
|
| 280 | |||
| 281 | /** |
||
| 282 | * Consume delay queue. |
||
| 283 | */ |
||
| 284 | 18 | private function consumeUntils() |
|
| 296 | |||
| 297 | /** |
||
| 298 | * Resolve polled cURLs. |
||
| 299 | * @param array $entries Polled cURL entries. |
||
| 300 | */ |
||
| 301 | 18 | private function resolveCurls($entries) |
|
| 314 | |||
| 315 | /** |
||
| 316 | * Push into queue. |
||
| 317 | * @param resource $ch |
||
| 318 | * @return string |
||
| 319 | */ |
||
| 320 | 13 | private function getIdentifier($ch) |
|
| 324 | } |
||
| 325 |