Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class ManualScheduler extends AbstractScheduler |
||
9 | { |
||
10 | /** |
||
11 | * cURL handles those have not been dispatched. |
||
12 | * @var array |
||
13 | */ |
||
14 | private $queue = []; |
||
15 | |||
16 | /** |
||
17 | * Constructor. |
||
18 | * Initialize cURL multi handle. |
||
19 | * @param CoOption $options |
||
20 | * @param resource $mh curl_multi |
||
21 | */ |
||
22 | 37 | public function __construct(CoOption $options, $mh) |
|
27 | |||
28 | /** |
||
29 | * Call curl_multi_add_handle() or push into queue. |
||
30 | * @param resource $ch |
||
31 | * @return PromiseInterface |
||
32 | */ |
||
33 | 14 | public function add($ch) |
|
42 | |||
43 | /** |
||
44 | * Are there no cURL handles? |
||
45 | * @return bool |
||
46 | */ |
||
47 | 31 | public function isEmpty() |
|
51 | |||
52 | /** |
||
53 | * Call curl_multi_add_handle(). |
||
54 | * @param resource $ch |
||
55 | * @param Deferred $deferred |
||
56 | */ |
||
57 | 14 | private function addImmediate($ch, Deferred $deferred = null) |
|
70 | |||
71 | /** |
||
72 | * Push into queue. |
||
73 | * @param resource $ch |
||
74 | * @param Deferred $deferred |
||
75 | */ |
||
76 | 1 | private function addReserved($ch, Deferred $deferred = null) |
|
81 | |||
82 | /** |
||
83 | * Add cURL handles from waiting queue. |
||
84 | */ |
||
85 | 14 | protected function interruptConsume() |
|
91 | } |
||
92 |