Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class AutoScheduler extends AbstractScheduler |
||
9 | { |
||
10 | /** |
||
11 | * Constructor. |
||
12 | * Initialize cURL multi handle. |
||
13 | * @param CoOption $options |
||
14 | * @param resource $mh curl_multi |
||
15 | */ |
||
16 | 2 | public function __construct(CoOption $options, $mh) |
|
22 | |||
23 | /** |
||
24 | * Call curl_multi_add_handle(). |
||
25 | * @param resource $ch |
||
26 | * @return PromiseInterface |
||
27 | */ |
||
28 | 2 | public function add($ch) |
|
43 | |||
44 | /** |
||
45 | * Are there no cURL handles? |
||
46 | * @return bool |
||
47 | */ |
||
48 | 2 | public function isEmpty() |
|
52 | |||
53 | /** |
||
54 | * Do nothing. |
||
55 | */ |
||
56 | protected function interruptConsume() {} |
||
57 | } |
||
58 |