mprins /
dokuwiki-yalist-plugin
| Conditions | 60 |
| Paths | 79 |
| Total Lines | 259 |
| Code Lines | 217 |
| Lines | 50 |
| Ratio | 19.31 % |
| Changes | 1 | ||
| Bugs | 1 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 371 | function render_odt_item(Doku_Renderer $renderer, $item) { |
||
| 372 | switch ($item) { |
||
| 373 | case 'ol_open': |
||
| 374 | $renderer->listo_open(); |
||
| 375 | break; |
||
| 376 | case 'ul_open': |
||
| 377 | $renderer->listu_open(); |
||
| 378 | break; |
||
| 379 | case 'dl_open': |
||
| 380 | if ($this->getConf('def_list_odt_export') != 'table') { |
||
| 381 | $renderer->listu_open(); |
||
| 382 | } else { |
||
| 383 | $renderer->table_open(2); |
||
| 384 | } |
||
| 385 | self::$odt_table_stack [self::$odt_table_stack_index] = array(); |
||
| 386 | self::$odt_table_stack [self::$odt_table_stack_index]['itemOpen'] = false; |
||
| 387 | self::$odt_table_stack [self::$odt_table_stack_index]['dtState'] = 0; |
||
| 388 | self::$odt_table_stack [self::$odt_table_stack_index]['ddState'] = 0; |
||
| 389 | self::$odt_table_stack_index++; |
||
| 390 | break; |
||
| 391 | case 'ol_close': |
||
| 392 | case 'ul_close': |
||
| 393 | $renderer->list_close(); |
||
| 394 | break; |
||
| 395 | case 'dl_close': |
||
| 396 | $config = $this->getConf('def_list_odt_export'); |
||
| 397 | if ($config != 'table') { |
||
| 398 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['ddState'] != 2) { |
||
| 399 | if ($config == 'listheader' && method_exists ($renderer, 'listheader_close')) { |
||
| 400 | $renderer->listheader_close(); |
||
| 401 | } else { |
||
| 402 | $renderer->listitem_close(); |
||
| 403 | } |
||
| 404 | } |
||
| 405 | self::$odt_table_stack [self::$odt_table_stack_index-1]['ddState'] = 0; |
||
| 406 | $renderer->list_close(); |
||
| 407 | } else { |
||
| 408 | View Code Duplication | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['ddState'] == 0) { |
|
| 409 | $properties = array(); |
||
| 410 | $properties ['border'] = 'none'; |
||
| 411 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 412 | $renderer->tablecell_close(); |
||
| 413 | } |
||
| 414 | self::$odt_table_stack [self::$odt_table_stack_index-1]['ddState'] = 0; |
||
| 415 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === true) { |
||
| 416 | $renderer->tablerow_close(1); |
||
| 417 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = false; |
||
| 418 | } |
||
| 419 | $renderer->table_close(); |
||
| 420 | } |
||
| 421 | if (self::$odt_table_stack_index > 0) { |
||
| 422 | self::$odt_table_stack_index--; |
||
| 423 | unset(self::$odt_table_stack [self::$odt_table_stack_index]); |
||
| 424 | } |
||
| 425 | break; |
||
| 426 | |||
| 427 | case 'li_open': |
||
| 428 | $renderer->listitem_open(1); |
||
| 429 | break; |
||
| 430 | case 'li_content_open': |
||
| 431 | $renderer->listcontent_open(); |
||
| 432 | break; |
||
| 433 | case 'li_content_close': |
||
| 434 | $renderer->listcontent_close(); |
||
| 435 | break; |
||
| 436 | case 'li_close': |
||
| 437 | $renderer->listitem_close(); |
||
| 438 | break; |
||
| 439 | |||
| 440 | case 'dt_open': // unconditional: DT tags can't contain paragraphs. That would not be legal XHTML. |
||
| 441 | switch ($this->getConf('def_list_odt_export')) { |
||
| 442 | case 'listheader': |
||
| 443 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === true) { |
||
| 444 | if (method_exists ($renderer, 'listheader_close')) { |
||
| 445 | $renderer->listheader_close(); |
||
| 446 | } else { |
||
| 447 | $renderer->listitem_close(); |
||
| 448 | } |
||
| 449 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = false; |
||
| 450 | } |
||
| 451 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === false) { |
||
| 452 | if (method_exists ($renderer, 'listheader_open')) { |
||
| 453 | $renderer->listheader_open(1); |
||
| 454 | } else { |
||
| 455 | $renderer->listitem_open(1); |
||
| 456 | } |
||
| 457 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = true; |
||
| 458 | } |
||
| 459 | break; |
||
| 460 | case 'table': |
||
| 461 | View Code Duplication | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['ddState'] == 0) { |
|
| 462 | $properties = array(); |
||
| 463 | $properties ['border'] = 'none'; |
||
| 464 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 465 | $renderer->tablecell_close(); |
||
| 466 | } |
||
| 467 | |||
| 468 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === true) { |
||
| 469 | $renderer->tablerow_close(); |
||
| 470 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = false; |
||
| 471 | } |
||
| 472 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === false) { |
||
| 473 | $renderer->tablerow_open(1); |
||
| 474 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = true; |
||
| 475 | } |
||
| 476 | $properties = array(); |
||
| 477 | $properties ['border'] = 'none'; |
||
| 478 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 479 | break; |
||
| 480 | default: |
||
| 481 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === true) { |
||
| 482 | $renderer->listitem_close(); |
||
| 483 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = false; |
||
| 484 | } |
||
| 485 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === false) { |
||
| 486 | $renderer->listitem_open(1); |
||
| 487 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = true; |
||
| 488 | } |
||
| 489 | break; |
||
| 490 | } |
||
| 491 | self::$odt_table_stack [self::$odt_table_stack_index-1]['dtState'] = 1; |
||
| 492 | self::$odt_table_stack [self::$odt_table_stack_index-1]['ddState'] = 0; |
||
| 493 | break; |
||
| 494 | case 'dd_open': |
||
| 495 | switch ($this->getConf('def_list_odt_export')) { |
||
| 496 | View Code Duplication | case 'listheader': |
|
| 497 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === false) { |
||
| 498 | if (method_exists ($renderer, 'listheader_open')) { |
||
| 499 | $renderer->listheader_open(1); |
||
| 500 | } else { |
||
| 501 | $renderer->listitem_open(1); |
||
| 502 | } |
||
| 503 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = true; |
||
| 504 | } |
||
| 505 | break; |
||
| 506 | case 'table': |
||
| 507 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === false) { |
||
| 508 | $renderer->tablerow_open(1); |
||
| 509 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = true; |
||
| 510 | } |
||
| 511 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['dtState'] == 1) { |
||
| 512 | $renderer->tablecell_close(); |
||
| 513 | } |
||
| 514 | View Code Duplication | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['dtState'] == 0) { |
|
| 515 | $properties = array(); |
||
| 516 | $properties ['border'] = 'none'; |
||
| 517 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 518 | $renderer->tablecell_close(); |
||
| 519 | } |
||
| 520 | |||
| 521 | $properties = array(); |
||
| 522 | $properties ['border'] = 'none'; |
||
| 523 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 524 | break; |
||
| 525 | View Code Duplication | default: |
|
| 526 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === false) { |
||
| 527 | $renderer->listitem_open(1); |
||
| 528 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = true; |
||
| 529 | } |
||
| 530 | break; |
||
| 531 | } |
||
| 532 | self::$odt_table_stack [self::$odt_table_stack_index-1]['dtState'] = 0; |
||
| 533 | self::$odt_table_stack [self::$odt_table_stack_index-1]['ddState'] = 1; |
||
| 534 | break; |
||
| 535 | case 'dt_content_open': |
||
| 536 | switch ($this->getConf('def_list_odt_export')) { |
||
| 537 | case 'table': |
||
| 538 | $renderer->p_open(); |
||
| 539 | break; |
||
| 540 | default: |
||
| 541 | $renderer->listcontent_open(); |
||
| 542 | break; |
||
| 543 | } |
||
| 544 | $this->renderODTOpenSpan($renderer); |
||
| 545 | break; |
||
| 546 | case 'dd_content_open': |
||
| 547 | switch ($this->getConf('def_list_odt_export')) { |
||
| 548 | case 'table': |
||
| 549 | $renderer->p_open(); |
||
| 550 | break; |
||
| 551 | default: |
||
| 552 | $renderer->listcontent_open(); |
||
| 553 | break; |
||
| 554 | } |
||
| 555 | break; |
||
| 556 | case 'dt_content_close': |
||
| 557 | $this->renderODTCloseSpan($renderer); |
||
| 558 | switch ($this->getConf('def_list_odt_export')) { |
||
| 559 | case 'table': |
||
| 560 | $renderer->p_close(); |
||
| 561 | break; |
||
| 562 | default: |
||
| 563 | $renderer->listcontent_close(); |
||
| 564 | break; |
||
| 565 | } |
||
| 566 | break; |
||
| 567 | case 'dd_content_close': |
||
| 568 | switch ($this->getConf('def_list_odt_export')) { |
||
| 569 | case 'table': |
||
| 570 | $renderer->p_close(); |
||
| 571 | break; |
||
| 572 | default: |
||
| 573 | $renderer->listcontent_close(); |
||
| 574 | break; |
||
| 575 | } |
||
| 576 | break; |
||
| 577 | case 'dt_close': |
||
| 578 | switch ($this->getConf('def_list_odt_export')) { |
||
| 579 | case 'listheader': |
||
| 580 | $renderer->linebreak(); |
||
| 581 | break; |
||
| 582 | case 'table': |
||
| 583 | $renderer->tablecell_close(); |
||
| 584 | self::$odt_table_stack [self::$odt_table_stack_index-1]['dtState'] = 2; |
||
| 585 | break; |
||
| 586 | default: |
||
| 587 | $renderer->linebreak(); |
||
| 588 | break; |
||
| 589 | } |
||
| 590 | break; |
||
| 591 | |||
| 592 | case 'dd_close': |
||
| 593 | switch ($this->getConf('def_list_odt_export')) { |
||
| 594 | View Code Duplication | case 'listheader': |
|
| 595 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === true) { |
||
| 596 | if (method_exists ($renderer, 'listheader_close')) { |
||
| 597 | $renderer->listheader_close(); |
||
| 598 | } else { |
||
| 599 | $renderer->listitem_close(); |
||
| 600 | } |
||
| 601 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = false; |
||
| 602 | } |
||
| 603 | break; |
||
| 604 | case 'table': |
||
| 605 | $renderer->tablecell_close(); |
||
| 606 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === true) { |
||
| 607 | $renderer->tablerow_close(1); |
||
| 608 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = false; |
||
| 609 | } |
||
| 610 | break; |
||
| 611 | View Code Duplication | default: |
|
| 612 | if (self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] === true) { |
||
| 613 | $renderer->listitem_close(1); |
||
| 614 | self::$odt_table_stack [self::$odt_table_stack_index-1]['itemOpen'] = false; |
||
| 615 | } |
||
| 616 | break; |
||
| 617 | } |
||
| 618 | self::$odt_table_stack [self::$odt_table_stack_index-1]['dtState'] = 0; |
||
| 619 | self::$odt_table_stack [self::$odt_table_stack_index-1]['ddState'] = 2; |
||
| 620 | break; |
||
| 621 | |||
| 622 | case 'p_open': |
||
| 623 | $renderer->p_open(); |
||
| 624 | break; |
||
| 625 | case 'p_close': |
||
| 626 | $renderer->p_close(); |
||
| 627 | break; |
||
| 628 | } |
||
| 629 | } |
||
| 630 | |||
| 662 |
Loading history...
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.