mprins /
dokuwiki-yalist-plugin
| Conditions | 60 |
| Paths | 79 |
| Total Lines | 259 |
| Lines | 50 |
| Ratio | 19.31 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 399 | private function renderOdtItem(Doku_Renderer $renderer, $item) { |
||
| 400 | switch($item) { |
||
| 401 | case 'ol_open': |
||
| 402 | $renderer->listo_open(); |
||
| 403 | break; |
||
| 404 | case 'ul_open': |
||
| 405 | $renderer->listu_open(); |
||
| 406 | break; |
||
| 407 | case 'dl_open': |
||
| 408 | if($this->getConf('def_list_odt_export') != 'table') { |
||
| 409 | $renderer->listu_open(); |
||
| 410 | } else { |
||
| 411 | $renderer->table_open(2); |
||
| 412 | } |
||
| 413 | self::$odt_table_stack [self::$odt_table_stack_index] = array(); |
||
| 414 | self::$odt_table_stack [self::$odt_table_stack_index]['itemOpen'] = false; |
||
| 415 | self::$odt_table_stack [self::$odt_table_stack_index]['dtState'] = 0; |
||
| 416 | self::$odt_table_stack [self::$odt_table_stack_index]['ddState'] = 0; |
||
| 417 | self::$odt_table_stack_index++; |
||
| 418 | break; |
||
| 419 | case 'ol_close': |
||
| 420 | case 'ul_close': |
||
| 421 | $renderer->list_close(); |
||
| 422 | break; |
||
| 423 | case 'dl_close': |
||
| 424 | $config = $this->getConf('def_list_odt_export'); |
||
| 425 | if($config != 'table') { |
||
| 426 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['ddState'] != 2) { |
||
| 427 | if($config == 'listheader' && method_exists($renderer, 'listheader_close')) { |
||
| 428 | $renderer->listheader_close(); |
||
| 429 | } else { |
||
| 430 | $renderer->listitem_close(); |
||
| 431 | } |
||
| 432 | } |
||
| 433 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['ddState'] = 0; |
||
| 434 | $renderer->list_close(); |
||
| 435 | } else { |
||
| 436 | View Code Duplication | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['ddState'] == 0) { |
|
| 437 | $properties = array(); |
||
| 438 | $properties ['border'] = 'none'; |
||
| 439 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 440 | $renderer->tablecell_close(); |
||
| 441 | } |
||
| 442 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['ddState'] = 0; |
||
| 443 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === true) { |
||
| 444 | $renderer->tablerow_close(1); |
||
| 445 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = false; |
||
| 446 | } |
||
| 447 | $renderer->table_close(); |
||
| 448 | } |
||
| 449 | if(self::$odt_table_stack_index > 0) { |
||
| 450 | self::$odt_table_stack_index--; |
||
| 451 | unset(self::$odt_table_stack [self::$odt_table_stack_index]); |
||
| 452 | } |
||
| 453 | break; |
||
| 454 | |||
| 455 | case 'li_open': |
||
| 456 | $renderer->listitem_open(1); |
||
| 457 | break; |
||
| 458 | case 'li_content_open': |
||
| 459 | $renderer->listcontent_open(); |
||
| 460 | break; |
||
| 461 | case 'li_content_close': |
||
| 462 | $renderer->listcontent_close(); |
||
| 463 | break; |
||
| 464 | case 'li_close': |
||
| 465 | $renderer->listitem_close(); |
||
| 466 | break; |
||
| 467 | |||
| 468 | case 'dt_open': // unconditional: DT tags can't contain paragraphs. That would not be legal XHTML. |
||
| 469 | switch($this->getConf('def_list_odt_export')) { |
||
| 470 | case 'listheader': |
||
| 471 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === true) { |
||
| 472 | if(method_exists($renderer, 'listheader_close')) { |
||
| 473 | $renderer->listheader_close(); |
||
| 474 | } else { |
||
| 475 | $renderer->listitem_close(); |
||
| 476 | } |
||
| 477 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = false; |
||
| 478 | } |
||
| 479 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === false) { |
||
| 480 | if(method_exists($renderer, 'listheader_open')) { |
||
| 481 | $renderer->listheader_open(1); |
||
| 482 | } else { |
||
| 483 | $renderer->listitem_open(1); |
||
| 484 | } |
||
| 485 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = true; |
||
| 486 | } |
||
| 487 | break; |
||
| 488 | case 'table': |
||
| 489 | View Code Duplication | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['ddState'] == 0) { |
|
| 490 | $properties = array(); |
||
| 491 | $properties ['border'] = 'none'; |
||
| 492 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 493 | $renderer->tablecell_close(); |
||
| 494 | } |
||
| 495 | |||
| 496 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === true) { |
||
| 497 | $renderer->tablerow_close(); |
||
| 498 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = false; |
||
| 499 | } |
||
| 500 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === false) { |
||
| 501 | $renderer->tablerow_open(1); |
||
| 502 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = true; |
||
| 503 | } |
||
| 504 | $properties = array(); |
||
| 505 | $properties ['border'] = 'none'; |
||
| 506 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 507 | break; |
||
| 508 | default: |
||
| 509 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === true) { |
||
| 510 | $renderer->listitem_close(); |
||
| 511 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = false; |
||
| 512 | } |
||
| 513 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === false) { |
||
| 514 | $renderer->listitem_open(1); |
||
| 515 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = true; |
||
| 516 | } |
||
| 517 | break; |
||
| 518 | } |
||
| 519 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['dtState'] = 1; |
||
| 520 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['ddState'] = 0; |
||
| 521 | break; |
||
| 522 | case 'dd_open': |
||
| 523 | switch($this->getConf('def_list_odt_export')) { |
||
| 524 | View Code Duplication | case 'listheader': |
|
| 525 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === false) { |
||
| 526 | if(method_exists($renderer, 'listheader_open')) { |
||
| 527 | $renderer->listheader_open(1); |
||
| 528 | } else { |
||
| 529 | $renderer->listitem_open(1); |
||
| 530 | } |
||
| 531 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = true; |
||
| 532 | } |
||
| 533 | break; |
||
| 534 | case 'table': |
||
| 535 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === false) { |
||
| 536 | $renderer->tablerow_open(1); |
||
| 537 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = true; |
||
| 538 | } |
||
| 539 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['dtState'] == 1) { |
||
| 540 | $renderer->tablecell_close(); |
||
| 541 | } |
||
| 542 | View Code Duplication | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['dtState'] == 0) { |
|
| 543 | $properties = array(); |
||
| 544 | $properties ['border'] = 'none'; |
||
| 545 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 546 | $renderer->tablecell_close(); |
||
| 547 | } |
||
| 548 | |||
| 549 | $properties = array(); |
||
| 550 | $properties ['border'] = 'none'; |
||
| 551 | $renderer->_odtTableCellOpenUseProperties($properties); |
||
| 552 | break; |
||
| 553 | View Code Duplication | default: |
|
| 554 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === false) { |
||
| 555 | $renderer->listitem_open(1); |
||
| 556 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = true; |
||
| 557 | } |
||
| 558 | break; |
||
| 559 | } |
||
| 560 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['dtState'] = 0; |
||
| 561 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['ddState'] = 1; |
||
| 562 | break; |
||
| 563 | case 'dt_content_open': |
||
| 564 | switch($this->getConf('def_list_odt_export')) { |
||
| 565 | case 'table': |
||
| 566 | $renderer->p_open(); |
||
| 567 | break; |
||
| 568 | default: |
||
| 569 | $renderer->listcontent_open(); |
||
| 570 | break; |
||
| 571 | } |
||
| 572 | $this->renderODTOpenSpan($renderer); |
||
| 573 | break; |
||
| 574 | case 'dd_content_open': |
||
| 575 | switch($this->getConf('def_list_odt_export')) { |
||
| 576 | case 'table': |
||
| 577 | $renderer->p_open(); |
||
| 578 | break; |
||
| 579 | default: |
||
| 580 | $renderer->listcontent_open(); |
||
| 581 | break; |
||
| 582 | } |
||
| 583 | break; |
||
| 584 | case 'dt_content_close': |
||
| 585 | $this->renderODTCloseSpan($renderer); |
||
| 586 | switch($this->getConf('def_list_odt_export')) { |
||
| 587 | case 'table': |
||
| 588 | $renderer->p_close(); |
||
| 589 | break; |
||
| 590 | default: |
||
| 591 | $renderer->listcontent_close(); |
||
| 592 | break; |
||
| 593 | } |
||
| 594 | break; |
||
| 595 | case 'dd_content_close': |
||
| 596 | switch($this->getConf('def_list_odt_export')) { |
||
| 597 | case 'table': |
||
| 598 | $renderer->p_close(); |
||
| 599 | break; |
||
| 600 | default: |
||
| 601 | $renderer->listcontent_close(); |
||
| 602 | break; |
||
| 603 | } |
||
| 604 | break; |
||
| 605 | case 'dt_close': |
||
| 606 | switch($this->getConf('def_list_odt_export')) { |
||
| 607 | case 'listheader': |
||
| 608 | $renderer->linebreak(); |
||
| 609 | break; |
||
| 610 | case 'table': |
||
| 611 | $renderer->tablecell_close(); |
||
| 612 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['dtState'] = 2; |
||
| 613 | break; |
||
| 614 | default: |
||
| 615 | $renderer->linebreak(); |
||
| 616 | break; |
||
| 617 | } |
||
| 618 | break; |
||
| 619 | |||
| 620 | case 'dd_close': |
||
| 621 | switch($this->getConf('def_list_odt_export')) { |
||
| 622 | View Code Duplication | case 'listheader': |
|
| 623 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === true) { |
||
| 624 | if(method_exists($renderer, 'listheader_close')) { |
||
| 625 | $renderer->listheader_close(); |
||
| 626 | } else { |
||
| 627 | $renderer->listitem_close(); |
||
| 628 | } |
||
| 629 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = false; |
||
| 630 | } |
||
| 631 | break; |
||
| 632 | case 'table': |
||
| 633 | $renderer->tablecell_close(); |
||
| 634 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === true) { |
||
| 635 | $renderer->tablerow_close(1); |
||
| 636 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = false; |
||
| 637 | } |
||
| 638 | break; |
||
| 639 | View Code Duplication | default: |
|
| 640 | if(self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] === true) { |
||
| 641 | $renderer->listitem_close(1); |
||
| 642 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['itemOpen'] = false; |
||
| 643 | } |
||
| 644 | break; |
||
| 645 | } |
||
| 646 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['dtState'] = 0; |
||
| 647 | self::$odt_table_stack [self::$odt_table_stack_index - 1]['ddState'] = 2; |
||
| 648 | break; |
||
| 649 | |||
| 650 | case 'p_open': |
||
| 651 | $renderer->p_open(); |
||
| 652 | break; |
||
| 653 | case 'p_close': |
||
| 654 | $renderer->p_close(); |
||
| 655 | break; |
||
| 656 | } |
||
| 657 | } |
||
| 658 | |||
| 690 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.