mprins /
dokuwiki-plugin-geophp
| Conditions | 18 |
| Paths | 176 |
| Total Lines | 58 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 49 | public function read($address, $apiKey = null, $returnType = 'point', $bounds = false, $returnMultiple = false) |
||
| 50 | { |
||
| 51 | if (is_array($address)) { |
||
| 52 | $address = join(',', $address); |
||
| 53 | } |
||
| 54 | |||
| 55 | if (gettype($bounds) == 'object') { |
||
| 56 | $bounds = $bounds->getBBox(); |
||
| 57 | } |
||
| 58 | if (gettype($bounds) == 'array') { |
||
| 59 | $boundsString = '&bounds=' . $bounds['miny'] . ',' . $bounds['minx'] . '|' . $bounds['maxy'] . ',' . $bounds['maxx']; |
||
| 60 | } else { |
||
| 61 | $boundsString = ''; |
||
| 62 | } |
||
| 63 | |||
| 64 | $url = "http://maps.googleapis.com/maps/api/geocode/json"; |
||
| 65 | $url .= '?address=' . urlencode($address); |
||
| 66 | $url .= $boundsString . ($apiKey ? '&key=' . $apiKey : ''); |
||
| 67 | $this->result = json_decode(@file_get_contents($url)); |
||
| 68 | |||
| 69 | if ($this->result->status == 'OK') { |
||
| 70 | if (!$returnMultiple) { |
||
| 71 | if ($returnType == 'point') { |
||
| 72 | return $this->getPoint(); |
||
| 73 | } |
||
| 74 | if ($returnType == 'bounds' || $returnType == 'polygon') { |
||
| 75 | return $this->getPolygon(); |
||
| 76 | } |
||
| 77 | } else { |
||
| 78 | if ($returnType == 'point') { |
||
| 79 | $points = []; |
||
| 80 | foreach ($this->result->results as $delta => $item) { |
||
| 81 | $points[] = $this->getPoint($delta); |
||
| 82 | } |
||
| 83 | return new MultiPoint($points); |
||
| 84 | } |
||
| 85 | if ($returnType == 'bounds' || $returnType == 'polygon') { |
||
| 86 | $polygons = []; |
||
| 87 | foreach ($this->result->results as $delta => $item) { |
||
| 88 | $polygons[] = $this->getPolygon($delta); |
||
| 89 | } |
||
| 90 | return new MultiPolygon($polygons); |
||
| 91 | } |
||
| 92 | } |
||
| 93 | } elseif ($this->result->status == 'ZERO_RESULTS') { |
||
| 94 | return null; |
||
| 95 | } else { |
||
| 96 | if ($this->result->status) { |
||
| 97 | throw new \Exception( |
||
| 98 | 'Error in Google Reverse Geocoder: ' |
||
| 99 | . $this->result->status |
||
| 100 | . (isset($this->result->error_message) ? '. ' . $this->result->error_message : '') |
||
| 101 | ); |
||
| 102 | } else { |
||
| 103 | throw new \Exception('Unknown error in Google Reverse Geocoder'); |
||
| 104 | } |
||
| 105 | } |
||
| 106 | return false; |
||
| 107 | } |
||
| 213 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths