TeamworkTeamInviteTrait - Code Metrics - Inspection of "Merge pull request #33 from kyranb/master" - mpociot/teamwork - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 593138...2f2c8d )

by Marcel

created 2016-05-10 15:39 UTC

TeamworkTeamInviteTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	3
c	2
b	0
f	1
lcom	0
cbo	0
dl	0
loc	33
rs	10

3 Methods

Rating	Name	Size	Complexity
A	team()	4	1
A	user()	4	1
A	inviter()	4	1

<?php namespace Mpociot\Teamwork\Traits;

/**
 * This file is part of Teamwork
 *
 * @license MIT
 * @package Teamwork
 */

use Illuminate\Support\Facades\Config;

trait TeamworkTeamInviteTrait
{
    /**
     * Has-One relations with the team model.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
     */
    public function team()
    {
        return $this->hasOne( Config::get( 'teamwork.team_model' ), 'id', 'team_id' );
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Has-One relations with the user model.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
     */
    public function user()
    {
        return $this->hasOne( Config::get( 'teamwork.user_model' ), 'email', 'email' );
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Has-One relations with the user model.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
     */
    public function inviter()
    {
        return $this->hasOne( Config::get( 'teamwork.user_model' ), 'id', 'user_id' );
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

}


1			<?php namespace Mpociot\Teamwork\Traits;
2
3			/**
4			* This file is part of Teamwork
5			*
6			* @license MIT
7			* @package Teamwork
8			*/
9
10			use Illuminate\Support\Facades\Config;
11
12			trait TeamworkTeamInviteTrait
13			{
14			/**
15			* Has-One relations with the team model.
16			*
17			* @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
18			*/
19			public function team()
20			{
21			return $this->hasOne( Config::get( 'teamwork.team_model' ), 'id', 'team_id' );
			0 ignored issues – show Bug introduced 2016-01-04 21:47 UTC by Report Bug Copy Issue Report It seems like `hasOne()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			}
23
24			/**
25			* Has-One relations with the user model.
26			*
27			* @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
28			*/
29			public function user()
30			{
31			return $this->hasOne( Config::get( 'teamwork.user_model' ), 'email', 'email' );
			0 ignored issues – show Bug introduced 2016-01-04 21:47 UTC by Report Bug Copy Issue Report It seems like `hasOne()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			}
33
34			/**
35			* Has-One relations with the user model.
36			*
37			* @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
38			*/
39			public function inviter()
40			{
41			return $this->hasOne( Config::get( 'teamwork.user_model' ), 'id', 'user_id' );
			0 ignored issues – show Bug introduced 2016-05-10 15:38 UTC by Report Bug Copy Issue Report It seems like `hasOne()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42			}
43
44			}
45

mpociot / teamwork

Push — master ( 593138...2f2c8d )

TeamworkTeamInviteTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like