UsedByTeams::scopeAllTeams() - Code Metrics - Inspection of "dedicated `boot` method" - mpociot/teamwork - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#38)

by Jarek

created 2016-05-31 04:10 UTC

UsedByTeams::scopeAllTeams() A

↳ Parent: UsedByTeams

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php namespace Mpociot\Teamwork\Traits;

/**
 * This file is part of Teamwork
 *
 * @license MIT
 * @package Teamwork
 */

use Exception;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\Config;

/**
 * Class UsedByTeams
 * @package Mpociot\Teamwork\Traits
 */
trait UsedByTeams
{
    /**
     * Boot the global scope
     */
    protected static function bootUsedByTeams()
    {
        static::addGlobalScope('team', function (Builder $builder) {
            static::teamGuard();

            $builder->where('team_id', auth()->user()->currentTeam->getKey());

        });

        static::saving(function (Model $model) {
            static::teamGuard();

            if (!isset($model->team_id)) {
                $model->team_id = auth()->user()->currentTeam->getKey();

            }
        });
    }

    /**
     * @param Builder $query
     * @return mixed
     */
    public function scopeAllTeams(Builder $query)
    {
        return $query->withoutGlobalScope('team');
    }

    /**
     * @return mixed
     */
    public function team()
    {
        return $this->belongsTo(Config::get('teamwork.team_model'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @throws Exception
     */
    protected static function teamGuard()
    {
        if (auth()->guest() || !auth()->user()->currentTeam) {

            throw new Exception('No authenticated user with selected team present.');
        }
    }
}


1			<?php namespace Mpociot\Teamwork\Traits;
2
3			/**
4			* This file is part of Teamwork
5			*
6			* @license MIT
7			* @package Teamwork
8			*/
9
10			use Exception;
11			use Illuminate\Database\Eloquent\Builder;
12			use Illuminate\Database\Eloquent\Model;
13			use Illuminate\Support\Facades\Config;
14
15			/**
16			* Class UsedByTeams
17			* @package Mpociot\Teamwork\Traits
18			*/
19			trait UsedByTeams
20			{
21			/**
22			* Boot the global scope
23			*/
24			protected static function bootUsedByTeams()
25			{
26			static::addGlobalScope('team', function (Builder $builder) {
27			static::teamGuard();
28
29			$builder->where('team_id', auth()->user()->currentTeam->getKey());
			0 ignored issues – show Bug introduced 2016-05-30 20:31 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
30			});
31
32			static::saving(function (Model $model) {
33			static::teamGuard();
34
35			if (!isset($model->team_id)) {
36			$model->team_id = auth()->user()->currentTeam->getKey();
			0 ignored issues – show Bug introduced 2016-05-30 20:31 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
37			}
38			});
39			}
40
41			/**
42			* @param Builder $query
43			* @return mixed
44			*/
45			public function scopeAllTeams(Builder $query)
46			{
47			return $query->withoutGlobalScope('team');
48			}
49
50			/**
51			* @return mixed
52			*/
53			public function team()
54			{
55			return $this->belongsTo(Config::get('teamwork.team_model'));
			0 ignored issues – show Bug introduced 2016-05-30 20:31 UTC by Report Bug Copy Issue Report It seems like `belongsTo()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
56			}
57
58			/**
59			* @throws Exception
60			*/
61			protected static function teamGuard()
62			{
63			if (auth()->guest() \|\| !auth()->user()->currentTeam) {
			0 ignored issues – show Bug introduced 2016-05-30 20:31 UTC by Report Bug Copy Issue Report The method `guest()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-05-30 20:31 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
64			throw new Exception('No authenticated user with selected team present.');
65			}
66			}
67			}
68

mpociot / teamwork

Pull Request — master (#38)

UsedByTeams::scopeAllTeams() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like