Mpociot\CaptainHook\Http\WebhookController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	3
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	10	1
A	update()	0	10	1
A	destroy()	0	7	1
A	__construct()	0	3	1
A	all()	0	8	1
A	getTenantId()	0	4	3

<?php

namespace Mpociot\CaptainHook\Http;

use Illuminate\Http\Request;
use Laravel\Spark\Http\Controllers\Controller;
use Mpociot\CaptainHook\Http\Requests\CreateWebhookRequest;
use Mpociot\CaptainHook\Http\Requests\UpdateWebhookRequest;
use Mpociot\CaptainHook\Webhook;

class WebhookController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
    }

    /**
     * Get all of the webhooks generated by the user.
     *
     * @return Response
     */
    public function all(Request $request)
    {
        return Webhook::where('tenant_id', $this->getTenantId($request))
            ->with('lastLog')
            ->with('logs')
            ->orderBy('created_at', 'desc')
            ->get();
    }

    /**
     * Create a new webhook for the user.
     *
     * @param  CreateWebhookRequest  $request
     * @return Response
     */
    public function store(CreateWebhookRequest $request)
    {
        $hook = Webhook::create([
            'url' => $request->url,

The property url does not exist on object<Mpociot\CaptainHook\Http\Requests\CreateWebhookRequest>. Since you implemented __get, maybe consider adding a @property annotation.

            'tenant_id' => $this->getTenantId($request),
            'event' => $request->event,

The property event does not exist on object<Mpociot\CaptainHook\Http\Requests\CreateWebhookRequest>. Since you implemented __get, maybe consider adding a @property annotation.

        ]);

        return response()->json($hook);

$hook is of type this<Mpociot\CaptainHook\Http\WebhookController>, but the function expects a string|array.

    }

    /**
     * Update the given webhook.
     *
     * @param  UpdateWebhookRequest  $request
     * @param  string  $webhookId
     * @return Response
     */
    public function update(UpdateWebhookRequest $request, $webhookId)
    {
        $webhook = Webhook::where('tenant_id', $this->getTenantId($request))
            ->where('id', $webhookId)
            ->firstOrFail();

        $webhook->url = $request->url;

The property url does not seem to exist in Mpociot\CaptainHook\Http\Requests\UpdateWebhookRequest.

        $webhook->event = $request->event;

The property event does not seem to exist in Mpociot\CaptainHook\Http\Requests\UpdateWebhookRequest.

        $webhook->save();
    }

    /**
     * Delete the given webhook.
     *
     * @param  Request  $request
     * @param  string  $webhookId
     * @return Response
     */
    public function destroy(Request $request, $webhookId)
    {
        Webhook::where('tenant_id', $this->getTenantId($request))
            ->where('id', $webhookId)
            ->firstOrFail()
            ->delete();
    }

    protected function getTenantId(Request $request)
    {
        return (config('captain_hook.tenant_spark_model', 'User') == 'Team' && isset($request->user()->currentTeam)) ? $request->user()->currentTeam->id : $request->user()->getKey();
    }
}