Issues in StartWorkerCommand.php (master) - Issues in master - mpclarkson/resque-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Command/StartWorkerCommand.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Mpclarkson\ResqueBundle\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Process\Process;

/**
 * Class StartWorkerCommand
 * @package Mpclarkson\ResqueBundle\Command
 */
class StartWorkerCommand extends ContainerAwareCommand
{
    /**
     *
     */
    protected function configure()
    {
        $this
            ->setName('resque:worker-start')
            ->setDescription('Start a resque worker')
            ->addArgument('queues', InputArgument::REQUIRED, 'Queue names (separate using comma)')
            ->addOption('count', 'c', InputOption::VALUE_REQUIRED, 'How many workers to fork', 1)
            ->addOption('interval', 'i', InputOption::VALUE_REQUIRED, 'How often to check for new jobs across the queues', 5)
            ->addOption('foreground', 'f', InputOption::VALUE_NONE, 'Should the worker run in foreground')
            ->addOption('memory-limit', 'm', InputOption::VALUE_REQUIRED, 'Force cli memory_limit (expressed in Mbytes)');
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int|null|void
     */
    protected function execute(InputInterface $input, OutputInterface $output)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $env = [];

        // here to work around issues with pcntl and cli_set_process_title in PHP > 5.5
        if (version_compare(PHP_VERSION, '5.5.0') >= 0) {
            $env = $_SERVER;
            unset(
                $env['_'],
                $env['PHP_SELF'],
                $env['SCRIPT_NAME'],
                $env['SCRIPT_FILENAME'],
                $env['PATH_TRANSLATED'],
                $env['argv']
            );
        }

        $env['APP_INCLUDE'] = $this->getContainer()->getParameter('resque.app_include');
        $env['COUNT'] = $input->getOption('count');
        $env['INTERVAL'] = $input->getOption('interval');
        $env['QUEUE'] = $input->getArgument('queues');
        $env['VERBOSE'] = 1;

        if (FALSE !== getenv('APP_INCLUDE')) {
            $env['APP_INCLUDE'] = getenv('APP_INCLUDE');
        }

        $prefix = $this->getContainer()->getParameter('resque.prefix');
        if (!empty($prefix)) {
            $env['PREFIX'] = $this->getContainer()->getParameter('resque.prefix');
        }

        if ($input->getOption('verbose')) {
            $env['VVERBOSE'] = 1;
        }

        if ($input->getOption('quiet')) {
            unset($env['VERBOSE']);
        }

        $redisHost = $this->getContainer()->getParameter('resque.redis.host');
        $redisPort = $this->getContainer()->getParameter('resque.redis.port');
        $redisDatabase = $this->getContainer()->getParameter('resque.redis.database');

        if ($redisHost != NULL && $redisPort != NULL) {

            $env['REDIS_BACKEND'] = $redisHost . ':' . $redisPort;
        }

        if (isset($redisDatabase)) {
            $env['REDIS_BACKEND_DB'] = $redisDatabase;
        }

        $opt = '';
        if (0 !== $m = (int)$input->getOption('memory-limit')) {
            $opt = sprintf('-d memory_limit=%dM', $m);
        }

        if (version_compare(PHP_VERSION, '5.4.0') >= 0) {

            $phpExecutable = PHP_BINARY;
        } else {
            $phpExecutable = PHP_BINDIR . '/php';
            if (defined('PHP_WINDOWS_VERSION_BUILD')) {
                $phpExecutable = 'php';
            }
        }

        $workerCommand = strtr('%php% %opt% %dir%/resque', [
            '%php%' => $phpExecutable,
            '%opt%' => $opt,
            '%dir%' => __DIR__ . '/../bin',
        ]);

        if (!$input->getOption('foreground')) {
            $workerCommand = strtr('nohup %cmd% > %logs_dir%/resque.log 2>&1 & echo $!', [
                '%cmd%'      => $workerCommand,
                '%logs_dir%' => $this->getContainer()->getParameter('kernel.logs_dir'),
            ]);
        }

        // In windows: When you pass an environment to CMD it replaces the old environment
        // That means we create a lot of problems with respect to user accounts and missing vars
        // this is a workaround where we add the vars to the existing environment.
        if (defined('PHP_WINDOWS_VERSION_BUILD')) {

            foreach ($env as $key => $value) {
                putenv($key . "=" . $value);
            }
            $env = NULL;
        }

        $process = new Process($workerCommand, NULL, $env, NULL, NULL);

        if (!$input->getOption('quiet')) {
            $output->writeln(\sprintf('Starting worker <info>%s</info>', $process->getCommandLine()));
        }

        // if foreground, we redirect output
        if ($input->getOption('foreground')) {
            $process->run(function ($type, $buffer) use ($output) {
                $output->write($buffer);
            });
        } // else we recompose and display the worker id
        else {
            $process->run();
            $pid = \trim($process->getOutput());

            if (function_exists('gethostname')) {
                $hostname = gethostname();
            } else {
                $hostname = php_uname('n');
            }

            if (!$input->getOption('quiet')) {
                $output->writeln(\sprintf('<info>Worker started</info> %s:%s:%s', $hostname, $pid, $input->getArgument('queues')));
            }
        }
    }
}


1		<?php
2
3		namespace Mpclarkson\ResqueBundle\Command;
4
5		use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
6		use Symfony\Component\Console\Input\InputArgument;
7		use Symfony\Component\Console\Input\InputInterface;
8		use Symfony\Component\Console\Input\InputOption;
9		use Symfony\Component\Console\Output\OutputInterface;
10		use Symfony\Component\Process\Process;
11
12		/**
13		* Class StartWorkerCommand
14		* @package Mpclarkson\ResqueBundle\Command
15		*/
16		class StartWorkerCommand extends ContainerAwareCommand
17		{
18		/**
19		*
20		*/
21		protected function configure()
22		{
23		$this
24		->setName('resque:worker-start')
25		->setDescription('Start a resque worker')
26		->addArgument('queues', InputArgument::REQUIRED, 'Queue names (separate using comma)')
27		->addOption('count', 'c', InputOption::VALUE_REQUIRED, 'How many workers to fork', 1)
28		->addOption('interval', 'i', InputOption::VALUE_REQUIRED, 'How often to check for new jobs across the queues', 5)
29		->addOption('foreground', 'f', InputOption::VALUE_NONE, 'Should the worker run in foreground')
30		->addOption('memory-limit', 'm', InputOption::VALUE_REQUIRED, 'Force cli memory_limit (expressed in Mbytes)');
31		}
32
33		/**
34		* @param InputInterface $input
35		* @param OutputInterface $output
36		* @return int\|null\|void
37		*/
38		protected function execute(InputInterface $input, OutputInterface $output)
		0 ignored issues – show Coding Style introduced 2016-07-13 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `execute` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
39		{
40		$env = [];
41
42		// here to work around issues with pcntl and cli_set_process_title in PHP > 5.5
43		if (version_compare(PHP_VERSION, '5.5.0') >= 0) {
44		$env = $_SERVER;
45		unset(
46		$env['_'],
47		$env['PHP_SELF'],
48		$env['SCRIPT_NAME'],
49		$env['SCRIPT_FILENAME'],
50		$env['PATH_TRANSLATED'],
51		$env['argv']
52		);
53		}
54
55		$env['APP_INCLUDE'] = $this->getContainer()->getParameter('resque.app_include');
56		$env['COUNT'] = $input->getOption('count');
57		$env['INTERVAL'] = $input->getOption('interval');
58		$env['QUEUE'] = $input->getArgument('queues');
59		$env['VERBOSE'] = 1;
60
61		if (FALSE !== getenv('APP_INCLUDE')) {
62		$env['APP_INCLUDE'] = getenv('APP_INCLUDE');
63		}
64
65		$prefix = $this->getContainer()->getParameter('resque.prefix');
66		if (!empty($prefix)) {
67		$env['PREFIX'] = $this->getContainer()->getParameter('resque.prefix');
68		}
69
70		if ($input->getOption('verbose')) {
71		$env['VVERBOSE'] = 1;
72		}
73
74		if ($input->getOption('quiet')) {
75		unset($env['VERBOSE']);
76		}
77
78		$redisHost = $this->getContainer()->getParameter('resque.redis.host');
79		$redisPort = $this->getContainer()->getParameter('resque.redis.port');
80		$redisDatabase = $this->getContainer()->getParameter('resque.redis.database');
81
82	View Code Duplication	if ($redisHost != NULL && $redisPort != NULL) {
		0 ignored issues – show Duplication introduced 2016-07-13 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83		$env['REDIS_BACKEND'] = $redisHost . ':' . $redisPort;
84		}
85
86		if (isset($redisDatabase)) {
87		$env['REDIS_BACKEND_DB'] = $redisDatabase;
88		}
89
90		$opt = '';
91		if (0 !== $m = (int)$input->getOption('memory-limit')) {
92		$opt = sprintf('-d memory_limit=%dM', $m);
93		}
94
95	View Code Duplication	if (version_compare(PHP_VERSION, '5.4.0') >= 0) {
		0 ignored issues – show Duplication introduced 2016-07-13 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		$phpExecutable = PHP_BINARY;
97		} else {
98		$phpExecutable = PHP_BINDIR . '/php';
99		if (defined('PHP_WINDOWS_VERSION_BUILD')) {
100		$phpExecutable = 'php';
101		}
102		}
103
104		$workerCommand = strtr('%php% %opt% %dir%/resque', [
105		'%php%' => $phpExecutable,
106		'%opt%' => $opt,
107		'%dir%' => __DIR__ . '/../bin',
108		]);
109
110		if (!$input->getOption('foreground')) {
111		$workerCommand = strtr('nohup %cmd% > %logs_dir%/resque.log 2>&1 & echo $!', [
112		'%cmd%' => $workerCommand,
113		'%logs_dir%' => $this->getContainer()->getParameter('kernel.logs_dir'),
114		]);
115		}
116
117		// In windows: When you pass an environment to CMD it replaces the old environment
118		// That means we create a lot of problems with respect to user accounts and missing vars
119		// this is a workaround where we add the vars to the existing environment.
120	View Code Duplication	if (defined('PHP_WINDOWS_VERSION_BUILD')) {
		0 ignored issues – show Duplication introduced 2016-07-13 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		foreach ($env as $key => $value) {
122		putenv($key . "=" . $value);
123		}
124		$env = NULL;
125		}
126
127		$process = new Process($workerCommand, NULL, $env, NULL, NULL);
128
129		if (!$input->getOption('quiet')) {
130		$output->writeln(\sprintf('Starting worker <info>%s</info>', $process->getCommandLine()));
131		}
132
133		// if foreground, we redirect output
134		if ($input->getOption('foreground')) {
135		$process->run(function ($type, $buffer) use ($output) {
136		$output->write($buffer);
137		});
138		} // else we recompose and display the worker id
139		else {
140		$process->run();
141		$pid = \trim($process->getOutput());
142
143		if (function_exists('gethostname')) {
144		$hostname = gethostname();
145		} else {
146		$hostname = php_uname('n');
147		}
148
149		if (!$input->getOption('quiet')) {
150		$output->writeln(\sprintf('<info>Worker started</info> %s:%s:%s', $hostname, $pid, $input->getArgument('queues')));
151		}
152		}
153		}
154		}
155

mpclarkson / resque-bundle

Issues (15)

Security Analysis not enabled

Command/StartWorkerCommand.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like