ApiException::create() - Code Metrics - Inspection of "refactored a bit" - mpclarkson/freshdesk-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2b4de6...20220d )

by Matthew

created 2016-04-21 06:22 UTC

ApiException::create() C

↳ Parent: ApiException

Complexity

Conditions	10
Paths	10

Size

Total Lines	24
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	24
rs	5.2164
cc	10
eloc	22
nc	10
nop	1

How to fix Complexity

<?php
/**
 * Created by PhpStorm.
 * User: Matt
 */

namespace Freshdesk\Exceptions;

use Exception;
use GuzzleHttp\Exception\RequestException;

/**
 * General Exception
 *
 * Thrown when the Freshdesk API returns an HTTP error code that isn't handled by other exceptions
 *
 * @package Exceptions
 * @author Matthew Clarkson <[email protected]>
 */
class ApiException extends Exception
{

    /**
     * @internal
     * @param RequestException $e
     * @return AccessDeniedException|ApiException|AuthenticationException|ConflictingStateException|
     * MethodNotAllowedException|NotFoundException|RateLimitExceededException|UnsupportedAcceptHeaderException|
     * UnsupportedContentTypeException|ValidationException
     */
    static function create(RequestException $e) {

        switch ($e->getResponse()->getStatusCode()) {
            case 400:
                return new ValidationException($e);
            case 401:
                return new AuthenticationException($e);
            case 403:
                return new AccessDeniedException($e);
            case 404:
                return new NotFoundException($e);
            case 405:
                return new MethodNotAllowedException($e);
            case 406:
                return new UnsupportedAcceptHeaderException($e);
            case 409:
                return new ConflictingStateException($e);
            case 415:
                return new UnsupportedContentTypeException($e);
            case 429:
                return new RateLimitExceededException($e);
            default:
                return new ApiException($e);
        }
    }

    /**
     * @var RequestException
     * @internal
     */
    private $exception;

    /**
     * Returns the Request Exception
     *
     * A Guzzle Request Exception is returned
     *
     * @return RequestException
     */
    public function getRequestException()
    {
        return $this->exception;
    }

    /**
     * Exception constructor
     *
     * Constructs a new exception.
     *
     * @param RequestException $e
     * @internal
     */
    public function __construct(RequestException $e)
    {
        $this->exception = $e;
        parent::__construct();
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Matt
5			*/
6
7			namespace Freshdesk\Exceptions;
8
9			use Exception;
10			use GuzzleHttp\Exception\RequestException;
11
12			/**
13			* General Exception
14			*
15			* Thrown when the Freshdesk API returns an HTTP error code that isn't handled by other exceptions
16			*
17			* @package Exceptions
18			* @author Matthew Clarkson <[email protected]>
19			*/
20			class ApiException extends Exception
21			{
22
23			/**
24			* @internal
25			* @param RequestException $e
26			* @return AccessDeniedException\|ApiException\|AuthenticationException\|ConflictingStateException\|
27			* MethodNotAllowedException\|NotFoundException\|RateLimitExceededException\|UnsupportedAcceptHeaderException\|
28			* UnsupportedContentTypeException\|ValidationException
29			*/
30			static function create(RequestException $e) {
			0 ignored issues – show Best Practice introduced 2016-04-21 06:24 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
31			switch ($e->getResponse()->getStatusCode()) {
32			case 400:
33			return new ValidationException($e);
34			case 401:
35			return new AuthenticationException($e);
36			case 403:
37			return new AccessDeniedException($e);
38			case 404:
39			return new NotFoundException($e);
40			case 405:
41			return new MethodNotAllowedException($e);
42			case 406:
43			return new UnsupportedAcceptHeaderException($e);
44			case 409:
45			return new ConflictingStateException($e);
46			case 415:
47			return new UnsupportedContentTypeException($e);
48			case 429:
49			return new RateLimitExceededException($e);
50			default:
51			return new ApiException($e);
52			}
53			}
54
55			/**
56			* @var RequestException
57			* @internal
58			*/
59			private $exception;
60
61			/**
62			* Returns the Request Exception
63			*
64			* A Guzzle Request Exception is returned
65			*
66			* @return RequestException
67			*/
68			public function getRequestException()
69			{
70			return $this->exception;
71			}
72
73			/**
74			* Exception constructor
75			*
76			* Constructs a new exception.
77			*
78			* @param RequestException $e
79			* @internal
80			*/
81			public function __construct(RequestException $e)
82			{
83			$this->exception = $e;
84			parent::__construct();
85			}
86			}
87

mpclarkson / freshdesk-php-sdk

Push — master ( 2b4de6...20220d )

ApiException::create() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like