FirephpPluginFactoryTest::testFactoryReturnsInstance() - Code Metrics - mpalourdio/MpaFirephpWrapper - Measure and Improve Code Quality continuously with Scrutinizer

testFactoryReturnsInstance() A
last analyzed 2017-02-04 09:40 UTC

↳ Parent: FirephpPluginFactoryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0

<?php

namespace MpaFirephpWrapperTest\Controller\Plugin;

use MpaFirephpWrapper\Controller\Plugin\FirephpPlugin;
use MpaFirephpWrapper\Controller\Plugin\FirephpPluginFactory;
use MpaFirephpWrapper\Service\FirephpWrapper;
use MpaFirephpWrapperTest\Util\ServiceManagerFactory;
use PHPUnit\Framework\TestCase;

class FirephpPluginFactoryTest extends TestCase
{
    protected $serviceManager;

    protected function setUp()
    {
        $this->serviceManager = ServiceManagerFactory::getServiceManager();
        $this->serviceManager->setAllowOverride(true);

        $this->serviceManager->setService(
            'firephp',
            $this->getMockBuilder(FirephpWrapper::class)
                ->disableOriginalConstructor()
                ->getMock()
        );
    }

    public function testFactoryReturnsInstance()
    {
        $factory = new FirephpPluginFactory();
        $result  = $factory->createService($this->serviceManager->get('ControllerPluginManager'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertInstanceOf(FirephpPlugin::class, $result);
    }
}


1			<?php
2
3			namespace MpaFirephpWrapperTest\Controller\Plugin;
4
5			use MpaFirephpWrapper\Controller\Plugin\FirephpPlugin;
6			use MpaFirephpWrapper\Controller\Plugin\FirephpPluginFactory;
7			use MpaFirephpWrapper\Service\FirephpWrapper;
8			use MpaFirephpWrapperTest\Util\ServiceManagerFactory;
9			use PHPUnit\Framework\TestCase;
10
11			class FirephpPluginFactoryTest extends TestCase
12			{
13			protected $serviceManager;
14
15			protected function setUp()
16			{
17			$this->serviceManager = ServiceManagerFactory::getServiceManager();
18			$this->serviceManager->setAllowOverride(true);
19
20			$this->serviceManager->setService(
21			'firephp',
22			$this->getMockBuilder(FirephpWrapper::class)
23			->disableOriginalConstructor()
24			->getMock()
25			);
26			}
27
28			public function testFactoryReturnsInstance()
29			{
30			$factory = new FirephpPluginFactory();
31			$result = $factory->createService($this->serviceManager->get('ControllerPluginManager'));
			0 ignored issues – show Documentation introduced 2015-12-05 23:13 UTC by Report Bug Copy Issue Report `$this->serviceManager->g...ntrollerPluginManager')` is of type `object\|array`, but the function expects a `object<Zend\ServiceManag...erviceLocatorInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32
33			$this->assertInstanceOf(FirephpPlugin::class, $result);
34			}
35			}
36

mpalourdio / MpaFirephpWrapper

GitHub Access Token became invalid

testFactoryReturnsInstance() A last analyzed 2017-02-04 09:40 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

testFactoryReturnsInstance() A
last analyzed 2017-02-04 09:40 UTC