Issues in ApiService.php (master) - Issues in master - mozgbrasil/cielo-braspag-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (10)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/ApiService.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Copyright © 2015 Mozg. All rights reserved.
 * See LICENSE.txt for license details.
 */

namespace Mozg\Cielo;

use GuzzleHttp\Exception\RequestException;
use GuzzleHttp\Client as HttpClient;

class HttpStatus
{
    const Ok = 200;
    const Created = 201;
    const BadRequest = 400;
    const NotFound = 404;
}

class ApiService
{

    /**
     * @var array
     */
    protected $config;

    /**
     * @var array
     */
    protected $headers;

    /**
     * @var HttpClient
     */
    protected $http;

    /**
     * @var array
     */
    protected $debugData  = array();

    /**
     * ApiService constructor.
     * @param array $options
     */
    public function __construct($options = [])
    {

        $this->debugData[] = __METHOD__;

        $this->config = $options;

        $this->headers = $this->config['headers'];
    }

    public function __destruct()
    {

        $this->debugData[] = __METHOD__;

        $_array = $this->debugData;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //\Zend\Debug\Debug::dump($_array);

    }

    /**
     * @param -
     * @return -
     * @throws \Exception
     */
    public function authorize($parameters)
    {

        $this->debugData[] = __METHOD__;

        $method = 'POST';
        $uri = $this->config['apiUri'] . '/sales/';
        $options = [
            'body' => \json_encode($parameters),
            'headers' => $this->headers
        ];

        $this->debugData[][__LINE__]['method'] = $method;
        $this->debugData[][__LINE__]['uri'] = $uri;
        $this->debugData[][__LINE__]['options'] = $uri;

        try {

            $response = $this->http()->request($method, $uri, $options);

            $this->debugData[][__LINE__]['response'] = $response;

            $result = \json_decode($response->getBody()->getContents(), true);

            $this->debugData[][__LINE__]['result'] = $result;

        } catch (RequestException $e) {

            $result = array(
                'code'=>$e->getCode(),
                'message'=>$e->getMessage()
                );

            $this->debugData[][__LINE__]['exception'] = $e->getMessage();
        }

        return $result;
    }

    /**
     * Gets a sale
     * @param string $paymentId
     * @return mixed
     */
    public function get($paymentId)
    {

        $this->debugData[] = __METHOD__;

        $method = 'GET';
        $uri = $this->config['apiQueryUri'] . \sprintf('/sales/%s', $paymentId);
        $options = [
            'headers' => $this->headers
        ];

        $this->debugData[][__LINE__]['method'] = $method;
        $this->debugData[][__LINE__]['uri'] = $uri;
        $this->debugData[][__LINE__]['options'] = $uri;

        try {

            $response = $this->http()->request($method, $uri, $options);

            $this->debugData[][__LINE__]['response'] = $response;

            $result = \json_decode($response->getBody()->getContents(), true);            

            if ($response->getStatusCode() === HttpStatus::Ok) {
                return $result;
            } elseif ($response->getStatusCode() == HttpStatus::BadRequest) {
                return 'status_codex';
            }

        } catch (\Exception $e) {

            $result = array(
                'code'=>$e->getCode(),
                'message'=>$e->getMessage()
                );

            $this->debugData[][__LINE__]['exception'] = $e->getMessage();

        }

        return $result;
    }

    /**
     * Captures a pre-authorized payment
     * @param string $paymentId
     * @param array $captureRequest
     * @return mixed
     */
    public function capture($paymentId, $captureRequest)
    {

        $this->debugData[] = __METHOD__;

        
        if (!$paymentId) {
            throw new \InvalidArgumentException('$paymentId é obrigatório');
        }

        $method = 'PUT';
        $uri = $this->config['apiUri'] . \sprintf('/sales/%s/capture', $paymentId);
        $options = [
            'headers' => $this->headers
        ];
        
        if (!empty($captureRequest)) {
            $uri .= '?' . \http_build_query($captureRequest);
        }

        $this->debugData[][__LINE__]['method'] = $method;
        $this->debugData[][__LINE__]['uri'] = $uri;
        $this->debugData[][__LINE__]['options'] = $uri;

        try {

            $response = $this->http()->request($method, $uri, $options);

            $this->debugData[][__LINE__]['response'] = $response;

            $result = \json_decode($response->getBody()->getContents(), true);

            $this->debugData[][__LINE__]['result'] = $result;

        } catch (RequestException $e) {

            $result = array(
                'code'=>$e->getCode(),
                'message'=>$e->getMessage()
                );

            $this->debugData[][__LINE__]['exception'] = $e->getMessage();

        }

        return $result;
    }

    /**
     * Void a payment
     * @param string $paymentId
     * @param int $amount
     * @return mixed
     */
    public function void($paymentId, $amount)
    {

        $this->debugData[] = __METHOD__;

        $method = 'PUT';
        $uri = $this->config['apiUri'] . \sprintf('/sales/%s/void', $paymentId);
        $options = [
            'headers' => $this->headers
        ];

        if ($amount) {
            $uri .= sprintf('?amount=%s', (float)$amount);
        }

        $this->debugData[][__LINE__]['method'] = $method;
        $this->debugData[][__LINE__]['uri'] = $uri;
        $this->debugData[][__LINE__]['options'] = $uri;

        try {

            $response = $this->http()->request($method, $uri, $options);

            $this->debugData[][__LINE__]['response'] = $response;

            $result = \json_decode($response->getBody()->getContents(), true);

            $this->debugData[][__LINE__]['result'] = $result;

        } catch (RequestException $e) {

            $result = array(
                'code'=>$e->getCode(),
                'message'=>$e->getMessage()
                );

            $this->debugData[][__LINE__]['exception'] = $e->getMessage();

        }

        return $result;
    }

    /**
     * @return HttpClient
     */
    protected function http()
    {

        $this->debugData[] = __METHOD__;

        if (!$this->http) {
            $this->http = new HttpClient();
        }
        return $this->http;
    }


}


1			<?php
2
3			/**
4			* Copyright © 2015 Mozg. All rights reserved.
5			* See LICENSE.txt for license details.
6			*/
7
8			namespace Mozg\Cielo;
9
10			use GuzzleHttp\Exception\RequestException;
11			use GuzzleHttp\Client as HttpClient;
12
13			class HttpStatus
14			{
15			const Ok = 200;
16			const Created = 201;
17			const BadRequest = 400;
18			const NotFound = 404;
19			}
20
21			class ApiService
22			{
23
24			/**
25			* @var array
26			*/
27			protected $config;
28
29			/**
30			* @var array
31			*/
32			protected $headers;
33
34			/**
35			* @var HttpClient
36			*/
37			protected $http;
38
39			/**
40			* @var array
41			*/
42			protected $debugData = array();
43
44			/**
45			* ApiService constructor.
46			* @param array $options
47			*/
48			public function __construct($options = [])
49			{
50
51			$this->debugData[] = __METHOD__;
52
53			$this->config = $options;
54
55			$this->headers = $this->config['headers'];
56			}
57
58			public function __destruct()
59			{
60
61			$this->debugData[] = __METHOD__;
62
63			$_array = $this->debugData;
			0 ignored issues – show Unused Code introduced 2016-11-24 18:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$_array` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
64
65			//\Zend\Debug\Debug::dump($_array);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-24 18:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
66			}
67
68			/**
69			* @param -
70			* @return -
71			* @throws \Exception
72			*/
73			public function authorize($parameters)
74			{
75
76			$this->debugData[] = __METHOD__;
77
78			$method = 'POST';
79			$uri = $this->config['apiUri'] . '/sales/';
80			$options = [
81			'body' => \json_encode($parameters),
82			'headers' => $this->headers
83			];
84
85			$this->debugData[][__LINE__]['method'] = $method;
86			$this->debugData[][__LINE__]['uri'] = $uri;
87			$this->debugData[][__LINE__]['options'] = $uri;
88
89			try {
90
91			$response = $this->http()->request($method, $uri, $options);
92
93			$this->debugData[][__LINE__]['response'] = $response;
94
95			$result = \json_decode($response->getBody()->getContents(), true);
96
97			$this->debugData[][__LINE__]['result'] = $result;
98
99			} catch (RequestException $e) {
100
101			$result = array(
102			'code'=>$e->getCode(),
103			'message'=>$e->getMessage()
104			);
105
106			$this->debugData[][__LINE__]['exception'] = $e->getMessage();
107			}
108
109			return $result;
110			}
111
112			/**
113			* Gets a sale
114			* @param string $paymentId
115			* @return mixed
116			*/
117			public function get($paymentId)
118			{
119
120			$this->debugData[] = __METHOD__;
121
122			$method = 'GET';
123			$uri = $this->config['apiQueryUri'] . \sprintf('/sales/%s', $paymentId);
124			$options = [
125			'headers' => $this->headers
126			];
127
128			$this->debugData[][__LINE__]['method'] = $method;
129			$this->debugData[][__LINE__]['uri'] = $uri;
130			$this->debugData[][__LINE__]['options'] = $uri;
131
132			try {
133
134			$response = $this->http()->request($method, $uri, $options);
135
136			$this->debugData[][__LINE__]['response'] = $response;
137
138			$result = \json_decode($response->getBody()->getContents(), true);
139
140			if ($response->getStatusCode() === HttpStatus::Ok) {
141			return $result;
142			} elseif ($response->getStatusCode() == HttpStatus::BadRequest) {
143			return 'status_codex';
144			}
145
146			} catch (\Exception $e) {
147
148			$result = array(
149			'code'=>$e->getCode(),
150			'message'=>$e->getMessage()
151			);
152
153			$this->debugData[][__LINE__]['exception'] = $e->getMessage();
154
155			}
156
157			return $result;
158			}
159
160			/**
161			* Captures a pre-authorized payment
162			* @param string $paymentId
163			* @param array $captureRequest
164			* @return mixed
165			*/
166			public function capture($paymentId, $captureRequest)
167			{
168
169			$this->debugData[] = __METHOD__;
170
171
172			if (!$paymentId) {
173			throw new \InvalidArgumentException('$paymentId é obrigatório');
174			}
175
176			$method = 'PUT';
177			$uri = $this->config['apiUri'] . \sprintf('/sales/%s/capture', $paymentId);
178			$options = [
179			'headers' => $this->headers
180			];
181
182			if (!empty($captureRequest)) {
183			$uri .= '?' . \http_build_query($captureRequest);
184			}
185
186			$this->debugData[][__LINE__]['method'] = $method;
187			$this->debugData[][__LINE__]['uri'] = $uri;
188			$this->debugData[][__LINE__]['options'] = $uri;
189
190			try {
191
192			$response = $this->http()->request($method, $uri, $options);
193
194			$this->debugData[][__LINE__]['response'] = $response;
195
196			$result = \json_decode($response->getBody()->getContents(), true);
197
198			$this->debugData[][__LINE__]['result'] = $result;
199
200			} catch (RequestException $e) {
201
202			$result = array(
203			'code'=>$e->getCode(),
204			'message'=>$e->getMessage()
205			);
206
207			$this->debugData[][__LINE__]['exception'] = $e->getMessage();
208
209			}
210
211			return $result;
212			}
213
214			/**
215			* Void a payment
216			* @param string $paymentId
217			* @param int $amount
218			* @return mixed
219			*/
220			public function void($paymentId, $amount)
221			{
222
223			$this->debugData[] = __METHOD__;
224
225			$method = 'PUT';
226			$uri = $this->config['apiUri'] . \sprintf('/sales/%s/void', $paymentId);
227			$options = [
228			'headers' => $this->headers
229			];
230
231			if ($amount) {
232			$uri .= sprintf('?amount=%s', (float)$amount);
233			}
234
235			$this->debugData[][__LINE__]['method'] = $method;
236			$this->debugData[][__LINE__]['uri'] = $uri;
237			$this->debugData[][__LINE__]['options'] = $uri;
238
239			try {
240
241			$response = $this->http()->request($method, $uri, $options);
242
243			$this->debugData[][__LINE__]['response'] = $response;
244
245			$result = \json_decode($response->getBody()->getContents(), true);
246
247			$this->debugData[][__LINE__]['result'] = $result;
248
249			} catch (RequestException $e) {
250
251			$result = array(
252			'code'=>$e->getCode(),
253			'message'=>$e->getMessage()
254			);
255
256			$this->debugData[][__LINE__]['exception'] = $e->getMessage();
257
258			}
259
260			return $result;
261			}
262
263			/**
264			* @return HttpClient
265			*/
266			protected function http()
267			{
268
269			$this->debugData[] = __METHOD__;
270
271			if (!$this->http) {
272			$this->http = new HttpClient();
273			}
274			return $this->http;
275			}
276
277
278			}
279

mozgbrasil / cielo-braspag-sdk-php

Issues (10)

Security Analysis not enabled

src/ApiService.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like