| Total Complexity | 9 |
| Total Lines | 43 |
| Duplicated Lines | 62.79 % |
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | #!/usr/bin/env python |
||
| 14 | class LinphonePlayer(PlayerAbstractBaseClass): |
||
| 15 | |||
| 16 | __player_id = None |
||
| 17 | __slot_id = None |
||
| 18 | |||
| 19 | __player_filename = '' |
||
| 20 | |||
| 21 | @property |
||
| 22 | def player_filename(self): return self.__player_filename |
||
| 23 | |||
| 24 | View Code Duplication | def __init__(self): |
|
|
|
|||
| 25 | self.__player_filename = doorpi.DoorPi().config.get_string_parsed(SIPPHONE_SECTION, 'dialtone', |
||
| 26 | '!BASEPATH!/media/ShortDialTone.wav') |
||
| 27 | if self.__player_filename is '': |
||
| 28 | logger.debug('no player found in config at section DoorPi and key dialtone') |
||
| 29 | return |
||
| 30 | |||
| 31 | doorpi.DoorPi().event_handler.register_action('OnSipPhoneDestroy', self.destroy) |
||
| 32 | |||
| 33 | self.__player_filename = doorpi.DoorPi().parse_string(self.__player_filename) |
||
| 34 | if not os.path.exists(os.path.dirname(self.__player_filename)): |
||
| 35 | logger.info('Path %s does not exist - creating it now', os.path.dirname(self.__player_filename)) |
||
| 36 | os.makedirs(os.path.dirname(self.__player_filename)) |
||
| 37 | dialtone_renew_every_start = doorpi.DoorPi().config.get_bool(SIPPHONE_SECTION, 'dialtone_renew_every_start', False) |
||
| 38 | if not os.path.isfile(self.__player_filename) or dialtone_renew_every_start: |
||
| 39 | logger.info('DialTone %s does not exist - creating it now', self.__player_filename) |
||
| 40 | dialtone_volume = doorpi.DoorPi().config.get_int(SIPPHONE_SECTION, 'dialtone_volume', 35) |
||
| 41 | generate_dial_tone(self.__player_filename, dialtone_volume) |
||
| 42 | doorpi.DoorPi().event_handler.register_event('OnPlayerStarted', __name__) |
||
| 43 | doorpi.DoorPi().event_handler.register_event('OnPlayerStopped', __name__) |
||
| 44 | doorpi.DoorPi().event_handler.register_event('OnPlayerCreated', __name__) |
||
| 45 | |||
| 46 | doorpi.DoorPi().event_handler.register_action('OnSipPhoneMakeCall', self.start) |
||
| 47 | doorpi.DoorPi().event_handler.register_action('OnCallStateConnect', self.stop) |
||
| 48 | doorpi.DoorPi().event_handler.register_action('OnCallStateDisconnect', self.stop) |
||
| 49 | |||
| 50 | doorpi.DoorPi().event_handler('OnPlayerCreated', __name__) |
||
| 51 | |||
| 52 | def start(self): doorpi.DoorPi().event_handler('OnPlayerStarted', __name__) |
||
| 53 | def stop(self): doorpi.DoorPi().event_handler('OnPlayerStopped', __name__) |
||
| 54 | def destroy(self): |
||
| 55 | self.stop() |
||
| 56 | doorpi.DoorPi().event_handler.unregister_source(__name__, True) |
||
| 57 |