mostafaznv / larupload

src/Concerns/Standalone/BootStandaloneLarupload.php

<?php

namespace Mostafaznv\Larupload\Concerns\Standalone;

use Mostafaznv\Larupload\Enums\LaruploadMode;
use Mostafaznv\Larupload\Larupload;

trait BootStandaloneLarupload
{
    protected static string $laruploadNull;

    protected bool $internalFunctionIsCallable = false;


    public function __construct(string $name, LaruploadMode $mode)

The parameter $mode is not used and could be removed.

    {
        static::$laruploadNull = crc32(time());

        if (!defined('LARUPLOAD_NULL')) {
            // @codeCoverageIgnoreStart
            define('LARUPLOAD_NULL', static::$laruploadNull);
            // @codeCoverageIgnoreEnd
        }

        parent::__construct($name, LaruploadMode::STANDALONE);
    }


    public static function init(string $name): Larupload
    {
        $instance = new self($name, LaruploadMode::STANDALONE);
        $instance->id = time();

The property id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $instance;

The expression return $instance returns the type Mostafaznv\Larupload\Concerns\Standalone\BootStandaloneLarupload which includes types incompatible with the type-hinted return Mostafaznv\Larupload\Larupload.

    }
}