mostafaznv / larupload

src/Concerns/Standalone/BaseStandaloneLarupload.php

<?php

namespace Mostafaznv\Larupload\Concerns\Standalone;


use Illuminate\Http\UploadedFile;
use Illuminate\Support\Facades\Storage;
use Mostafaznv\Larupload\Actions\GuessLaruploadFileTypeAction;
use Mostafaznv\Larupload\Actions\OptimizeImageAction;

trait BaseStandaloneLarupload
{
    public function upload(UploadedFile $file, ?UploadedFile $cover = null): object
    {
        $this->internalFunctionIsCallable = true;

The property internalFunctionIsCallable does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        file_is_valid($file, $this->name, 'file');
        file_is_valid($cover, $this->name, 'cover');

        $this->file = $this->optimizeImage ? OptimizeImageAction::make($file)->process() : $file;

The property file does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->type = GuessLaruploadFileTypeAction::make($file)->calc();

The property type does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->cover = $cover;

The property cover does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->clean($this->id);

It seems like clean() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->setBasicDetails();

It seems like setBasicDetails() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->setMediaDetails();

It seems like setMediaDetails() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->uploadOriginalFile($this->id);

The method uploadOriginalFile() does not exist on Mostafaznv\Larupload\Concerns\Standalone\BaseStandaloneLarupload. Did you maybe mean upload()?

        $this->setCover($this->id);

It seems like setCover() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->handleStyles($this->id, self::class, true);

It seems like handleStyles() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $urls = $this->urls();

It seems like urls() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->updateMeta($urls);

        return $urls;
    }

    public function delete(): bool
    {
        $basePath = $this->getBasePath($this->id);

It seems like getBasePath() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (Storage::disk($this->disk)->exists($basePath)) {
            $this->clean($this->id);

            return true;
        }

        return false;
    }

    private function updateMeta(?object $urls = null): void
    {
        if (is_null($urls)) {
            $urls = $this->urls();
        }

        $metaPath = $this->getBasePath($this->id) . '/.meta';
        Storage::disk($this->disk)->put($metaPath, json_encode($urls), 'private');
    }

    /**
     * Check if .meta file exists
     *
     * @return bool
     */
    private function metaExists(): bool
    {
        $metaPath = $this->getBasePath($this->id) . '/.meta';

        if (Storage::disk($this->disk)->exists($metaPath)) {
            $meta = Storage::disk($this->disk)->get($metaPath);
            $meta = json_decode($meta);

It seems like $meta can also be of type null; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            foreach ($meta->meta as $key => $value) {
                $this->output[$key] = $value;

The property output does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }

            return true;
        }

        return false;
    }
}