mostafaznv /
larupload
| Conditions | 13 |
| Paths | 9 |
| Total Lines | 27 |
| Code Lines | 16 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 30 | private function validateDimension(): void |
||
| 31 | { |
||
| 32 | if ($this->mode === LaruploadMediaStyle::SCALE_HEIGHT) { |
||
| 33 | if ($this->width === null or $this->width === 0) { |
||
| 34 | throw new Exception( |
||
| 35 | 'Width is required when you are in SCALE_HEIGHT mode' |
||
| 36 | ); |
||
| 37 | } |
||
| 38 | } |
||
| 39 | else if ($this->mode === LaruploadMediaStyle::SCALE_WIDTH) { |
||
| 40 | if ($this->height === null or $this->height === 0) { |
||
| 41 | throw new Exception( |
||
| 42 | 'Height is required when you are in SCALE_WIDTH mode' |
||
| 43 | ); |
||
| 44 | } |
||
| 45 | } |
||
| 46 | else if (in_array($this->mode, [LaruploadMediaStyle::CROP, LaruploadMediaStyle::FIT])) { |
||
| 47 | if (!$this->width or !$this->height) { |
||
| 48 | throw new Exception( |
||
| 49 | 'Width and Height are required when you are in CROP/FIT mode' |
||
| 50 | ); |
||
| 51 | } |
||
| 52 | } |
||
| 53 | else if ($this->mode === LaruploadMediaStyle::AUTO) { |
||
| 54 | if (!$this->width and !$this->height) { |
||
| 55 | throw new Exception( |
||
| 56 | 'Width and height are required when you are in auto mode' |
||
| 57 | ); |
||
| 62 |
Loading history...