Mostafaznv\Larupload\Concerns\Storage\Attachment\CoverAttachment

Complexity

Total Complexity

5

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setCover()	0	17	1
A	detachCover()	0	11	2
A	updateCover()	0	13	2

<?php

namespace Mostafaznv\Larupload\Concerns\Storage\Attachment;


use Illuminate\Http\UploadedFile;
use Mostafaznv\Larupload\Actions\Cover\SetCoverAction;
use Mostafaznv\Larupload\DTOs\CoverActionData;
use Mostafaznv\Larupload\Enums\LaruploadFileType;
use Mostafaznv\Larupload\Larupload;

trait CoverAttachment
{
    public function updateCover(UploadedFile $file): bool
    {
        file_is_valid($file, $this->name, 'cover');

        if ($this->output['type']) {
            $this->uploaded = false;

The property uploaded does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->cover = $file;

The property cover does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->type = LaruploadFileType::from($this->output['type']);

The property type does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return true;
        }

        return false;
    }

    public function detachCover(): bool
    {
        if ($this->output['type']) {
            $this->uploaded = false;

The property uploaded does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->cover = LARUPLOAD_NULL;

The property cover does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->type = LaruploadFileType::from($this->output['type']);

The property type does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return true;
        }

        return false;
    }


    /**
     * Set cover photo
     * Generate cover photo automatically from photos and videos, if cover file was null
     *
     * @param $id
     */
    protected function setCover($id): void
    {
        $path = $this->getBasePath($id, Larupload::COVER_FOLDER);

It seems like getBasePath() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $data = CoverActionData::make(
            disk: $this->disk,
            namingMethod: $this->namingMethod,
            lang: $this->lang,
            style: $this->coverStyle,

The property coverStyle does not exist on Mostafaznv\Larupload\Concerns\Storage\Attachment\CoverAttachment. Did you mean cover?

            type: $this->type,
            generateCover: $this->generateCover,
            withDominantColor: $this->dominantColor,
            dominantColorQuality: $this->dominantColorQuality,
            imageProcessingLibrary: $this->imageProcessingLibrary,
            output: $this->output
        );

        $this->output = SetCoverAction::make($this->file ?? null, $this->cover, $data)->run($path);

The property output does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }
}