Mostafaznv\Larupload\Concerns\Standalone\StandaloneLaruploadCover

Complexity

Total Complexity

10

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	deleteCover()	0	15	3
A	changeCover()	0	15	3
A	detachCover()	0	7	2
A	updateCover()	0	7	2

<?php

namespace Mostafaznv\Larupload\Concerns\Standalone;

use Illuminate\Http\UploadedFile;

trait StandaloneLaruploadCover
{
    /**
     * @internal
     */
    public function updateCover(UploadedFile $file): bool
    {
        if ($this->internalFunctionIsCallable) {
            return parent::updateCover($file);
        }

        $this->internalException();

In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

It seems like internalException() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function changeCover(UploadedFile $file): ?object
    {
        if ($this->metaExists()) {

It seems like metaExists() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->internalFunctionIsCallable = true;

The property internalFunctionIsCallable does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $res = $this->updateCover($file);

            if ($res) {
                $this->setCover($this->id);

It seems like setCover() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->updateMeta();

It seems like updateMeta() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                return $this->urls();

It seems like urls() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        }

        return null;
    }

    public function deleteCover(): ?object
    {
        if ($this->metaExists()) {
            $this->internalFunctionIsCallable = true;

The property internalFunctionIsCallable does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $res = $this->detachCover();

            if ($res) {
                $this->setCover($this->id);
                $this->updateMeta();

                return $this->urls();
            }
        }

        return null;
    }

    /**
     * @internal
     */
    public function detachCover(): bool
    {
        if ($this->internalFunctionIsCallable) {
            return parent::detachCover();
        }

        $this->internalException();

In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

    }
}