mostafaznv / laracache

src/DTOs/CommandData.php

<?php

namespace Mostafaznv\LaraCache\DTOs;

use Mostafaznv\LaraCache\Exceptions\EntityIsNotAllowed;
use Mostafaznv\LaraCache\Exceptions\ModelDoesntUseLaraCacheTrait;
use Mostafaznv\LaraCache\Exceptions\ModelDoestNotExist;

class CommandData
{
    public function __construct(
        /**
         * @var \Mostafaznv\LaraCache\Traits\LaraCache[] $models
         */
        public array $models,
        public array $entities
    ) {}

    public static function make(array $models, array $entities = []): self
    {
        if (count($models) > 1 and count($entities)) {
            throw EntityIsNotAllowed::make();
        }

        $m = [];

        foreach ($models as $model) {
            $m[] = self::model($model);
        }

        return new static($m, $entities);
    }


    private static function model(?string $model): string
    {
        if ($model) {
            if (self::modelExists($model)) {
                return $model;

The expression return $model returns the type object which is incompatible with the type-hinted return string.

            }

            // @codeCoverageIgnoreStart
            $defaultPath = "App\\Models\\$model";

            if (self::modelExists($defaultPath)) {
                return $defaultPath;

The expression return $defaultPath returns the type object which is incompatible with the type-hinted return string.

            }
            // @codeCoverageIgnoreEnd
        }

        throw ModelDoestNotExist::make($model);

It seems like $model can also be of type null and object; however, parameter $model of Mostafaznv\LaraCache\Exceptions\ModelDoestNotExist::make() does only seem to accept string, maybe add an additional type check?

    }

    private static function modelExists(string $model): bool
    {
        if (class_exists($model)) {
            if (method_exists($model, 'cache')) {
                return true;
            }

            throw ModelDoesntUseLaraCacheTrait::make($model);
        }

        return false;
    }
}