Guard::getNames() - Code Metrics - Inspection of "V1.8.2" - mostafamaklad/laravel-permission-mongodb - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#70)

by Mostafa Abd El-Salam

created 2018-06-24 00:57 UTC

Guard::getNames() B

↳ Parent: Guard

Complexity

Conditions	6
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	0
cts	18
cp	0
rs	8.8817
c	0
b	0
f	0
cc	6
nc	12
nop	1
crap	42

<?php

namespace Maklad\Permission;

use Illuminate\Support\Collection;

/**
 * Class Guard
 * @package Maklad\Permission
 */
class Guard
{
    /**
     * return collection of (guard_name) property if exist on class or object
     * otherwise will return collection of guards names that exists in config/auth.php.
     *
     * @param $model
     *
     * @return Collection
     * @throws \ReflectionException
     */
    public function getNames($model) : Collection
    {
        if (\is_object($model)) {
            $guardName = $model->guard_name ?? null;
        }

        if (! isset($guardName)) {
            $class = \is_object($model) ? \get_class($model) : $model;
            $guardName = (new \ReflectionClass($class))->getDefaultProperties()['guard_name'] ?? null;
        }

        if ($guardName) {
            return collect($guardName);
        }
        return collect(config('auth.guards'))
            ->map(function ($guard) {
                if (! isset($guard['provider'])) {
                    return;
                }
                return config("auth.providers.{$guard['provider']}.model");
            })
            ->filter(function ($model) use ($class) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                return $class === $model;
            })
            ->keys();
    }

    /**
     * Return Default Guard name
     *
     * @param $class
     *
     * @return string
     * @throws \ReflectionException
     */
    public function getDefaultName($class): string
    {
        $default = config('auth.defaults.guard');
        return $this->getNames($class)->first() ?: $default;
    }
}


1			<?php
2
3			namespace Maklad\Permission;
4
5			use Illuminate\Support\Collection;
6
7			/**
8			* Class Guard
9			* @package Maklad\Permission
10			*/
11			class Guard
12			{
13			/**
14			* return collection of (guard_name) property if exist on class or object
15			* otherwise will return collection of guards names that exists in config/auth.php.
16			*
17			* @param $model
18			*
19			* @return Collection
20			* @throws \ReflectionException
21			*/
22			public function getNames($model) : Collection
23			{
24			if (\is_object($model)) {
25			$guardName = $model->guard_name ?? null;
26			}
27
28			if (! isset($guardName)) {
29			$class = \is_object($model) ? \get_class($model) : $model;
30			$guardName = (new \ReflectionClass($class))->getDefaultProperties()['guard_name'] ?? null;
31			}
32
33			if ($guardName) {
34			return collect($guardName);
35			}
36			return collect(config('auth.guards'))
37			->map(function ($guard) {
38			if (! isset($guard['provider'])) {
39			return;
40			}
41			return config("auth.providers.{$guard['provider']}.model");
42			})
43			->filter(function ($model) use ($class) {
			0 ignored issues – show Bug introduced 2018-03-15 17:37 UTC by Report Bug Copy Issue Report The variable `$class` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
44			return $class === $model;
45			})
46			->keys();
47			}
48
49			/**
50			* Return Default Guard name
51			*
52			* @param $class
53			*
54			* @return string
55			* @throws \ReflectionException
56			*/
57			public function getDefaultName($class): string
58			{
59			$default = config('auth.defaults.guard');
60			return $this->getNames($class)->first() ?: $default;
61			}
62			}
63

mostafamaklad / laravel-permission-mongodb

Pull Request — master (#70)

Guard::getNames() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like