marvin_general_actions.getString() - Code Metrics - Inspection of "More cleanup, like remove writeIrcLog" - mosbth/irc2phpbb - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#75)

unknown

created 2024-10-15 14:44 UTC

marvin_general_actions.getString() B

↳ Parent: marvin_general_actions

Complexity

Conditions

Size

Total Lines	18
Code Lines	13

Duplication

Lines	18
Ratio	100 %

Code Coverage

Tests	1
CRAP Score	34.317

Importance

Changes

Metric	Value
cc	6
eloc	13
nop	2
dl	18
loc	18
ccs	1
cts	13
cp	0.0769
crap	34.317
rs	8.6666
c	0
b	0
f	0

#! /usr/bin/env python3
# -*- coding: utf-8 -*-

"""
Make general actions for Marvin, one function for each action.
"""
import datetime
import random

lastDateGreeted = None


def getAllGeneralActions():
    """
    Return all general actions as an array.
    """
    return [
        marvinMorning
    ]


def marvinMorning(row):
    """
    Marvin says Good morning after someone else says it
    """
    msg = None
    phrases = [
        "morgon",
        "godmorgon",
        "god morgon",
        "morrn",
        "morn"
    ]

    morning_phrases = [
        "Godmorgon! :-)",
        "Morgon allesammans",
        "Morgon gott folk",
        "Guten morgen",
        "Morgon"
    ]

    global lastDateGreeted

    for phrase in phrases:
        if phrase in row:
            if lastDateGreeted != datetime.date.today():
                lastDateGreeted = datetime.date.today()
                msg = random.choice(morning_phrases)
    return msg


1		#! /usr/bin/env python3
2		# -- coding: utf-8 --
3
4		"""
5		Make general actions for Marvin, one function for each action.
6		"""
7	1	import datetime
8	1	import random
9
10	1	lastDateGreeted = None
11
12
13	1	def getAllGeneralActions():
14		"""
15		Return all general actions as an array.
16		"""
17		return [
18		marvinMorning
19		]
20
21
22	1	def marvinMorning(row):
23		"""
24		Marvin says Good morning after someone else says it
25		"""
26	1	msg = None
27	1	phrases = [
28		"morgon",
29		"godmorgon",
30		"god morgon",
31		"morrn",
32		"morn"
33		]
34
35	1	morning_phrases = [
36		"Godmorgon! :-)",
37		"Morgon allesammans",
38		"Morgon gott folk",
39		"Guten morgen",
40		"Morgon"
41		]
42
43		global lastDateGreeted
44
45	1	for phrase in phrases:
46	1	if phrase in row:
47	1	if lastDateGreeted != datetime.date.today():
48	1	lastDateGreeted = datetime.date.today()
49	1	msg = random.choice(morning_phrases)
50		return msg
51

mosbth / irc2phpbb

Pull Request — master (#75)

marvin_general_actions.getString() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like