imgf.php ➔ debug1() - Code Metrics - Inspection of "added and fixed fast track cache script version" - mosbth/cimage - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 0713 ( 0dd562...6cccf5 )

by Mikael

created 2016-07-17 23:01 UTC

imgf.php ➔ debug1() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	1
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * Fast track cache, read entries from the cache before processing image
 * the ordinary way.
 */
 // Include debug functions
function debug1($msg)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    $file = "/tmp/cimage";
    if (!is_writable($file)) {
        return;
    }
    $msg .= ":" . count(get_included_files());
    $msg .= ":" . round(memory_get_peak_usage()/1024/1024, 3) . "MB";
    $msg .= ":" . (string) round((microtime(true) - $_SERVER['REQUEST_TIME_FLOAT']), 6) . "ms";
    file_put_contents($file, "$msg\n", FILE_APPEND);
}


$cachePath = __DIR__ . "/../cache/fasttrack";
$query = $_GET;

// Remove parts from querystring that should not be part of filename
$clear = array("nc", "no-cache");
foreach ($clear as $value) {
    unset($query[$value]);
}

arsort($query);
$queryAsString = http_build_query($query);

$filename = md5($queryAsString);
$filename = "$cachePath/$filename";
if (is_readable($filename)) {
    $item = json_decode(file_get_contents($filename), true);

    if (is_readable($item["source"])) {
        foreach ($item["header"] as $value) {
            header($value);
        }

        if (isset($_SERVER["HTTP_IF_MODIFIED_SINCE"])
            && strtotime($_SERVER["HTTP_IF_MODIFIED_SINCE"]) == $item["last-modified"]) {
            header("HTTP/1.0 304 Not Modified");
            debug1("really fast track 304");
            exit;
        }

        foreach ($item["header-output"] as $value) {
            header($value);
        }

        readfile($item["source"]);
        debug1("really fast track 200");
        exit;
    }
}


// No fast track cache, proceed as usual
include __DIR__ . "/img.php";


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-17 22:47 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 7 and the first side effect is on line 20. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* Fast track cache, read entries from the cache before processing image
4			* the ordinary way.
5			*/
6			// Include debug functions
7			function debug1($msg)
			0 ignored issues – show Coding Style introduced 2016-07-17 23:04 UTC by Report Bug Copy Issue Report `debug1` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
8			{
9			$file = "/tmp/cimage";
10			if (!is_writable($file)) {
11			return;
12			}
13			$msg .= ":" . count(get_included_files());
14			$msg .= ":" . round(memory_get_peak_usage()/1024/1024, 3) . "MB";
15			$msg .= ":" . (string) round((microtime(true) - $_SERVER['REQUEST_TIME_FLOAT']), 6) . "ms";
16			file_put_contents($file, "$msg\n", FILE_APPEND);
17			}
18
19
20			$cachePath = __DIR__ . "/../cache/fasttrack";
21			$query = $_GET;
22
23			// Remove parts from querystring that should not be part of filename
24			$clear = array("nc", "no-cache");
25			foreach ($clear as $value) {
26			unset($query[$value]);
27			}
28
29			arsort($query);
30			$queryAsString = http_build_query($query);
31
32			$filename = md5($queryAsString);
33			$filename = "$cachePath/$filename";
34			if (is_readable($filename)) {
35			$item = json_decode(file_get_contents($filename), true);
36
37			if (is_readable($item["source"])) {
38			foreach ($item["header"] as $value) {
39			header($value);
40			}
41
42			if (isset($_SERVER["HTTP_IF_MODIFIED_SINCE"])
43			&& strtotime($_SERVER["HTTP_IF_MODIFIED_SINCE"]) == $item["last-modified"]) {
44			header("HTTP/1.0 304 Not Modified");
45			debug1("really fast track 304");
46			exit;
47			}
48
49			foreach ($item["header-output"] as $value) {
50			header($value);
51			}
52
53			readfile($item["source"]);
54			debug1("really fast track 200");
55			exit;
56			}
57			}
58
59
60			// No fast track cache, proceed as usual
61			include __DIR__ . "/img.php";
62

mosbth / cimage

Push — 0713 ( 0dd562...6cccf5 )

imgf.php ➔ debug1() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like