Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like CFileBasedContent often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CFileBasedContent, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 8 | class CFileBasedContent |
||
| 9 | { |
||
| 10 | use \Anax\TConfigure, |
||
| 11 | \Anax\DI\TInjectionAware; |
||
| 12 | |||
| 13 | |||
| 14 | |||
| 15 | /** |
||
| 16 | * Properties. |
||
| 17 | */ |
||
| 18 | private $index = null; |
||
| 19 | private $meta = null; |
||
| 20 | private $ignoreCache = false; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * File name pattern, all files must match this pattern and the first |
||
| 24 | * numbered part is optional, the second part becomes the route. |
||
| 25 | */ |
||
| 26 | private $filenamePattern = "#^(\d*)_*([^\.]+)\.md$#"; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * Internal routes that is marked as internal content routes and not |
||
| 30 | * exposed as public routes. |
||
| 31 | */ |
||
| 32 | private $internalRouteDirPattern = [ |
||
| 33 | "#block/#", |
||
| 34 | ]; |
||
| 35 | |||
| 36 | private $internalRouteFilePattern = [ |
||
| 37 | "#^block[_-]{1}#", |
||
| 38 | "#^_#", |
||
| 39 | ]; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Routes that should be used in toc. |
||
| 43 | */ |
||
| 44 | private $allowedInTocPattern = "([\d]+_(\w)+)"; |
||
| 45 | |||
| 46 | |||
| 47 | |||
| 48 | /** |
||
| 49 | * Create a breadcrumb, append slash / to all dirs. |
||
| 50 | * |
||
| 51 | * @param string $route current route. |
||
| 52 | * |
||
| 53 | * @return array with values for the breadcrumb. |
||
| 54 | */ |
||
| 55 | public function createBreadcrumb($route) |
||
| 70 | |||
| 71 | |||
| 72 | |||
| 73 | /** |
||
| 74 | * Get time when the content was last updated. |
||
| 75 | * |
||
| 76 | * @return string with the time. |
||
| 77 | */ |
||
| 78 | /*public function PublishTime() { |
||
| 79 | if(!empty($this['published'])) { |
||
| 80 | return $this['published']; |
||
| 81 | } else if(isset($this['updated'])) { |
||
| 82 | return $this['updated']; |
||
| 83 | } else { |
||
| 84 | return $this['created']; |
||
| 85 | } |
||
| 86 | } |
||
| 87 | */ |
||
| 88 | /** |
||
| 89 | * Get the action for latest updated of the content. |
||
| 90 | * |
||
| 91 | * @return string with the time. |
||
| 92 | */ |
||
| 93 | /*public function PublishAction() { |
||
| 94 | if(!empty($this['published'])) { |
||
| 95 | //return t('Published'); |
||
| 96 | return t('Last updated'); |
||
| 97 | } else if(isset($this['updated'])) { |
||
| 98 | return t('Updated'); |
||
| 99 | } else { |
||
| 100 | return t('Created'); |
||
| 101 | } |
||
| 102 | } |
||
| 103 | */ |
||
| 104 | |||
| 105 | |||
| 106 | |||
| 107 | /** |
||
| 108 | * Set default values from configuration. |
||
| 109 | * |
||
| 110 | * @return this. |
||
| 111 | */ |
||
| 112 | public function setDefaultsFromConfiguration() |
||
| 120 | |||
| 121 | |||
| 122 | |||
| 123 | /** |
||
| 124 | * Should the cache be used or ignored. |
||
| 125 | * |
||
| 126 | * @param boolean $use true to use the cache or false to ignore the cache |
||
| 127 | * |
||
| 128 | * @return this. |
||
| 129 | */ |
||
| 130 | public function useCache($use) |
||
| 136 | |||
| 137 | |||
| 138 | |||
| 139 | /** |
||
| 140 | * Get the index as an array. |
||
| 141 | * |
||
| 142 | * @return array as index. |
||
| 143 | */ |
||
| 144 | public function getIndex() |
||
| 148 | |||
| 149 | |||
| 150 | |||
| 151 | /** |
||
| 152 | * Create the index of all content into an array. |
||
| 153 | * |
||
| 154 | * @return array as index. |
||
| 155 | */ |
||
| 156 | View Code Duplication | private function loadIndex() |
|
| 172 | |||
| 173 | |||
| 174 | |||
| 175 | /** |
||
| 176 | * Check if a filename is to be marked as an internal route.. |
||
| 177 | * |
||
| 178 | * @param string $filepath as the basepath (routepart) to the file. |
||
| 179 | * |
||
| 180 | * @return boolean true if the route content is internal, else false |
||
| 181 | */ |
||
| 182 | private function isInternalRoute($filepath) |
||
| 199 | |||
| 200 | |||
| 201 | |||
| 202 | /** |
||
| 203 | * Check if filepath should be used as part of toc. |
||
| 204 | * |
||
| 205 | * @param string $filepath as the basepath (routepart) to the file. |
||
| 206 | * |
||
| 207 | * @return boolean true if the route content shoul dbe in toc, else false |
||
| 208 | */ |
||
| 209 | private function allowInToc($filepath) |
||
| 213 | |||
| 214 | |||
| 215 | |||
| 216 | /** |
||
| 217 | * Generate an index from the directory structure. |
||
| 218 | * |
||
| 219 | * @return array as index for all content files. |
||
| 220 | */ |
||
| 221 | private function createIndex() |
||
| 260 | |||
| 261 | |||
| 262 | |||
| 263 | /** |
||
| 264 | * Create the index of all meta content into an array. |
||
| 265 | * |
||
| 266 | * @return array as index. |
||
| 267 | */ |
||
| 268 | View Code Duplication | private function loadMetaIndex() |
|
| 284 | |||
| 285 | |||
| 286 | |||
| 287 | /** |
||
| 288 | * Generate an index for meta files. |
||
| 289 | * |
||
| 290 | * @return array as table of content. |
||
| 291 | */ |
||
| 292 | private function createMetaIndex() |
||
| 315 | |||
| 316 | |||
| 317 | |||
| 318 | /** |
||
| 319 | * Get a reference to meta data for specific route. |
||
| 320 | * |
||
| 321 | * @param string $route current route used to access page. |
||
| 322 | * |
||
| 323 | * @return array as table of content. |
||
| 324 | */ |
||
| 325 | private function getMetaForRoute($route) |
||
| 332 | |||
| 333 | |||
| 334 | |||
| 335 | /** |
||
| 336 | * Get the title of a document. |
||
| 337 | * |
||
| 338 | * @deprecated in favor of getFrontmatter |
||
| 339 | * |
||
| 340 | * @param string $file to get title from. |
||
| 341 | * |
||
| 342 | * @return string as the title. |
||
| 343 | */ |
||
| 344 | View Code Duplication | private function getTitle($file) |
|
| 354 | |||
| 355 | |||
| 356 | |||
| 357 | /** |
||
| 358 | * Get the frontmatter of a document. |
||
| 359 | * |
||
| 360 | * @param string $file to get frontmatter from. |
||
| 361 | * |
||
| 362 | * @return array as frontmatter. |
||
| 363 | */ |
||
| 364 | View Code Duplication | private function getFrontmatter($file) |
|
| 374 | |||
| 375 | |||
| 376 | |||
| 377 | /** |
||
| 378 | * Create a table of content for routes at particular level. |
||
| 379 | * |
||
| 380 | * @param string $route base route to use. |
||
| 381 | * |
||
| 382 | * @return array as the toc. |
||
| 383 | */ |
||
| 384 | private function createBaseRouteToc($route) |
||
| 405 | |||
| 406 | |||
| 407 | |||
| 408 | /** |
||
| 409 | * Map the route to the correct key in the index. |
||
| 410 | * |
||
| 411 | * @param string $route current route used to access page. |
||
| 412 | * |
||
| 413 | * @return string as key or false if no match. |
||
| 414 | */ |
||
| 415 | private function mapRoute2IndexKey($route) |
||
| 429 | |||
| 430 | |||
| 431 | |||
| 432 | /** |
||
| 433 | * Map the route to the correct entry in the index. |
||
| 434 | * |
||
| 435 | * @param string $route current route used to access page. |
||
| 436 | * |
||
| 437 | * @return array as the matched route. |
||
| 438 | */ |
||
| 439 | private function mapRoute2Index($route) |
||
| 449 | |||
| 450 | |||
| 451 | |||
| 452 | /** |
||
| 453 | * Get view by mergin information from meta and frontmatter. |
||
| 454 | * |
||
| 455 | * @param string $route current route used to access page. |
||
| 456 | * @param array $frontmatter for the content. |
||
| 457 | * @param string $key for the view to retrive. |
||
| 458 | * @param string $distinct how to merge the array. |
||
| 459 | * |
||
| 460 | * @return array with data to add as view. |
||
| 461 | */ |
||
| 462 | private function getView($route, $frontmatter, $key, $distinct = true) |
||
| 483 | |||
| 484 | |||
| 485 | |||
| 486 | /** |
||
| 487 | * Get details on extra views. |
||
| 488 | * |
||
| 489 | * @param string $route current route used to access page. |
||
| 490 | * @param array $frontmatter for the content. |
||
| 491 | * |
||
| 492 | * @return array with page data to send to view. |
||
| 493 | */ |
||
| 494 | private function getViews($route, $frontmatter) |
||
| 517 | |||
| 518 | |||
| 519 | |||
| 520 | /** |
||
| 521 | * Load extra info intro views based of meta information provided in each |
||
| 522 | * view. |
||
| 523 | * |
||
| 524 | * @param string $view with current settings. |
||
| 525 | * @param string $route to load view from. |
||
| 526 | * |
||
| 527 | * @return array with view details. |
||
| 528 | */ |
||
| 529 | private function getAdditionalViewDataForRoute($view, $route) |
||
| 542 | |||
| 543 | |||
| 544 | |||
| 545 | /** |
||
| 546 | * Order and limit toc items. |
||
| 547 | * |
||
| 548 | * @param string &$toc array with current toc. |
||
| 549 | * @param string &$meta on how to order and limit toc. |
||
| 550 | * |
||
| 551 | * @return void. |
||
| 552 | */ |
||
| 553 | private function orderAndlimitToc(&$toc, &$meta) |
||
| 582 | |||
| 583 | |||
| 584 | |||
| 585 | /** |
||
| 586 | * Find next and previous links of current content. |
||
| 587 | * |
||
| 588 | * @param string $routeIndex target route to find next and previous for. |
||
| 589 | * |
||
| 590 | * @return array with next and previous if found. |
||
| 591 | */ |
||
| 592 | private function findNextAndPrevious($routeIndex) |
||
| 636 | |||
| 637 | |||
| 638 | |||
| 639 | /** |
||
| 640 | * Load extra info into views based of meta information provided in each |
||
| 641 | * view. |
||
| 642 | * |
||
| 643 | * @param array &$views with all views. |
||
| 644 | * @param string $route current route |
||
| 645 | * @param string $routeIndex route with appended /index |
||
| 646 | * |
||
| 647 | * @throws NotFoundException when mapping can not be done. |
||
| 648 | * |
||
| 649 | * @return void. |
||
| 650 | */ |
||
| 651 | private function loadAdditionalContent(&$views, $route, $routeIndex) |
||
| 694 | |||
| 695 | |||
| 696 | |||
| 697 | /** |
||
| 698 | * Load extra info intro views based of meta information provided in each |
||
| 699 | * view. |
||
| 700 | * |
||
| 701 | * @param string $key array with all views. |
||
| 702 | * @param string $content array with all views. |
||
| 703 | * |
||
| 704 | * @throws NotFoundException when mapping can not be done. |
||
| 705 | * |
||
| 706 | * @return void. |
||
| 707 | */ |
||
| 708 | private function loadFileContent($key, $content) |
||
| 730 | |||
| 731 | |||
| 732 | |||
| 733 | /** |
||
| 734 | * Look up the route in the index and use that to retrieve the filtered |
||
| 735 | * content. |
||
| 736 | * |
||
| 737 | * @param string $route to look up. |
||
| 738 | * |
||
| 739 | * @return array with content and filtered version. |
||
| 740 | */ |
||
| 741 | public function mapRoute2Content($route) |
||
| 749 | |||
| 750 | |||
| 751 | |||
| 752 | /** |
||
| 753 | * Map url to content if such mapping can be done, exclude internal routes. |
||
| 754 | * |
||
| 755 | * @param string $route optional route to look up. |
||
| 756 | * |
||
| 757 | * @return object with content and filtered version. |
||
| 758 | */ |
||
| 759 | public function contentForRoute($route = null) |
||
| 769 | |||
| 770 | |||
| 771 | |||
| 772 | /** |
||
| 773 | * Map url to content, even internal content, if such mapping can be done. |
||
| 774 | * |
||
| 775 | * @param string $route optional route to look up. |
||
| 776 | * |
||
| 777 | * @return object with content and filtered version. |
||
| 778 | */ |
||
| 779 | public function contentForInternalRoute($route = null) |
||
| 813 | } |
||
| 814 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.