CDIFactoryDefault - Code Metrics - Inspection of "remove dependencies to create anax-core" - mosbth/anax - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5591c4...e530a3 )

by Mikael

created 2016-05-09 13:11 UTC

CDIFactoryDefault A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	192
Duplicated Lines	10.42 %

Coupling/Cohesion

Components	0
Dependencies	15

Test Coverage

Coverage

26.67%

Importance

Changes	13
Bugs	1	Features	2

Metric	Value
c	13
b	1
f	2
dl	20
loc	192
ccs	32
cts	120
cp	0.2667
rs	9.1666
wmc	4
lcom	0
cbo	15

2 Methods

Rating	Name	Duplication	Size	Complexity
A	loadFile()	0	15	3
B	__construct()	20	158	1

How to fix Duplicated Code

<?php

namespace Anax\DI;

/**
 * Anax base class implementing Dependency Injection / Service Locator
 * of the services used by the framework, using lazy loading.
 */
class CDIFactoryDefault extends CDI
{
    /**
     * Load config file from ANAX_APP_PATH or ANAX_INSTALL_PATH.
     *
     * @param string $filename to load.
     *
     * @throws Exception when $filenam is not found.
     *
     * @return void
     */
    public function loadFile($filename)
    {
        $pathInstall = ANAX_INSTALL_PATH . "/config/$filename";
        $pathApp = ANAX_APP_PATH . "/config/$filename";
        
        if (is_readable($pathApp)) {
            require $pathApp;
            return;
        } elseif (is_readable($pathInstall)) {
            require $pathInstall;
            return;
        }

        throw new Exception("Configure item '$filename' is not a readable file.");
    }



   /**
     * Construct.
     *
     */
    public function __construct()
    {
        parent::__construct();

        $this->loadFile("error_reporting.php");

        $this->setShared("response", "\Anax\Response\CResponseBasic");
        $this->setShared("validate", "\Anax\Validate\CValidate");
        $this->setShared("flash", "\Anax\Flash\CFlashBasic");
        
        $this->set("route", "\Anax\Route\CRouteBasic");
        $this->set("view", "\Anax\View\CView");

        $this->set("ErrorController", function () {
            $controller = new \Anax\MVC\ErrorController();
            $controller->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $controller;
        });

        $this->setShared("log", function () {
            $log = new \Anax\Log\CLogger();
            $log->setContext("development");
            return $log;
        });

        $this->setShared("cache", function () {
            $cache = new \Anax\Cache\CFileCache();
            $cache->configure("cache.php");
            return $cache;
        });

        $this->setShared("request", function () {
            $request = new \Anax\Request\CRequestBasic();
            $request->init();
            return $request;
        });

        $this->setShared("url", function () {
            $url = new \Anax\Url\CUrl();
            $url->setSiteUrl($this->request->getSiteUrl());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setBaseUrl($this->request->getBaseUrl());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setStaticSiteUrl($this->request->getSiteUrl());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setStaticBaseUrl($this->request->getBaseUrl());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setScriptName($this->request->getScriptName());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setUrlType($url::URL_APPEND);
            return $url;
        });

        $this->setShared("views", function () {
            $views = new \Anax\View\CViewContainer();
            $views->configure("views.php");
            $views->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $views;
        });

        $this->setShared("router", function () {
            
            $router = new \Anax\Route\CRouterBasic();
            $router->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $router->addInternal("403", function () {

                $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    "controller" => "error",
                    "action" => "statusCode",
                    "params" => [
                        "code" => 403,
                        "message" => "HTTP Status Code 403: This is a forbidden route.",
                    ],
                ]);
            })->setName("403");
            
            $router->addInternal("404", function () {
                $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    "controller" => "error",
                    "action" => "statusCode",
                    "params" => [
                        "code" => 404,
                        "message" => "HTTP Status Code 404: This route is not found.",
                    ],
                ]);
                $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    "controller" => "error",
                    "action" => "displayValidRoutes",
                ]);
            })->setName("404");
            
            $router->addInternal("500", function () {

                $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    "controller" => "error",
                    "action" => "statusCode",
                    "params" => [
                        "code" => 500,
                        "message" => "HTTP Status Code 500: There was an internal server or processing error.",
                    ],
                ]);
            })->setName("500");
            
            return $router;
        });

        $this->setShared("dispatcher", function () {
            $dispatcher = new \Anax\MVC\CDispatcherBasic();
            $dispatcher->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $dispatcher;
        });

        $this->setShared("session", function () {
            $session = new \Anax\Session\CSession();
            $session->configure("session.php");
            $session->name();
            $session->start();
            return $session;
        });

        $this->setShared("theme", function () {
            $themeEngine = new \Anax\ThemeEngine\CThemeEngine();
            $themeEngine->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $themeEngine->configure("theme.php");
            return $themeEngine;
        });

        $this->setShared("navbar", function () {
            $navbar = new \Anax\Navigation\CNavbar();
            $navbar->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $navbar->configure("navbar.php");
            return $navbar;
        });

        $this->set("fileContent", function () {
            $fc = new \Anax\Content\CFileContent();
            $fc->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $fc->configure("file_content.php");
            return $fc;
        });

        $this->set("pageContent", function () {
            $pc = new \Anax\Content\CPageContent();
            $pc->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $pc->configure("page_content.php");
            return $pc;
        });

        $this->setShared("content", function () {
            $content = new \Anax\Content\CFileBasedContent();
            $content->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $content->configure("content.php");
            $content->setDefaultsFromConfiguration();
            return $content;
        });

        $this->setShared("textFilter", function () {
            //$filter = new \Anax\Content\CTextFilter();
            $filter = new \Mos\TextFilter\CTextFilter();
            //$filter->setDI($this);
            //$filter->configure(ANAX_APP_PATH . "/config/text_filter.php");
            return $filter;
        });
    }
}


1		<?php
2
3		namespace Anax\DI;
4
5		/**
6		* Anax base class implementing Dependency Injection / Service Locator
7		* of the services used by the framework, using lazy loading.
8		*/
9		class CDIFactoryDefault extends CDI
10		{
11		/**
12		* Load config file from ANAX_APP_PATH or ANAX_INSTALL_PATH.
13		*
14		* @param string $filename to load.
15		*
16		* @throws Exception when $filenam is not found.
17		*
18		* @return void
19		*/
20	1	public function loadFile($filename)
21		{
22	1	$pathInstall = ANAX_INSTALL_PATH . "/config/$filename";
23	1	$pathApp = ANAX_APP_PATH . "/config/$filename";
24
25	1	if (is_readable($pathApp)) {
26		require $pathApp;
27		return;
28	1	} elseif (is_readable($pathInstall)) {
29	1	require $pathInstall;
30	1	return;
31		}
32
33		throw new Exception("Configure item '$filename' is not a readable file.");
34		}
35
36
37
38		/**
39		* Construct.
40		*

mosbth / anax

Push — master ( 5591c4...e530a3 )

CDIFactoryDefault A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like