Loom\Comment\CommentsInSession

Complexity

Total Complexity

13

Size/Duplication

Total Lines	105
Duplicated Lines	35.24 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	7
Bugs	2	Features	5

5 Methods

Rating	Name	Duplication	Size	Complexity
B	humanTiming()	23	23	5
A	getGravatar()	14	14	3
A	findAll()	0	16	3
A	update()	0	6	1
A	delete()	0	6	1

<?php
/**
 * class for commenting
 */
namespace Loom\Comment;

class CommentsInSession extends \Phpmvc\Comment\CommentsInSession

There is one abstract method setDI in this class; you could implement it, or declare this class as abstract.

{

    private function humanTiming($time)

This method seems to be duplicated in your project.

    {

        $time = time() - $time; // to get the time since that moment
        $time = ($time<1)? 1 : $time;
        $tokens = array (
            31536000 => 'år',
            2592000 => 'månader',
            604800 => 'veckor',
            86400 => 'dagar',
            3600 => 'timmar',
            60 => 'minuter',
            1 => 'sekunder'
        );

        foreach ($tokens as $unit => $text) {
            if ($time < $unit) {
                continue;
            }
            $numberOfUnits = floor($time / $unit);
            return $numberOfUnits.' '.$text.(($numberOfUnits>1)?' ':'');
        }
    }

    /**
     * Get either a Gravatar URL or complete image tag for a specified email address.
     *
     * @param string $email The email address
     * @param string $s Size in pixels, defaults to 80px [ 1 - 2048 ]
     * @param string $d Default imageset to use [ 404 | mm | identicon | monsterid | wavatar ]
     * @param string $r Maximum rating (inclusive) [ g | pg | r | x ]
     * @param boole $img True to return a complete IMG tag False for just the URL
     * @param array $atts Optional, additional key/value attributes to include in the IMG tag
     * @return String containing either just a URL or a complete image tag
     * @source http://gravatar.com/site/implement/images/php/
     */
    private function getGravatar($email, $s = 80, $d = 'mm', $r = 'g', $img = false, $atts = array())

This method seems to be duplicated in your project.

    {
        $url = 'http://www.gravatar.com/avatar/';
        $url .= md5(strtolower(trim($email)));
        $url .= "?s=$s&d=$d&r=$r";
        if ($img) {
            $url = '<img src="' . $url . '"';
            foreach ($atts as $key => $val) {
                $url .= ' ' . $key . '="' . $val . '"';
            }
            $url .= ' />';
        }
        return $url;
    }

    /**
     * Find and return all comments within the page comment flow.
     *
     * @return array with all comments.
     */
    public function findAll()
    {
        $result = array();
        // TODO: add flow tag through object instantiation instead?
        $flow = $this->request->getRoute();

The property request does not exist. Did you maybe forget to declare it?

        $comments = $this->session->get('comments', []);

The property session does not exist. Did you maybe forget to declare it?

        foreach ($comments as $id => $comment) {
            if ($comment['comment-flow']==$flow) {
                $comment['since-time'] = $this->humanTiming($comment['timestamp']);
                $comment['id'] = $id;
                $comment['gravatar'] = $this->getGravatar($comment['mail']);
                $result[] = $comment;
            }
        }
        return $result;
    }

    /**
     * Update a comment.
     *
     * @param array $comment with all details.
     * @param integer $id of comment to be updated
     *
     * @return void
     */
    public function update($comment, $id)
    {
        $comments = $this->session->get('comments', []);
        $comments[$id] = $comment;
        $this->session->set('comments', $comments);
    }

    /**
     * Delete a comment.
     *
     * @param $id of post to delete.
     *
     * @return void
     */
    public function delete($id)
    {
        $comments = $this->session->get('comments', []);
        unset($comments[$id]);
        $this->session->set('comments', $comments);
    }
}