CDIFactoryDefault::__construct() - Code Metrics - Inspection of "Enhance CResponse::redirect() to use framework url..." - mosbth/Anax-MVC - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3eedc0...aee843 )

by Mikael

created 2016-04-06 12:36 UTC

CDIFactoryDefault::__construct() B

↳ Parent: CDIFactoryDefault

Complexity

Conditions	1
Paths	1

Size

Total Lines	141
Code Lines	98

Duplication

Lines	20
Ratio	14.18 %

Code Coverage

Tests	22
CRAP Score	1.4785

Importance

Changes	17
Bugs	1	Features	1

Metric	Value
c	17
b	1
f	1
dl	20
loc	141
ccs	22
cts	101
cp	0.2178
rs	8.2857
cc	1
eloc	98
nc	1
nop	0
crap	1.4785

How to fix Long Method

<?php

namespace Anax\DI;

/**
 * Anax base class implementing Dependency Injection / Service Locator
 * of the services used by the framework, using lazy loading.
 *
 */
class CDIFactoryDefault extends CDI
{
   /**
     * Construct.
     *
     */
    public function __construct()
    {
        parent::__construct();

        require ANAX_APP_PATH . 'config/error_reporting.php';

        $this->set('response', function () {
            $response = new \Anax\Response\CResponseBasic();
            $response->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $response;
        });

        $this->setShared('validate', '\Anax\Validate\CValidate');
        $this->setShared('flash', '\Anax\Flash\CFlashBasic');
        
        $this->set('route', '\Anax\Route\CRouteBasic');
        $this->set('view', '\Anax\View\CViewBasic');

        $this->set('ErrorController', function () {
            $controller = new \Anax\MVC\ErrorController();
            $controller->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $controller;
        });

        $this->setShared('log', function () {
            $log = new \Anax\Log\CLogger();
            $log->setContext('development');
            return $log;
        });

        $this->setShared('request', function () {
            $request = new \Anax\Request\CRequestBasic();
            $request->init();
            return $request;
        });

        $this->setShared('url', function () {
            $url = new \Anax\Url\CUrl();
            $url->setSiteUrl($this->request->getSiteUrl());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setBaseUrl($this->request->getBaseUrl());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setStaticSiteUrl($this->request->getSiteUrl());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setStaticBaseUrl($this->request->getBaseUrl());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setScriptName($this->request->getScriptName());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $url->setUrlType($url::URL_APPEND);
            return $url;
        });

        $this->setShared('views', function () {
            $views = new \Anax\View\CViewContainerBasic();
            $views->setBasePath(ANAX_APP_PATH . 'view');
            $views->setFileSuffix('.tpl.php');
            $views->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $views;
        });

        $this->setShared('router', function () {
            
            $router = new \Anax\Route\CRouterBasic();
            $router->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $router->addInternal('403', function () {

                $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'controller' => 'error',
                    'action' => 'statusCode',
                    'params' => [
                        'code' => 403,
                        'message' => "HTTP Status Code 403: This is a forbidden route.",
                    ],
                ]);
            })->setName('403');
            
            $router->addInternal('404', function () {
                $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'controller' => 'error',
                    'action' => 'statusCode',
                    'params' => [
                        'code' => 404,
                        'message' => "HTTP Status Code 404: This route is not found.",
                    ],
                ]);
                $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'controller' => 'error',
                    'action' => 'displayValidRoutes',
                ]);
            })->setName('404');
            
            $router->addInternal('500', function () {

                $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'controller' => 'error',
                    'action' => 'statusCode',
                    'params' => [
                        'code' => 500,
                        'message' => "HTTP Status Code 500: There was an internal server or processing error.",
                    ],
                ]);
            })->setName('500');
            
            return $router;
        });

        $this->setShared('dispatcher', function () {
            $dispatcher = new \Anax\MVC\CDispatcherBasic();
            $dispatcher->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $dispatcher;
        });

        $this->setShared('session', function () {
            $session = new \Anax\Session\CSession();
            $session->configure(ANAX_APP_PATH . 'config/session.php');
            $session->name();
            $session->start();
            return $session;
        });

        $this->setShared('theme', function () {
            $themeEngine = new \Anax\ThemeEngine\CThemeBasic();
            $themeEngine->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $themeEngine->configure(ANAX_APP_PATH . 'config/theme.php');
            return $themeEngine;
        });

        $this->setShared('navbar', function () {
            $navbar = new \Anax\Navigation\CNavbar();
            $navbar->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $navbar->configure(ANAX_APP_PATH . 'config/navbar.php');
            return $navbar;
        });

        $this->set('fileContent', function () {
            $fc = new \Anax\Content\CFileContent();
            $fc->setBasePath(ANAX_APP_PATH . 'content/');
            return $fc;
        });

        $this->setShared('textFilter', function () {
            $filter = new \Anax\Content\CTextFilter();
            $filter->setDI($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $filter->configure(ANAX_APP_PATH . 'config/text_filter.php');
            return $filter;
        });
    }
}


1		<?php
2
3		namespace Anax\DI;
4
5		/**
6		* Anax base class implementing Dependency Injection / Service Locator
7		* of the services used by the framework, using lazy loading.
8		*
9		*/
10		class CDIFactoryDefault extends CDI
11		{
12		/**
13		* Construct.
14		*
15		*/
16	1	public function __construct()
17		{
18	1	parent::__construct();
19
20	1	require ANAX_APP_PATH . 'config/error_reporting.php';
21
22		$this->set('response', function () {
23		$response = new \Anax\Response\CResponseBasic();
24		$response->setDI($this);
		0 ignored issues – show Documentation introduced 2016-04-06 12:38 UTC by Report Bug Copy Issue Report `$this` is of type `this<Anax\DI\CDIFactoryDefault>`, but the function expects a `object<Anax\DI\class>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25		return $response;
26	1	});
27
28	1	$this->setShared('validate', '\Anax\Validate\CValidate');
29	1	$this->setShared('flash', '\Anax\Flash\CFlashBasic');
30
31	1	$this->set('route', '\Anax\Route\CRouteBasic');
32	1	$this->set('view', '\Anax\View\CViewBasic');
33
34		$this->set('ErrorController', function () {
35		$controller = new \Anax\MVC\ErrorController();
36		$controller->setDI($this);
		0 ignored issues – show Documentation introduced 2015-11-29 16:29 UTC by Report Bug Copy Issue Report `$this` is of type `this<Anax\DI\CDIFactoryDefault>`, but the function expects a `object<Anax\DI\class>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37		return $controller;
38	1	});

mosbth / Anax-MVC

Push — master ( 3eedc0...aee843 )

CDIFactoryDefault::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like