QuestionsController - Code Metrics - Inspection of "Kmom10 1- no2" - mosbth/Anax-MVC - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by Fredrik

created 2016-03-27 21:59 UTC

QuestionsController B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	453
Duplicated Lines	3.31 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	9
Bugs	2	Features	2

Metric	Value
wmc	36
c	9
b	2
f	2
lcom	1
cbo	8
dl	15
loc	453
rs	8.8

14 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	15	1
A	setupAction()	0	5	1
A	recentquestionsAction()	0	17	2
C	listAction()	0	92	10
B	acceptAnswer()	0	13	5
A	showformAction()	0	5	1
A	showFormCommentOrAnswer()	0	22	3
B	singleAction()	0	104	4
A	askAction()	15	15	2
B	createAddQuestionForm()	0	34	2
B	callbackSubmitAddQuestion()	0	31	2
A	callbackSubmitFailAddQuestion()	0	6	1
A	callbackSuccess()	0	6	1
A	callbackFail()	0	6	1

How to fix Duplicated Code

<?php

namespace Anax\Questions;

/**
 * A controller for "Questions".
 *
 */
class QuestionsController implements \Anax\DI\IInjectionAware
{
    use \Anax\DI\TInjectable,
    \Anax\MVC\TRedirectHelpers;

    /**
     * Initialize the controller.
     *
     * @return void
     */
    public function initialize()
    {
        $this->questions = new \Anax\Questions\CQuestions();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->questions->setDI($this->di);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->tags = new \Anax\Tags\CTags();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->tags->setDI($this->di);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->tags2Questions = new \Anax\Tags\CTags2Question();

        $this->tags2Questions->setDI($this->di);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->users = new \Anax\Users\User();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->users->setDI($this->di);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->answers = new \Anax\Answers\CAnswers();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->answers->setDI($this->di);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->comments = new \Anax\CommentDb\CommentsInDb();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->comments->setDI($this->di);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * Setup initial table for users.
     *
     * @return void
     */
    public function setupAction()
    {
        $this->questions->init();
        // $this->redirectTo('questions/');
    }

    /**
    * List recent questions.
     *
     * @return void
     */
    public function recentquestionsAction($count)
    {
        $this->views->add('default/page', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'title'     => 'Senaste frågorna',
            'content'     => 'Här hittar du de senast ställda frågorna',
        ]);
        $all = $this->questions->findRecent($count);
        foreach ($all as $question) {
            // TODO: Add more stuff into view? User, tags, ?
            // or shorten down and place in grid-box?
            // Add headline in view, "Senaste frågorna", or in index.php
            $this->views->add('questions/short', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'title'     => 'Senaste frågorna',
                'question'  => $question->getProperties(),
            ]);
        }
    }

    /**
     * List all questions.
     *
     * @return void
     */
    public function listAction($what = null, $id = null)
    {
        // Collect all questions in $questions array.
        $questions = array();
        switch ($what) {
            case 'tags':
                $tag = $this->tags->find($id)->getProperties();
                $title = "Kategori {$tag['name']}";
                $content = "Frågor i kategori {$tag['name']}";
                $qids = $this->tags2Questions->query()

                            ->where("tag_id = $id")
                            ->execute();
                foreach ($qids as $qid) {
                    $question = $this->questions->find($qid->question_id);
                    $questions[] = $question->getProperties();
                }
                break;
            case 'answers':
                $user = $this->users->query()
                ->where('acronym = ' . "'$id'")
                ->execute()[0];
                $answers = $this->answers->query()
                ->where('user_id = ' . "'$user->id'")
                ->execute();
                foreach ($answers as $answer) {
                    $questions[] =  $this->questions->query()
                    ->where('id = ' . "'$answer->q_id'")
                    ->execute()[0]->getProperties();
                }
                // Remove duplicate questions. E.g. same user answered multiple times on same question.
                $questions = array_unique($questions, SORT_REGULAR);
                $title = "Frågor svarade av {$user->name}";
                $content = "Frågor besvarade av {$user->name}";
                break;
            case 'questions':
                $user = $this->users->query()
                ->where('acronym = ' . "'$id'")
                ->execute()[0];
                $all = $this->questions->query()
                ->where('user_id = ' . "'$user->id'")
                ->execute();
                foreach ($all as $question) {
                    $questions[] = $question->getProperties();
                }
                $title = "Frågor från {$user->name}";
                $content = "Frågor ställda av {$user->name}";
                break;

            default:
                $title = "Alla frågor";
                $content = "Visa alla frågor";
                $all = $this->questions->findAll();
                foreach ($all as $question) {
                    $questions[] = $question->getProperties();
                }
                break;
        }
        // Display questions with tags and user.
        $this->theme->setTitle("Frågor");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->views->add('default/page', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'title' => $title,
            'content' => $content,
        ]);
        foreach ($questions as $question) {
            $allTagsId = $this->tags2Questions->query()

            ->where('question_id = ' . "'{$question['id']}'")
            ->execute();

            // TODO: is below with $allTags needed?
            $allTags = array();
            foreach ($allTagsId as $tid) {
                $allTags[] = $this->tags->find($tid->tag_id)->getProperties();
            }
            $this->views->add('questions/short', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'question' => $question,
            ]);
            // Add view with the questions tags
            $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'controller' => 'tags',
                'action'     => 'question',
                'params'    => [$question['id'],  ],
            ]);
            // Add view with users card
            $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'controller' => 'users',
                'action'     => 'card',
                'params'    => [
                    $question['user_id'],
                ],
            ]);
        }
    }

    public function acceptAnswer($answer, $question)
    {
        if ($this->users->loggedIn() &&
            ($this->users->loggedInUser()->id == $question->user_id) &&
            !$answer->accepted &&
            !$question->accepted_answer) {
            $acceptUrl['href'] = $this->url->create('answers/accept/' . $answer->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $acceptUrl['text'] = '| Acceptera svar';
            $this->views->add('default/link', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'link' => $acceptUrl,
            ]);
        }
    }

    /**
     * Route to enable showing of comment or answer form
     * This is used when displaying single question
     *
     * @param int $form answer, comment_question, comment_answer
     *
     * @return void
     */
    public function showformAction($form)
    {
        $this->session->set('ShowFormCorA', $form);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->redirectTo($_SERVER['HTTP_REFERER']);
    }

    /**
     * Route to show link to or comment or answer form
     *
     * @param   string $form {answer, comment_question, comment_answer}
     *          string $controller to handle form
     *          int $id of question or answer
     *          string $linkText to display on linkText
     *          string 'q' or 'a' on comment on question or comment on answer
     *
     * @return void
     */
    private function showFormCommentOrAnswer($form, $controller, $id, $linkText, $qora = null)
    {
        // Add view to comment question
        if ($this->session->get('ShowFormCorA')==$form) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'controller' => $controller,
                    'action'     => 'add',
                    'params'    => [$id, $qora, ],
                ]);
        } else {
            if ($this->users->loggedIn()) {
                $route = "questions/showform/$form";
            } else {
                $route = 'users/login';
            }
            $commentFormUrl['href'] = $this->url->create($route);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $commentFormUrl['text'] = $linkText;
            $this->views->add('default/link', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'link' => $commentFormUrl,
            ]);
        }
    }
    /**
     * List single question
     *
     * @param int $id of question to display
     *
     * @return void
     */
    public function singleAction($id = null)
    {
        $question = $this->questions->query()
        ->where('id = ' . "'$id'")
        ->execute()[0];

        // Add view with the question.
        $this->theme->setTitle("$question->headline");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->views->add('questions/single', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'question' => $question,
        ]);

        // Add view with the questions tags
        $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'controller' => 'tags',
            'action'     => 'question',
            'params'    => [$question->id,  ],
        ]);

        // Add view with user card.
        $humanTime = \Anax\CommentDb\CommentsInDb::humanTiming($question->created);
        $text = "Frågade för $humanTime sedan";
        $this->dispatcher->forward([
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'controller' => 'users',
            'action'     => 'card',
            'params'    => [$question->user_id, 'q', $text, ],
        ]);

        // Add view to comment question, form visible when logged in and clicking link.
        $this->showFormCommentOrAnswer('comment_question', 'comment', $question->id, 'Kommentera ', 'q');

        // Add view to answer question, form visible when logged in and clicking link.
        $this->showFormCommentOrAnswer('answer', 'answers', $question->id, '| Besvara ');

        // Add view with Comments to question
        $allComments = $this->comments->query()
            ->where("q_or_a = 'q'")
            ->andwhere("q_or_a_id = $id")
            ->execute();
        $nrOfComments = sizeof($allComments);
        $commentsListData = array();
        for ($j=0; $j < $nrOfComments; $j++) {
            $commentsListData[$j]['comment'] = $allComments[$j]->getProperties();
            // Get user of comment
            $user = $this->users->find($allComments[$j]->user_id);
            $commentsListData[$j]['user'] = $user->getProperties();
        }
        $this->views->add('questions/comments', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'comments' => $commentsListData,
        ]);

        // Display all answers and comments to each answer.
        // Display all answers to question.
        $allAnswers = $this->answers->query()
            ->where("q_id = $question->id")
            ->execute();
        $this->views->add('questions/answersheading', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'title' => sizeof($allAnswers) . " svar",
        ]);
        foreach ($allAnswers as $answer) {
            $user = $this->users->find($answer->user_id);
            // Add view to display all answer.
            $this->views->add('questions/answer', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'answer' => $answer->getProperties(),
                'user'  => $user->getProperties(),
            ]);
            // Display link or comment form for commenting the answer
            $this->showFormCommentOrAnswer(
                'comment_answer_' . $answer->id,
                'comment',
                $answer->id,
                'Kommentera ',
                'a'
            );
            $this->acceptAnswer($answer, $question);

            // Get all comments to answer
            $allComments = $this->comments->query()
                ->where("q_or_a = 'a'")
                ->andwhere("q_or_a_id = $answer->id")
                ->execute();
            $commentsListData = array();
            foreach ($allComments as $comment) {
                $user = $this->users->find($comment->user_id);
                $commentsListData[] = [
                    'comment' => $comment->getProperties(),
                    'user' => $user->getProperties(),
                ];
            }
            $this->views->add('questions/comments', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'comments' => $commentsListData,
            ]);
        }

        $this->views->add('default/page', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'content'   => ' ',
            'links' => [
                [
                    'href' => $this->url->create('questions/ask'),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'text' => "Fråga en fråga",
                ],
            ],
        ]);
    }

    /**
     * Ask new question
     *
     * @param string $route to page for comment flow.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return void
     */
    public function askAction()

    {
        if ($this->users->loggedIn()) {
            $this->di->session(); // Will load the session service which also starts the session
            $form = $this->createAddQuestionForm();
            $form->check([$this, 'callbackSuccess'], [$this, 'callbackFail']);
            $this->di->theme->setTitle("Fråga");
            $this->di->views->add('default/page', [
                'title' => "Ställ en fråga",
                'content' => $form->getHTML()
            ]);
        } else {
            $this->redirectTo($this->url->create('users/login'));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }
    private function createAddQuestionForm()
    {
        $tags = $this->tags->findAll();
        foreach ($tags as $tag) {
            $tagArray[] = $tag->name;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        return $this->di->form->create([], [
            'headline' => [
                'type'        => 'text',
                'label'       => 'Rubrik:',
                'required'    => true,
                'validation'  => ['not_empty'],
            ],
            'content' => [
                'type'        => 'textarea',
                'label'       => 'Fråga:',
                'required'    => true,
                'validation'  => ['not_empty'],
            ],
            "tags" => [
                "type"        => "checkbox-multiple",
                'label'       => 'Kategorier:',
                "values"      => $tagArray,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            ],
            'submit' => [
                'type'      => 'submit',
                'callback'  => [$this, 'callbackSubmitAddQuestion'],
            ],
            // 'submit-fail' => [
            //     'type'      => 'submit',
            //     'callback'  => [$this, 'callbackSubmitFailAddQuestion'],
            // ],
        ]);
    }
    /**
     * Callback for submit-button.
     *
     */
    public function callbackSubmitAddQuestion($form)
    {
        // $form->AddOutput("<p>DoSubmit(): Form was submitted.<p>");
        // $form->AddOutput("<p>Do stuff (save to database) and return true (success) or false (failed processing)</p>");

        // Save comment to database
        $now = time();
        $this->questions->save([
            'headline' => $form->Value('headline'),
            'content' => $form->Value('content'),
            'user_id' => $this->users->loggedInUser()->id,
            'vote' => 0,
            'created' => $now,
        ]);
        // Pull out tags and store them in tags2question model
        $qid = $this->questions->id;
        $tags = $form->Value('tags');
        foreach ($tags as $tag) {
            $tag_id = $this->tags->findTag($tag)->getProperties()['id'];
            unset($this->tags2Questions->id);
            $this->tags2Questions->save([

                'tag_id' => $tag_id,
                'question_id' => $qid,
            ]);
        }

        // $form->AddOutput("<p><b>Name: " . $form->Value('name') . "</b></p>");
        // $form->AddOutput("<p><b>Email: " . $form->Value('mail') . "</b></p>");
        $form->saveInSession = false;
        return true;
    }
    /**
     * Callback for submit-button.
     *
     */
    public function callbackSubmitFailAddQuestion($form)
    {
        // TODO: Remove this?
        $form->AddOutput("<p><i>DoSubmitFail(): Form was submitted but I failed to process/save/validate it</i></p>");
        return false;
    }
    /**
     * Callback What to do if the form was submitted?
     *
     */
    public function callbackSuccess($form)
    {
        $form->AddOUtput("<p><i>Form was submitted and the callback method returned true.</i></p>");
        // Redirect to page displaying the new question.
        $this->redirectTo($this->url->create('questions/single/' . $this->questions->id));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
    /**
     * Callback What to do when form could not be processed?
     *
     */
    public function callbackFail($form)
    {
        $form->AddOutput("<p><i>Form was submitted and the Check() method returned false.</i></p>");
        // Redirect to comment form.
        $this->redirectTo();
    }
}


1			<?php
2
3			namespace Anax\Questions;
4
5			/**
6			* A controller for "Questions".
7			*
8			*/
9			class QuestionsController implements \Anax\DI\IInjectionAware
10			{
11			use \Anax\DI\TInjectable,
12			\Anax\MVC\TRedirectHelpers;
13
14			/**
15			* Initialize the controller.
16			*
17			* @return void
18			*/
19			public function initialize()
20			{
21			$this->questions = new \Anax\Questions\CQuestions();
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report The property `questions` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22			$this->questions->setDI($this->di);
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report It seems like `$this->di` can also be of type `array` or `null`; however, `Anax\DI\TInjectable::setDI()` does only seem to accept `object<Anax\DI\class>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
23			$this->tags = new \Anax\Tags\CTags();
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report The property `tags` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			$this->tags->setDI($this->di);
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report It seems like `$this->di` can also be of type `array` or `null`; however, `Anax\DI\TInjectable::setDI()` does only seem to accept `object<Anax\DI\class>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
25			$this->tags2Questions = new \Anax\Tags\CTags2Question();
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report The property `tags2Questions` does not seem to exist. Did you mean `questions`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
26			$this->tags2Questions->setDI($this->di);
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report The property `tags2Questions` does not seem to exist. Did you mean `questions`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history... Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report It seems like `$this->di` can also be of type `array` or `null`; however, `Anax\DI\TInjectable::setDI()` does only seem to accept `object<Anax\DI\class>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
27			$this->users = new \Anax\Users\User();
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report The property `users` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			$this->users->setDI($this->di);
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report It seems like `$this->di` can also be of type `array` or `null`; however, `Anax\DI\TInjectable::setDI()` does only seem to accept `object<Anax\DI\class>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
29			$this->answers = new \Anax\Answers\CAnswers();
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report The property `answers` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30			$this->answers->setDI($this->di);
			0 ignored issues – show Bug introduced 2016-03-27 22:02 UTC by Report Bug Copy Issue Report It seems like `$this->di` can also be of type `array` or `null`; however, `Anax\DI\TInjectable::setDI()` does only seem to accept `object<Anax\DI\class>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...

mosbth / Anax-MVC

Pull Request — master (#20)

QuestionsController B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like