Inspection of "bugfixes and refactoring" - morphatic/laravel-auto-deploy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 76c4af...25f226 )

by Morgan

created 2015-12-02 21:32 UTC

Status

Doc Comments -1 removed lines patch added patch discarded remove patch

@@ -45,7 +45,6 @@
 block discarded – undo
     /**
      * Determine the origin of a deploy request.
      *
-     * @param Illuminate\Http\Request $request The Request object.
      *
      * @return \Morphatic\AutoDeploy\Origins\OriginInterface An object corresponding to the origin type or null.
      */

Please login to merge, or discard this patch.

src/Origins/Github.php 1 patch

Doc Comments +1 added lines, -6 removed lines patch added patch discarded remove patch

@@ -14,7 +14,6 @@  discard block
 block discarded – undo
     /**
      * Determines whether or not the Request originated from Github.
      *
-     * @param Illuminate\Http\Request $this->request The Request object
      *
      * @return bool Returns true if the request originated from Github. False otherwise.
      */
@@ -36,9 +35,8 @@  discard block
 block discarded – undo
      *
      * Follows the procedure described here: https://developer.github.com/webhooks/securing/
      *
-     * @param Illuminate\Http\Request $this->request The Request object
      *
-     * @return bool Returns true if the request is authentic. False otherwise.
+     * @return null|boolean Returns true if the request is authentic. False otherwise.
      */
     public function verify()
     {
@@ -55,7 +53,6 @@  discard block
 block discarded – undo
     /**
      * Gets the event the triggered the webhook request.
      *
-     * @param Illuminate\Http\Request $this->request The Request object
      *
      * @return string The name of the event, e.g. push, release, create, etc.
      */
@@ -67,7 +64,6 @@  discard block
 block discarded – undo
     /**
      * Gets the URL to be cloned from.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The URL of the repo.
      */
@@ -79,7 +75,6 @@  discard block
 block discarded – undo
     /**
      * Gets the ID of the commit that is to be cloned.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The commit ID.
      */

Please login to merge, or discard this patch.

src/Origins/OriginInterface.php 1 patch

Doc Comments -5 removed lines patch added patch discarded remove patch

@@ -7,7 +7,6 @@  discard block
 block discarded – undo
     /**
      * Determines whether or not the Request originated from the webhook origin.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return bool Returns true if the request originated from this origin. False otherwise.
      */
@@ -16,7 +15,6 @@  discard block
 block discarded – undo
     /**
      * Verifies the authenticity of a webhook request from the origin.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return bool Returns true if the request is authentic. False otherwise.
      */
@@ -25,7 +23,6 @@  discard block
 block discarded – undo
     /**
      * Gets the event the triggered the webhook request.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The name of the event, e.g. push, release, create, etc.
      */
@@ -34,7 +31,6 @@  discard block
 block discarded – undo
     /**
      * Gets the URL to be cloned from.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The URL of the repo.
      */
@@ -43,7 +39,6 @@  discard block
 block discarded – undo
     /**
      * Gets the ID of the commit that is to be cloned.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The commit ID.
      */

Please login to merge, or discard this patch.

src/Controllers/DeployController.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -75,8 +75,8 @@  discard block
 block discarded – undo
     /**
      * Create a new DeployController instance.
      *
-     * @param Morphatic\AutoDeploy\Origins\OriginInterface $origin The origin of the webhook
-     * @param AdamBrett\ShellWrapper\Runners\Exec          $exec   The shell command execution class
+     * @param OriginInterface $origin The origin of the webhook
+     * @param Exec          $exec   The shell command execution class
      */
     public function __construct(OriginInterface $origin, Exec $exec)
     {
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
     /**
      * Runs a shell command, logs, and handles the result.
      *
-     * @param AdamBrett\ShellWrapper\CommandInterface $cmd The text of the command to be run
+     * @param CommandInterface $cmd The text of the command to be run
      *
      * @return bool True if the command was successful, false on error
      */

Please login to merge, or discard this patch.

src/Origins/AbstractOrigin.php 1 patch

Doc Comments -5 removed lines patch added patch discarded remove patch

@@ -7,7 +7,6 @@  discard block
 block discarded – undo
     /**
      * Determines whether or not the Request originated from the webhook origin.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return bool Returns true if the request originated from this origin. False otherwise.
      */
@@ -16,7 +15,6 @@  discard block
 block discarded – undo
     /**
      * Verifies the authenticity of a webhook request from the origin.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return bool Returns true if the request is authentic. False otherwise.
      */
@@ -25,7 +23,6 @@  discard block
 block discarded – undo
     /**
      * Gets the event the triggered the webhook request.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The name of the event, e.g. push, release, create, etc.
      */
@@ -34,7 +31,6 @@  discard block
 block discarded – undo
     /**
      * Gets the URL to be cloned from.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The URL of the repo.
      */
@@ -43,7 +39,6 @@  discard block
 block discarded – undo
     /**
      * Gets the ID of the commit that is to be cloned.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The commit ID.
      */

Please login to merge, or discard this patch.

		@@ -45,7 +45,6 @@
		block discarded – undo
45	45	/**
46	46	* Determine the origin of a deploy request.
47	47	*
48		- * @param Illuminate\Http\Request $request The Request object.
49	48	*
50	49	* @return \Morphatic\AutoDeploy\Origins\OriginInterface An object corresponding to the origin type or null.
51	50	*/

		@@ -14,7 +14,6 @@ discard block
		block discarded – undo
14	14	/**
15	15	* Determines whether or not the Request originated from Github.
16	16	*
17		- * @param Illuminate\Http\Request $this->request The Request object
18	17	*
19	18	* @return bool Returns true if the request originated from Github. False otherwise.
20	19	*/
		@@ -36,9 +35,8 @@ discard block
		block discarded – undo
36	35	*
37	36	* Follows the procedure described here: https://developer.github.com/webhooks/securing/
38	37	*
39		- * @param Illuminate\Http\Request $this->request The Request object
40	38	*
41		- * @return bool Returns true if the request is authentic. False otherwise.
	39	+ * @return null\|boolean Returns true if the request is authentic. False otherwise.
42	40	*/
43	41	public function verify()
44	42	{
		@@ -55,7 +53,6 @@ discard block
		block discarded – undo
55	53	/**
56	54	* Gets the event the triggered the webhook request.
57	55	*
58		- * @param Illuminate\Http\Request $this->request The Request object
59	56	*
60	57	* @return string The name of the event, e.g. push, release, create, etc.
61	58	*/
		@@ -67,7 +64,6 @@ discard block
		block discarded – undo
67	64	/**
68	65	* Gets the URL to be cloned from.
69	66	*
70		- * @param Illuminate\Http\Request $request The Request object
71	67	*
72	68	* @return string The URL of the repo.
73	69	*/
		@@ -79,7 +75,6 @@ discard block
		block discarded – undo
79	75	/**
80	76	* Gets the ID of the commit that is to be cloned.
81	77	*
82		- * @param Illuminate\Http\Request $request The Request object
83	78	*
84	79	* @return string The commit ID.
85	80	*/

		@@ -7,7 +7,6 @@ discard block
		block discarded – undo
7	7	/**
8	8	* Determines whether or not the Request originated from the webhook origin.
9	9	*
10		- * @param Illuminate\Http\Request $request The Request object
11	10	*
12	11	* @return bool Returns true if the request originated from this origin. False otherwise.
13	12	*/
		@@ -16,7 +15,6 @@ discard block
		block discarded – undo
16	15	/**
17	16	* Verifies the authenticity of a webhook request from the origin.
18	17	*
19		- * @param Illuminate\Http\Request $request The Request object
20	18	*
21	19	* @return bool Returns true if the request is authentic. False otherwise.
22	20	*/
		@@ -25,7 +23,6 @@ discard block
		block discarded – undo
25	23	/**
26	24	* Gets the event the triggered the webhook request.
27	25	*
28		- * @param Illuminate\Http\Request $request The Request object
29	26	*
30	27	* @return string The name of the event, e.g. push, release, create, etc.
31	28	*/
		@@ -34,7 +31,6 @@ discard block
		block discarded – undo
34	31	/**
35	32	* Gets the URL to be cloned from.
36	33	*
37		- * @param Illuminate\Http\Request $request The Request object
38	34	*
39	35	* @return string The URL of the repo.
40	36	*/
		@@ -43,7 +39,6 @@ discard block
		block discarded – undo
43	39	/**
44	40	* Gets the ID of the commit that is to be cloned.
45	41	*
46		- * @param Illuminate\Http\Request $request The Request object
47	42	*
48	43	* @return string The commit ID.
49	44	*/

		@@ -75,8 +75,8 @@ discard block
		block discarded – undo
75	75	/**
76	76	* Create a new DeployController instance.
77	77	*
78		- * @param Morphatic\AutoDeploy\Origins\OriginInterface $origin The origin of the webhook
79		- * @param AdamBrett\ShellWrapper\Runners\Exec $exec The shell command execution class
	78	+ * @param OriginInterface $origin The origin of the webhook
	79	+ * @param Exec $exec The shell command execution class
80	80	*/
81	81	public function __construct(OriginInterface $origin, Exec $exec)
82	82	{
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	/**
132	132	* Runs a shell command, logs, and handles the result.
133	133	*
134		- * @param AdamBrett\ShellWrapper\CommandInterface $cmd The text of the command to be run
	134	+ * @param CommandInterface $cmd The text of the command to be run
135	135	*
136	136	* @return bool True if the command was successful, false on error
137	137	*/

morphatic / laravel-auto-deploy

Push — master ( 76c4af...25f226 )

Status

Category

Doc Comments -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments -5 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments -5 removed lines patch added patch discarded remove patch