moonstonemedia / Simple-Calendar

includes/admin/pages/calendars.php

<?php
/**
 * Calendar Settings Page
 *
 * @package SimpleCalendar/Admin
 */
namespace SimpleCalendar\Admin\Pages;

use SimpleCalendar\Abstracts\Calendar;
use SimpleCalendar\Abstracts\Admin_Page;

if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * Calendar settings.
 *
 * Handles settings for specific calendar types and outputs the markup the settings page. a settings page.
 *
 * @since 3.0.0
 */
class Calendars extends Admin_Page {

	/**
	 * Calendar Types.
	 *
	 * @access private
	 * @var array
	 */
	private $calendar_types = array();

	/**
	 * Constructor.
	 *
	 * @since 3.0.0
	 */
	public function __construct() {

This method seems to be duplicated in your project.

		$this->id               = 'calendars';
		$this->option_group     = 'settings';
		$this->label            = __( 'Calendars', 'google-calendar-events' );
		//$this->description      = __( 'Manage calendar preferences and calendar types settings and options.', 'google-calendar-events' );

50% of this comment could be valid code. Did you maybe forget this after debugging?

		$calendars = simcal_get_calendar_types();
		$calendar_settings = array();
		if ( ! empty( $calendars ) && is_array( $calendars ) ) {
			foreach ( $calendars as $calendar => $views ) {

				$calendar_type = simcal_get_calendar( $calendar );

				if ( $calendar_type instanceof Calendar ) {
					$settings = $calendar_type->settings_fields();
					if ( ! empty( $settings ) ) {
						$calendar_settings[ $calendar ] = $settings;
					}
				}
			}
		}

		$this->calendar_types = $calendar_settings;
		$this->sections       = $this->add_sections();
		$this->fields         = $this->add_fields();
	}

	/**
	 * Add sections.
	 *
	 * @since  3.0.0
	 *
	 * @return array
	 */
	public function add_sections() {

		$sections = array(
			'general' => array(
				'title'       => __( 'General', 'google-calendar-events' ),
				'description' => '',
			),
		);

		$calendar_types = $this->calendar_types;

		if ( ! empty( $calendar_types ) && is_array( $calendar_types ) ) {
			foreach ( $calendar_types as $calendar_type => $type ) {

				$sections[ $calendar_type ] = array(
					'title' => $type['name'],
					'description' => $type['description'],
				);

			}
		}

		arsort( $calendar_types );

		return apply_filters( 'simcal_add_' . $this->option_group . '_' . $this->id .'_sections', $sections );
	}

	/**
	 * Add fields.
	 *
	 * @since  3.0.0
	 *
	 * @return array
	 */
	public function add_fields() {

		$fields       = array();
		$feed_types   = $this->calendar_types;
		$this->values = get_option( 'simple-calendar_' . $this->option_group . '_' . $this->id );

		foreach ( $this->sections as $section => $contents ) :

			if ( 'general' == $section ) {

				$options    = array();
				$post_types = get_post_types(
					array(
						'public' => false,
						'publicly_queriable' => false,
						'show_ui' => false,
					),
					'objects',
					'not'
				);
				unset( $post_types['attachment'] );
				unset( $post_types['calendar'] );
				unset( $post_types['gce_feed'] );
				foreach ( $post_types as $slug => $post_type ) {
					$options[ $slug ] = $post_type->label;
				}
				asort( $options );

				$fields[ $section ][] = array(
					'type'        => 'select',
					'multiselect' => 'multiselect',
					'enhanced'    => 'enhanced',
					'title'       => __( 'Attach Calendars', 'google-calendar-events' ),
					'tooltip'     => __( 'You can choose on which content types to add the ability to attach calendars.', 'google-calendar-events' ),
					'name'        => 'simple-calendar_' . $this->option_group . '_' . $this->id . '[' . $section . '][attach_calendars_posts]',
					'id'          => 'simple-calendar-' . $this->option_group . '-' . $this->id . '-attach-calendars-posts',
					'value'       => $this->get_option_value( $section, 'attach_calendars_posts' ),
					'default'     => 'post,page',
					'options'     => $options,
				);

			} elseif ( isset( $feed_types[ $section ]['fields'] ) ) {

This code seems to be duplicated across your project.

				foreach ( $feed_types[ $section ]['fields'] as $key => $args ) {

					$fields[ $section ][] = array_merge( $args, array(
						'name'  => 'simple-calendar_' . $this->option_group . '_' . $this->id . '[' . $section . '][' . $key . ']',
						'id'    => 'simple-calendar-' . $this->option_group . '-' . $this->id . '-' . $key,
						'value' => $this->get_option_value( $section, $key )
					) );

				}

			}

		endforeach;

		return apply_filters( 'simcal_add_' . $this->option_group . '_' . $this->id . '_fields', $fields );
	}

}